New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 694928 link

Starred by 6 users

Issue metadata

Status: Verified
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 684849



Sign in to add a comment

Cannot find opt-in IME menu entry in settings page

Project Member Reported by azurewei@chromium.org, Feb 22 2017

Issue description

Chrome Version: 58.0.3019
OS: Chrome OS

What steps will reproduce the problem?
(1) open settings page 
(2) In "Languages and input" section, cannot find checkbox "Show input options on the shelf" to enable/disable opt-in IME menu.

"Show input options on the shelf" is the only entry for opt-in IME menu. Without it, users cannot enable/disable the new menu.



 
new-setting.png
73.6 KB View Download
old-settings.png
142 KB View Download

Comment 1 by dpa...@chromium.org, Feb 22 2017

Cc: dbeam@chromium.org tbuck...@chromium.org dpa...@chromium.org
Owner: ----
+dbeam, tbuckley for properly prioritizing this issue.
Blocking: 684849
Labels: Hotlist-MD-Settings-Languages
Owner: steve...@chromium.org
@stevenjb can you add this since it's CrOS-only?
Labels: M-58
Cc: bettes@chromium.org
+bettes@

I am going to implement this as a toggle in the current inlined expanded section under 'Input method'. We should add it to the un-inlined mocks at some point.
Status: Started (was: Assigned)
Status: Fixed (was: Started)
Fix not in TOT build 9331.0.0 / 58.0.3027.0
Status: Verified (was: Fixed)
Verified on ChromeOS 9334.0.0 / 58.0.3028.0
Status: Assigned (was: Verified)
Steven, looks like this issue is not fixed in M58.

Can you please cherrypick the fix cl to M58? Thanks.

Labels: Merge-Request-58
Project Member

Comment 13 by sheriffbot@chromium.org, Mar 6 2017

Labels: -Merge-Request-58 Merge-Review-58 Hotlist-Merge-Review
This bug requires manual review: There is .grd file changes and we are only 49 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), bhthompson@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
shuchen@ I verified the fix in 9334.0.0 / 58.0.3028.0

Attached screenshot from peppy.
Screenshot 2017-03-06 at 10.34.24 AM.png
302 KB View Download
@stevenjb I would expect this to be indented and have a non-fullbleed divider similarly to "Manage input methods". It currently looks like it's on an equal level to "Input method", not a child of it.

@bettes please correct me if I'm wrong!
tbuckley@ - I made this consistent with other UI, e.g. "Offer to translate pages" under 'Language'.

I think the indentation will be best addressed when we later un-inline Language and Input, e.e.  issue 673943 .

The important thing for now is that this setting is available in M58.

Labels: -M-58 M-59
Labels: -Hotlist-Merge-Review -Merge-Review-58
Status: Fixed (was: Assigned)
Removing merge request since we are not shipping in 58 on any platform.

Blocking: -642385
Status: Verified (was: Fixed)
9404.0.0 / 59.0.3051.3
Cc: fukino@chromium.org
 Issue 670378  has been merged into this issue.

Sign in to add a comment