Cannot find opt-in IME menu entry in settings page |
||||||||||||||
Issue descriptionChrome Version: 58.0.3019 OS: Chrome OS What steps will reproduce the problem? (1) open settings page (2) In "Languages and input" section, cannot find checkbox "Show input options on the shelf" to enable/disable opt-in IME menu. "Show input options on the shelf" is the only entry for opt-in IME menu. Without it, users cannot enable/disable the new menu.
,
Feb 23 2017
@stevenjb can you add this since it's CrOS-only?
,
Mar 1 2017
,
Mar 1 2017
+bettes@ I am going to implement this as a toggle in the current inlined expanded section under 'Input method'. We should add it to the un-inlined mocks at some point.
,
Mar 1 2017
,
Mar 1 2017
,
Mar 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c0e297639ffe51b7a3fc75fe96f9a1fb832a0ea1 commit c0e297639ffe51b7a3fc75fe96f9a1fb832a0ea1 Author: stevenjb <stevenjb@chromium.org> Date: Thu Mar 02 00:44:34 2017 MD Settings: Input method: add show-in-shelf toggle BUG= 694928 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2727693003 Cr-Commit-Position: refs/heads/master@{#454126} [modify] https://crrev.com/c0e297639ffe51b7a3fc75fe96f9a1fb832a0ea1/chrome/app/settings_strings.grdp [modify] https://crrev.com/c0e297639ffe51b7a3fc75fe96f9a1fb832a0ea1/chrome/browser/extensions/api/settings_private/prefs_util.cc [modify] https://crrev.com/c0e297639ffe51b7a3fc75fe96f9a1fb832a0ea1/chrome/browser/resources/settings/languages_page/languages_page.html [modify] https://crrev.com/c0e297639ffe51b7a3fc75fe96f9a1fb832a0ea1/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
,
Mar 2 2017
,
Mar 2 2017
Fix not in TOT build 9331.0.0 / 58.0.3027.0
,
Mar 3 2017
Verified on ChromeOS 9334.0.0 / 58.0.3028.0
,
Mar 4 2017
Steven, looks like this issue is not fixed in M58. Can you please cherrypick the fix cl to M58? Thanks.
,
Mar 6 2017
,
Mar 6 2017
This bug requires manual review: There is .grd file changes and we are only 49 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), bhthompson@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 6 2017
shuchen@ I verified the fix in 9334.0.0 / 58.0.3028.0 Attached screenshot from peppy.
,
Mar 7 2017
@stevenjb I would expect this to be indented and have a non-fullbleed divider similarly to "Manage input methods". It currently looks like it's on an equal level to "Input method", not a child of it. @bettes please correct me if I'm wrong!
,
Mar 7 2017
tbuckley@ - I made this consistent with other UI, e.g. "Offer to translate pages" under 'Language'. I think the indentation will be best addressed when we later un-inline Language and Input, e.e. issue 673943 . The important thing for now is that this setting is available in M58.
,
Mar 7 2017
,
Mar 7 2017
Removing merge request since we are not shipping in 58 on any platform.
,
Mar 8 2017
,
Mar 27 2017
9404.0.0 / 59.0.3051.3
,
Apr 12 2017
|
||||||||||||||
►
Sign in to add a comment |
||||||||||||||
Comment 1 by dpa...@chromium.org
, Feb 22 2017Owner: ----