The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/d9d2e2d589514bc39bbb9b3b8dacf0569ab5a183

commit d9d2e2d589514bc39bbb9b3b8dacf0569ab5a183
Author: Dan Jacques <dnj@chromium.org>
Date: Wed Feb 22 16:26:38 2017

kitchen: Allow command-line LogDog tags.

Allow Kitchen to accept LogDog global stream tags from command-line
(-logdog-tag).

BUG= chromium:694911 
TEST=None

Change-Id: I10f77ddb8bfce8416e050eed3adab9bb8c73fdd0
Reviewed-on: https://chromium-review.googlesource.com/445806
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Daniel Jacques <dnj@chromium.org>

[modify] https://crrev.com/d9d2e2d589514bc39bbb9b3b8dacf0569ab5a183/go/src/infra/tools/kitchen/cook_logdog.go

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/90b4ce89177c32a9e383df7303da9438a8fe770e

commit 90b4ce89177c32a9e383df7303da9438a8fe770e
Author: Dan Jacques <dnj@chromium.org>
Date: Wed Feb 22 16:36:38 2017

Kitchen: Don't log error on zero return code.

Return code values can be represented by an error type. However, because
it's a non-nil error, Kitchen will log this with Error-level logging
even if it succeeds. Make it so that a zero-value return code error will
no longer produce an error-level log.

Also fix some linting errors.

BUG= chromium:694911 
TEST=None

Change-Id: I3f356ae26fa3a73c54581b247f25a6fd0ca69b0e
Reviewed-on: https://chromium-review.googlesource.com/446074
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Daniel Jacques <dnj@chromium.org>

[modify] https://crrev.com/90b4ce89177c32a9e383df7303da9438a8fe770e/go/src/infra/tools/kitchen/cook.go
[modify] https://crrev.com/90b4ce89177c32a9e383df7303da9438a8fe770e/go/src/infra/tools/kitchen/cook_mode.go

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/534bf09e1f754153e4a044ecb3c41ae4d8f758bd

commit 534bf09e1f754153e4a044ecb3c41ae4d8f758bd
Author: Dan Jacques <dnj@chromium.org>
Date: Wed Feb 22 16:54:57 2017

Add BuildBot mode to Kitchen.

Add a BuildBot build mode to Kitchen.

BUG= chromium:694911 
TEST=None

Change-Id: I525c640dae24d521a5e67434b5c68c70ca6bc2e8
Reviewed-on: https://chromium-review.googlesource.com/446005
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Daniel Jacques <dnj@chromium.org>

[modify] https://crrev.com/534bf09e1f754153e4a044ecb3c41ae4d8f758bd/go/src/infra/tools/kitchen/cook_mode.go

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-go.git/+/715bd11e4c5717e9b5fa7da0c547638bbd9a3f87

commit 715bd11e4c5717e9b5fa7da0c547638bbd9a3f87
Author: dnj <dnj@chromium.org>
Date: Wed Feb 22 17:52:58 2017

Butler: Infer host from "coordinator-host" flag.

Currently, the LogDog Coordinator host can be explicitly specified as a
top-level flag. This is redundant with the host, which is also specified
in the LogDog "output" module.

The reason for this is that some configurations may wish to direct the
Butler to a services module within the host (e.g., service-dot-example.com).
However, the host must still be available for viewer link generation.

Rather than specify it multiple times, we will use only the top-level
host flag. The production output, "logdog", can take an additional optional
service name which, if provided, can be used to construct the
"service-dot-host" host for service engagement.

BUG= chromium:694911 
TEST=None

Review-Url: https://codereview.chromium.org/2715443002

[modify] https://crrev.com/715bd11e4c5717e9b5fa7da0c547638bbd9a3f87/logdog/client/cmd/logdog_butler/main.go
[modify] https://crrev.com/715bd11e4c5717e9b5fa7da0c547638bbd9a3f87/logdog/client/cmd/logdog_butler/output_logdog.go

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-go.git/+/63725204857b1212bc56d1b088980df1bc903026

commit 63725204857b1212bc56d1b088980df1bc903026
Author: dnj <dnj@chromium.org>
Date: Wed Feb 22 18:02:14 2017

Annotee: Automatically infer host from bootstrap.

If a Butler bootstrap is provided, have Annotee automatically infer the
LogDog Coordinator host from the bootstrap.

When Annotee was originally written, the bootstrap didn't contain this
information.

BUG= chromium:694911 
TEST=None

Review-Url: https://codereview.chromium.org/2714443002

[modify] https://crrev.com/63725204857b1212bc56d1b088980df1bc903026/logdog/client/cmd/logdog_annotee/main.go

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/c25fbd7d4ef7d421a67f791b19ca041a96ef2541

commit c25fbd7d4ef7d421a67f791b19ca041a96ef2541
Author: Dan Jacques <dnj@chromium.org>
Date: Wed Feb 22 22:07:10 2017

Kitchen: Always forward annotations buildbot mode.

Always forward annotations when running in BuildBot mode, even if
"-logdog-only" is specified. BuildBot needs to see the annotations in
order to build a structural representation of the build.

BUG= chromium:694911 
TEST=None

Change-Id: I6bcb41e3dd7d62b6e1c932709dca9c572e149cd1
Reviewed-on: https://chromium-review.googlesource.com/445971
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Daniel Jacques <dnj@chromium.org>

[modify] https://crrev.com/c25fbd7d4ef7d421a67f791b19ca041a96ef2541/go/src/infra/tools/kitchen/cook_mode.go
[modify] https://crrev.com/c25fbd7d4ef7d421a67f791b19ca041a96ef2541/go/src/infra/tools/kitchen/cook_logdog.go

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/a4d4ed78d06b008dac50ae7a21d8bbf69ff58257

commit a4d4ed78d06b008dac50ae7a21d8bbf69ff58257
Author: Dan Jacques <dnj@chromium.org>
Date: Thu Feb 23 00:12:04 2017

Roll luci-go.

infra/go/src/github.com/luci/luci-go:
16447d1a lucictx: Stop removing LUCI_CONTEXT from environ during init()
time.
63725204 Annotee: Automatically infer host from bootstrap.
715bd11e Butler: Infer host from "coordinator-host" flag.
7e123ef9 vpython: Add Python interpreter handling package.
fa008f62 vpython: Add environment spec package.
d225f829 vpython: Add wheel parsing/management package.
091cb159 vpython: Add filesystem operation / test packages.
49cc23e4 vpython: Add README and environment protobuf.
6cff766c auth: Stop "sniffing" for GCE metadata server.
4b1052ce Update Kubernetes launcher scripts for new auth.
5eb82944 Fix builder view - Render step text correctly
62204651 Milo: Show buildbucket builds on Milo front page
619d2aeb milo: fix a typo
97bf7220 auth: Treat OptionalLogin as SilentLogin when using service
account keys.
dbcf8a98 auth: Slightly change semantics of InteractiveLogin to make
more sense.
837aff73 auth: Implement LUCIContextMethod authentication method.
53bba444 auth: Move GetOAuthToken request/response structs to separate
package.

BUG= chromium:694911 
TEST=None

Change-Id: I8776134bc1febab624a9c88b6d800bcd5d0747d6
Reviewed-on: https://chromium-review.googlesource.com/446092
Commit-Queue: Daniel Jacques <dnj@chromium.org>
Reviewed-by: Daniel Jacques <dnj@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/a4d4ed78d06b008dac50ae7a21d8bbf69ff58257/DEPS
[modify] https://crrev.com/a4d4ed78d06b008dac50ae7a21d8bbf69ff58257/go/src/infra/monitoring/proxy/main.go

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/b7455cc632b2a3c60148525d0a2ef902ce2e4ede

commit b7455cc632b2a3c60148525d0a2ef902ce2e4ede
Author: Dan Jacques <dnj@chromium.org>
Date: Fri Feb 24 02:24:20 2017

logdog_bootstrap: Update for v4 API, Config.

Update the "logdog_bootstrap" to support v4 Butler/Annotee API. This
change updates the "ts-mon" credential value on GCE, introduces the
"module" LogDog output parameter, and makes several explicit Annotee
parameters implicit via Butler environment.

We also pull out the bootstrap's Config, and expose several bootstrap
functions publicly. This is the solidified set of parameters obtained by
probing the runtime environment. We do this in anticipation of "remote_run"
needing to use these parameters directly when executing Kitchen.

Finally, the LogDog annotation stream URL is now exported directly as a
BuildBot property.

BUG= chromium:694911 
TEST=unit

Change-Id: I81a5c7c9f49b76fbc3e433fd7399c74baf12f09d
Reviewed-on: https://chromium-review.googlesource.com/446008
Commit-Queue: Daniel Jacques <dnj@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

[modify] https://crrev.com/b7455cc632b2a3c60148525d0a2ef902ce2e4ede/scripts/slave/logdog_bootstrap.py
[modify] https://crrev.com/b7455cc632b2a3c60148525d0a2ef902ce2e4ede/scripts/slave/unittests/annotated_run_test.py
[modify] https://crrev.com/b7455cc632b2a3c60148525d0a2ef902ce2e4ede/scripts/slave/unittests/logdog_bootstrap_test.py
[modify] https://crrev.com/b7455cc632b2a3c60148525d0a2ef902ce2e4ede/scripts/slave/cipd.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/53ceb343d9a837516153036eae687ffea2fdc27a

commit 53ceb343d9a837516153036eae687ffea2fdc27a
Author: Dan Jacques <dnj@chromium.org>
Date: Fri Feb 24 15:42:21 2017

LogDog: Roll canary version to prod.

BUG= chromium:694911 
TEST=canary
  - Ran canary overnight, no observed problems.

Change-Id: I2fa120feef730988f258db4c27fde302518d8987
Reviewed-on: https://chromium-review.googlesource.com/446051
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Daniel Jacques <dnj@chromium.org>

[modify] https://crrev.com/53ceb343d9a837516153036eae687ffea2fdc27a/scripts/slave/logdog_bootstrap.py
[modify] https://crrev.com/53ceb343d9a837516153036eae687ffea2fdc27a/scripts/slave/unittests/logdog_bootstrap_test.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/c1c3c3fd3e145fd62c67110132590a34030b8fe2

commit c1c3c3fd3e145fd62c67110132590a34030b8fe2
Author: Dan Jacques <dnj@chromium.org>
Date: Sun Feb 26 18:45:04 2017

Seed remote_run unit test recipe.

This recipe will be called by "remote_run" unit tests to assert
correctness.

This is a clone of "annotated_run_test" recipe. Separate so we
can augment / modify it independently if needed.

TBR=iannucci@chromium.org
BUG= chromium:694911 
TEST=None

Change-Id: Iba9e7ea86b3417142f7c283791fff322381e6d2b
Reviewed-on: https://chromium-review.googlesource.com/446968
Reviewed-by: Daniel Jacques <dnj@chromium.org>
Commit-Queue: Daniel Jacques <dnj@chromium.org>

[add] https://crrev.com/c1c3c3fd3e145fd62c67110132590a34030b8fe2/scripts/slave/recipes/remote_run_test.py
[add] https://crrev.com/c1c3c3fd3e145fd62c67110132590a34030b8fe2/scripts/slave/recipes/remote_run_test.expected/type_error.json
[add] https://crrev.com/c1c3c3fd3e145fd62c67110132590a34030b8fe2/scripts/slave/recipes/remote_run_test.expected/basic.json

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/2c5b6c1efd6c9cc8fc455738e3b43f6e2631ac48

commit 2c5b6c1efd6c9cc8fc455738e3b43f6e2631ac48
Author: Dan Jacques <dnj@chromium.org>
Date: Mon Feb 27 18:48:59 2017

Add remote_run test, canarying, pin recipes

Add canarying to "remote_run". Pin the "recipes-py" package
version so that arbitrary updates don't lose the basic ability to launch
recipes.

Additionally, add a much-needed suite of "remote_run" tests that,
similar to "annotated_run", assert the correctness of basic execution
and expected command-line flags.

Some refactoring was needed to accommodate the unit test approach and
canarying. Some additional refactoring is probably present due to the
fact that this was backported from its successor patch, which introduces
Kitchen. The expected output behavior of this patch is that "remote_run"
behavior remains unchanged, except for the pins.

BUG= chromium:694911 
TEST=local

Change-Id: I7197aa4cbe0b3578933b6f53371e9d85535fabe7
Reviewed-on: https://chromium-review.googlesource.com/446904
Commit-Queue: Daniel Jacques <dnj@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Dave Sansome <dsansome@chromium.org>

[modify] https://crrev.com/2c5b6c1efd6c9cc8fc455738e3b43f6e2631ac48/scripts/slave/remote_run.py
[add] https://crrev.com/2c5b6c1efd6c9cc8fc455738e3b43f6e2631ac48/scripts/slave/unittests/remote_run_test.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/2c5b6c1efd6c9cc8fc455738e3b43f6e2631ac48

commit 2c5b6c1efd6c9cc8fc455738e3b43f6e2631ac48
Author: Dan Jacques <dnj@chromium.org>
Date: Mon Feb 27 18:48:59 2017

Add remote_run test, canarying, pin recipes

Add canarying to "remote_run". Pin the "recipes-py" package
version so that arbitrary updates don't lose the basic ability to launch
recipes.

Additionally, add a much-needed suite of "remote_run" tests that,
similar to "annotated_run", assert the correctness of basic execution
and expected command-line flags.

Some refactoring was needed to accommodate the unit test approach and
canarying. Some additional refactoring is probably present due to the
fact that this was backported from its successor patch, which introduces
Kitchen. The expected output behavior of this patch is that "remote_run"
behavior remains unchanged, except for the pins.

BUG= chromium:694911 
TEST=local

Change-Id: I7197aa4cbe0b3578933b6f53371e9d85535fabe7
Reviewed-on: https://chromium-review.googlesource.com/446904
Commit-Queue: Daniel Jacques <dnj@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Dave Sansome <dsansome@chromium.org>

[modify] https://crrev.com/2c5b6c1efd6c9cc8fc455738e3b43f6e2631ac48/scripts/slave/remote_run.py
[add] https://crrev.com/2c5b6c1efd6c9cc8fc455738e3b43f6e2631ac48/scripts/slave/unittests/remote_run_test.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/2c5b6c1efd6c9cc8fc455738e3b43f6e2631ac48

commit 2c5b6c1efd6c9cc8fc455738e3b43f6e2631ac48
Author: Dan Jacques <dnj@chromium.org>
Date: Mon Feb 27 18:48:59 2017

Add remote_run test, canarying, pin recipes

Add canarying to "remote_run". Pin the "recipes-py" package
version so that arbitrary updates don't lose the basic ability to launch
recipes.

Additionally, add a much-needed suite of "remote_run" tests that,
similar to "annotated_run", assert the correctness of basic execution
and expected command-line flags.

Some refactoring was needed to accommodate the unit test approach and
canarying. Some additional refactoring is probably present due to the
fact that this was backported from its successor patch, which introduces
Kitchen. The expected output behavior of this patch is that "remote_run"
behavior remains unchanged, except for the pins.

BUG= chromium:694911 
TEST=local

Change-Id: I7197aa4cbe0b3578933b6f53371e9d85535fabe7
Reviewed-on: https://chromium-review.googlesource.com/446904
Commit-Queue: Daniel Jacques <dnj@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Dave Sansome <dsansome@chromium.org>

[modify] https://crrev.com/2c5b6c1efd6c9cc8fc455738e3b43f6e2631ac48/scripts/slave/remote_run.py
[add] https://crrev.com/2c5b6c1efd6c9cc8fc455738e3b43f6e2631ac48/scripts/slave/unittests/remote_run_test.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/2c5b6c1efd6c9cc8fc455738e3b43f6e2631ac48

commit 2c5b6c1efd6c9cc8fc455738e3b43f6e2631ac48
Author: Dan Jacques <dnj@chromium.org>
Date: Mon Feb 27 18:48:59 2017

Add remote_run test, canarying, pin recipes

Add canarying to "remote_run". Pin the "recipes-py" package
version so that arbitrary updates don't lose the basic ability to launch
recipes.

Additionally, add a much-needed suite of "remote_run" tests that,
similar to "annotated_run", assert the correctness of basic execution
and expected command-line flags.

Some refactoring was needed to accommodate the unit test approach and
canarying. Some additional refactoring is probably present due to the
fact that this was backported from its successor patch, which introduces
Kitchen. The expected output behavior of this patch is that "remote_run"
behavior remains unchanged, except for the pins.

BUG= chromium:694911 
TEST=local

Change-Id: I7197aa4cbe0b3578933b6f53371e9d85535fabe7
Reviewed-on: https://chromium-review.googlesource.com/446904
Commit-Queue: Daniel Jacques <dnj@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Dave Sansome <dsansome@chromium.org>

[modify] https://crrev.com/2c5b6c1efd6c9cc8fc455738e3b43f6e2631ac48/scripts/slave/remote_run.py
[add] https://crrev.com/2c5b6c1efd6c9cc8fc455738e3b43f6e2631ac48/scripts/slave/unittests/remote_run_test.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/2c5b6c1efd6c9cc8fc455738e3b43f6e2631ac48

commit 2c5b6c1efd6c9cc8fc455738e3b43f6e2631ac48
Author: Dan Jacques <dnj@chromium.org>
Date: Mon Feb 27 18:48:59 2017

Add remote_run test, canarying, pin recipes

Add canarying to "remote_run". Pin the "recipes-py" package
version so that arbitrary updates don't lose the basic ability to launch
recipes.

Additionally, add a much-needed suite of "remote_run" tests that,
similar to "annotated_run", assert the correctness of basic execution
and expected command-line flags.

Some refactoring was needed to accommodate the unit test approach and
canarying. Some additional refactoring is probably present due to the
fact that this was backported from its successor patch, which introduces
Kitchen. The expected output behavior of this patch is that "remote_run"
behavior remains unchanged, except for the pins.

BUG= chromium:694911 
TEST=local

Change-Id: I7197aa4cbe0b3578933b6f53371e9d85535fabe7
Reviewed-on: https://chromium-review.googlesource.com/446904
Commit-Queue: Daniel Jacques <dnj@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Dave Sansome <dsansome@chromium.org>

[modify] https://crrev.com/2c5b6c1efd6c9cc8fc455738e3b43f6e2631ac48/scripts/slave/remote_run.py
[add] https://crrev.com/2c5b6c1efd6c9cc8fc455738e3b43f6e2631ac48/scripts/slave/unittests/remote_run_test.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/4272dc5988ba3dc516a356564d1e37e2b0b7de19

commit 4272dc5988ba3dc516a356564d1e37e2b0b7de19
Author: Dan Jacques <dnj@chromium.org>
Date: Mon Feb 27 22:17:11 2017

Add Kitchen remote_run bootstrap canary.

Update "remote_run" to introduce a Kitchen canary feature which can be
enabled per-waterfall to use Kitchen to bootstrap recipes instead of
explicitly bootstrapping in "remote_run". This normalizes the LUCI and
non-LUCI approaches to recipe engine remote invocation and removes a
significant part of "remote_run"'s code.

BUG= chromium:694911 
TEST=local

Change-Id: I0c3ccc8633a99dfa2408a7fbb300956299d78be1
Reviewed-on: https://chromium-review.googlesource.com/446053
Commit-Queue: Daniel Jacques <dnj@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/4272dc5988ba3dc516a356564d1e37e2b0b7de19/scripts/slave/remote_run.py
[modify] https://crrev.com/4272dc5988ba3dc516a356564d1e37e2b0b7de19/scripts/slave/unittests/remote_run_test.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/f0ece6f3e0e2a009b1ec2fb8cd81f8940adfeb68

commit f0ece6f3e0e2a009b1ec2fb8cd81f8940adfeb68
Author: Daniel Jacques <dnj@chromium.org>
Date: Mon Feb 27 22:24:23 2017

Revert "Add Kitchen remote_run bootstrap canary."

This reverts commit 4272dc5988ba3dc516a356564d1e37e2b0b7de19.

Reason for revert: Broken builds have been observed.

Original change's description:
> Add Kitchen remote_run bootstrap canary.
> 
> Update "remote_run" to introduce a Kitchen canary feature which can be
> enabled per-waterfall to use Kitchen to bootstrap recipes instead of
> explicitly bootstrapping in "remote_run". This normalizes the LUCI and
> non-LUCI approaches to recipe engine remote invocation and removes a
> significant part of "remote_run"'s code.
> 
> BUG= chromium:694911 
> TEST=local
> 
> Change-Id: I0c3ccc8633a99dfa2408a7fbb300956299d78be1
> Reviewed-on: https://chromium-review.googlesource.com/446053
> Commit-Queue: Daniel Jacques <dnj@chromium.org>
> Reviewed-by: Nodir Turakulov <nodir@chromium.org>
> 

TBR=iannucci@chromium.org,dnj@chromium.org,nodir@chromium.org,csheppard077@gmail.com,chromium-reviews@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= chromium:694911 

Change-Id: I3bad57052d9f9cb72cd94815145f1639e6089cc6
Reviewed-on: https://chromium-review.googlesource.com/447158
Reviewed-by: Daniel Jacques <dnj@chromium.org>
Commit-Queue: Daniel Jacques <dnj@chromium.org>

[modify] https://crrev.com/f0ece6f3e0e2a009b1ec2fb8cd81f8940adfeb68/scripts/slave/remote_run.py
[modify] https://crrev.com/f0ece6f3e0e2a009b1ec2fb8cd81f8940adfeb68/scripts/slave/unittests/remote_run_test.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/987a94d76b0fea85afe2a07a0587e65e087f404d

commit 987a94d76b0fea85afe2a07a0587e65e087f404d
Author: Dan Jacques <dnj@chromium.org>
Date: Mon Feb 27 23:38:02 2017

Add Kitchen remote_run bootstrap canary.

Update "remote_run" to introduce a Kitchen canary feature which can be
enabled per-waterfall to use Kitchen to bootstrap recipes instead of
explicitly bootstrapping in "remote_run". This normalizes the LUCI and
non-LUCI approaches to recipe engine remote invocation and removes a
significant part of "remote_run"'s code.

BUG= chromium:694911 
TEST=local

Change-Id: Iade8f345d5cc01e1a34d152122adf1f049a4ced7
Reviewed-on: https://chromium-review.googlesource.com/447159
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Daniel Jacques <dnj@chromium.org>

[modify] https://crrev.com/987a94d76b0fea85afe2a07a0587e65e087f404d/scripts/slave/remote_run.py
[modify] https://crrev.com/987a94d76b0fea85afe2a07a0587e65e087f404d/scripts/slave/unittests/remote_run_test.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/760969c54431634d89926794abe5d58e4bd836a4

commit 760969c54431634d89926794abe5d58e4bd836a4
Author: Daniel Jacques <dnj@chromium.org>
Date: Mon Feb 27 23:49:44 2017

Revert "Add Kitchen remote_run bootstrap canary."

This reverts commit 987a94d76b0fea85afe2a07a0587e65e087f404d.

Reason for revert: Unrecognized annotator command "CURRENT_TIMESTAMP"

Original change's description:
> Add Kitchen remote_run bootstrap canary.
> 
> Update "remote_run" to introduce a Kitchen canary feature which can be
> enabled per-waterfall to use Kitchen to bootstrap recipes instead of
> explicitly bootstrapping in "remote_run". This normalizes the LUCI and
> non-LUCI approaches to recipe engine remote invocation and removes a
> significant part of "remote_run"'s code.
> 
> BUG= chromium:694911 
> TEST=local
> 
> Change-Id: Iade8f345d5cc01e1a34d152122adf1f049a4ced7
> Reviewed-on: https://chromium-review.googlesource.com/447159
> Reviewed-by: Nodir Turakulov <nodir@chromium.org>
> Commit-Queue: Daniel Jacques <dnj@chromium.org>
> 

TBR=dnj@chromium.org,nodir@chromium.org,chromium-reviews@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= chromium:694911 

Change-Id: I3b4fa9749acced5ad6035e2b3026aa50d64bcc2a
Reviewed-on: https://chromium-review.googlesource.com/447160
Reviewed-by: Daniel Jacques <dnj@chromium.org>
Commit-Queue: Daniel Jacques <dnj@chromium.org>

[modify] https://crrev.com/760969c54431634d89926794abe5d58e4bd836a4/scripts/slave/remote_run.py
[modify] https://crrev.com/760969c54431634d89926794abe5d58e4bd836a4/scripts/slave/unittests/remote_run_test.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/4e6b1dfc80ce08a7b90099bf0d5307774f02f0b0

commit 4e6b1dfc80ce08a7b90099bf0d5307774f02f0b0
Author: Dan Jacques <dnj@chromium.org>
Date: Mon Feb 27 23:57:42 2017

Add Kitchen remote_run bootstrap canary.

Update "remote_run" to introduce a Kitchen canary feature which can be
enabled per-waterfall to use Kitchen to bootstrap recipes instead of
explicitly bootstrapping in "remote_run". This normalizes the LUCI and
non-LUCI approaches to recipe engine remote invocation and removes a
significant part of "remote_run"'s code.

BUG= chromium:694911 
TEST=local

Change-Id: I01af1f8788cdcd38e744b94b4b7ccdfbe47094f5
Reviewed-on: https://chromium-review.googlesource.com/447220
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Daniel Jacques <dnj@chromium.org>

[modify] https://crrev.com/4e6b1dfc80ce08a7b90099bf0d5307774f02f0b0/scripts/slave/remote_run.py
[modify] https://crrev.com/4e6b1dfc80ce08a7b90099bf0d5307774f02f0b0/scripts/slave/unittests/remote_run_test.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/a95e06412dc3c84ba69e600f40e9d716be3ba98a

commit a95e06412dc3c84ba69e600f40e9d716be3ba98a
Author: Daniel Jacques <dnj@chromium.org>
Date: Tue Feb 28 00:02:29 2017

Revert "Add Kitchen remote_run bootstrap canary."

This reverts commit 4e6b1dfc80ce08a7b90099bf0d5307774f02f0b0.

Reason for revert: Not emitting LogDog [links]

Original change's description:
> Add Kitchen remote_run bootstrap canary.
> 
> Update "remote_run" to introduce a Kitchen canary feature which can be
> enabled per-waterfall to use Kitchen to bootstrap recipes instead of
> explicitly bootstrapping in "remote_run". This normalizes the LUCI and
> non-LUCI approaches to recipe engine remote invocation and removes a
> significant part of "remote_run"'s code.
> 
> BUG= chromium:694911 
> TEST=local
> 
> Change-Id: I01af1f8788cdcd38e744b94b4b7ccdfbe47094f5
> Reviewed-on: https://chromium-review.googlesource.com/447220
> Reviewed-by: Nodir Turakulov <nodir@chromium.org>
> Commit-Queue: Daniel Jacques <dnj@chromium.org>
> 

TBR=dnj@chromium.org,nodir@chromium.org,chromium-reviews@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= chromium:694911 

Change-Id: Iddf1ebbb04ada41135c51c8ea59460b4b390fcd4
Reviewed-on: https://chromium-review.googlesource.com/447161
Reviewed-by: Daniel Jacques <dnj@chromium.org>
Commit-Queue: Daniel Jacques <dnj@chromium.org>

[modify] https://crrev.com/a95e06412dc3c84ba69e600f40e9d716be3ba98a/scripts/slave/remote_run.py
[modify] https://crrev.com/a95e06412dc3c84ba69e600f40e9d716be3ba98a/scripts/slave/unittests/remote_run_test.py

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-go.git/+/50c849215ac7d0bea13833b1524272dac733d890

commit 50c849215ac7d0bea13833b1524272dac733d890
Author: dnj <dnj@chromium.org>
Date: Tue Feb 28 00:30:46 2017

Annotee: Export Coordinator link generator.

Export the Coordinator link generator type. It will be used by Kitchen's
embeded Annotee processor to generate links.

Update it to take advantage of the new (to it) "viewer" package for
homogenous link generation.

BUG= chromium:694911 
TEST=None
R=nodir@chromium.org

Review-Url: https://codereview.chromium.org/2719183003

[add] https://crrev.com/50c849215ac7d0bea13833b1524272dac733d890/logdog/client/annotee/link_generator.go
[modify] https://crrev.com/50c849215ac7d0bea13833b1524272dac733d890/logdog/client/annotee/processor.go
[delete] https://crrev.com/1d3e94e637924f48ced8460bc63cefb6bc6bba52/logdog/client/cmd/logdog_annotee/link.go
[modify] https://crrev.com/50c849215ac7d0bea13833b1524272dac733d890/logdog/client/cmd/logdog_annotee/main.go

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-go.git/+/50c849215ac7d0bea13833b1524272dac733d890

commit 50c849215ac7d0bea13833b1524272dac733d890
Author: dnj <dnj@chromium.org>
Date: Tue Feb 28 00:30:46 2017

Annotee: Export Coordinator link generator.

Export the Coordinator link generator type. It will be used by Kitchen's
embeded Annotee processor to generate links.

Update it to take advantage of the new (to it) "viewer" package for
homogenous link generation.

BUG= chromium:694911 
TEST=None
R=nodir@chromium.org

Review-Url: https://codereview.chromium.org/2719183003

[add] https://crrev.com/50c849215ac7d0bea13833b1524272dac733d890/logdog/client/annotee/link_generator.go
[modify] https://crrev.com/50c849215ac7d0bea13833b1524272dac733d890/logdog/client/annotee/processor.go
[delete] https://crrev.com/1d3e94e637924f48ced8460bc63cefb6bc6bba52/logdog/client/cmd/logdog_annotee/link.go
[modify] https://crrev.com/50c849215ac7d0bea13833b1524272dac733d890/logdog/client/cmd/logdog_annotee/main.go

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/c5820b106f1b764fa497acc05d45abf7013e93a9

commit c5820b106f1b764fa497acc05d45abf7013e93a9
Author: Dan Jacques <dnj@chromium.org>
Date: Tue Feb 28 00:45:37 2017

Roll luci-go.

infra/go/src/github.com/luci/luci-go:
50c84921 Annotee: Export Coordinator link generator.
1d3e94e6 Milo: Prefer annotation URL for buildinfo
9878dc39 Add profiling to all apps that use 'common/cli'.
e0e2fedf Milo: Add logging to buildbot grpc request
e2ca1efd Update / fix LogDog clusters, add deploy command.
f32ea2f3 Milo: Allow -dev in the pubsub subscription name
388ea205 Move GCS handling for isolate fetch into argument.
887de917 Milo: Handle missing / transient LogDog failures.
611ffa1c Update milo indicies

TBR=nodir@chromium.org
BUG= chromium:694911 
TEST=None

Change-Id: Id7d22c9ce315ebb23c4e26d5b9ef8e4c8c8f4295
Reviewed-on: https://chromium-review.googlesource.com/447457
Reviewed-by: Daniel Jacques <dnj@chromium.org>
Commit-Queue: Daniel Jacques <dnj@chromium.org>

[modify] https://crrev.com/c5820b106f1b764fa497acc05d45abf7013e93a9/DEPS

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/aeec96d655567a95852fbad31099fe0e47e66ea6

commit aeec96d655567a95852fbad31099fe0e47e66ea6
Author: Dan Jacques <dnj@chromium.org>
Date: Tue Feb 28 01:43:39 2017

Kitchen: Deprecate "timestamps" flag.

"timestamps" is a function of the mode - on Swarming, we want them so
Milo can judge time. On BuildBot, we do not want them ever (and, in
fact, masters will reject them).

BUG= chromium:694911 
TEST=None

Change-Id: I47cb50575aabe236d2c17f5c959e62ae4cc106ae
Reviewed-on: https://chromium-review.googlesource.com/447238
Commit-Queue: Ryan Tseng <hinoka@chromium.org>
Reviewed-by: Ryan Tseng <hinoka@chromium.org>

[modify] https://crrev.com/aeec96d655567a95852fbad31099fe0e47e66ea6/go/src/infra/tools/kitchen/cook.go
[modify] https://crrev.com/aeec96d655567a95852fbad31099fe0e47e66ea6/go/src/infra/tools/kitchen/cook_mode.go

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/592a14043f73c8f8079d5258b09e285465855a6d

commit 592a14043f73c8f8079d5258b09e285465855a6d
Author: Dan Jacques <dnj@chromium.org>
Date: Tue Feb 28 01:48:17 2017

Kitchen: enable LogDog link generation, tee.

Generate LogDog link annotations when in "buildbot" mode. Fix
annotation-only teeing by providing a tee outlet to Annotee when
configured to do so.

BUG= chromium:694911 
TEST=local

Change-Id: I7b66c828ab6c4b9c296b43cc1ee1dc1e7d94d037
Reviewed-on: https://chromium-review.googlesource.com/447222
Commit-Queue: Ryan Tseng <hinoka@chromium.org>
Reviewed-by: Ryan Tseng <hinoka@chromium.org>

[modify] https://crrev.com/592a14043f73c8f8079d5258b09e285465855a6d/go/src/infra/tools/kitchen/cook_mode.go
[modify] https://crrev.com/592a14043f73c8f8079d5258b09e285465855a6d/go/src/infra/tools/kitchen/cook_logdog.go

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/d5e32c7f780050dccd2ae7bc42349d77a5b19f52

commit d5e32c7f780050dccd2ae7bc42349d77a5b19f52
Author: Dan Jacques <dnj@chromium.org>
Date: Tue Feb 28 19:11:25 2017

Add Kitchen remote_run bootstrap canary (#4).

Update "remote_run" to introduce a Kitchen canary feature which can be
enabled per-waterfall to use Kitchen to bootstrap recipes instead of
explicitly bootstrapping in "remote_run". This normalizes the LUCI and
non-LUCI approaches to recipe engine remote invocation and removes a
significant part of "remote_run"'s code.

BUG= chromium:694911 
TEST=local

Change-Id: Ibb56954ee6fe7de46de4ff90873a4f833eda1a6f
Reviewed-on: https://chromium-review.googlesource.com/447300
Commit-Queue: Daniel Jacques <dnj@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/d5e32c7f780050dccd2ae7bc42349d77a5b19f52/scripts/slave/logdog_bootstrap.py
[modify] https://crrev.com/d5e32c7f780050dccd2ae7bc42349d77a5b19f52/scripts/slave/remote_run.py
[modify] https://crrev.com/d5e32c7f780050dccd2ae7bc42349d77a5b19f52/scripts/slave/unittests/remote_run_test.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/91310531c31fa645256b4fb5d44b460c42b3e151

commit 91310531c31fa645256b4fb5d44b460c42b3e151
Author: Daniel Jacques <dnj@chromium.org>
Date: Tue Feb 28 19:38:17 2017

Revert "Add Kitchen remote_run bootstrap canary (#4)."

This reverts commit d5e32c7f780050dccd2ae7bc42349d77a5b19f52.

Reason for revert: Recipe engine assumes tools/build in PYTHNONPATH :/

Original change's description:
> Add Kitchen remote_run bootstrap canary (#4).
> 
> Update "remote_run" to introduce a Kitchen canary feature which can be
> enabled per-waterfall to use Kitchen to bootstrap recipes instead of
> explicitly bootstrapping in "remote_run". This normalizes the LUCI and
> non-LUCI approaches to recipe engine remote invocation and removes a
> significant part of "remote_run"'s code.
> 
> BUG= chromium:694911 
> TEST=local
> 
> Change-Id: Ibb56954ee6fe7de46de4ff90873a4f833eda1a6f
> Reviewed-on: https://chromium-review.googlesource.com/447300
> Commit-Queue: Daniel Jacques <dnj@chromium.org>
> Reviewed-by: Nodir Turakulov <nodir@chromium.org>
> 

TBR=iannucci@chromium.org,dnj@chromium.org,nodir@chromium.org,chromium-reviews@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= chromium:694911 

Change-Id: I2822531a3b5cd91c11db6b86cc9e2866df4cbba7
Reviewed-on: https://chromium-review.googlesource.com/448096
Reviewed-by: Daniel Jacques <dnj@chromium.org>
Commit-Queue: Daniel Jacques <dnj@chromium.org>

[modify] https://crrev.com/91310531c31fa645256b4fb5d44b460c42b3e151/scripts/slave/logdog_bootstrap.py
[modify] https://crrev.com/91310531c31fa645256b4fb5d44b460c42b3e151/scripts/slave/remote_run.py
[modify] https://crrev.com/91310531c31fa645256b4fb5d44b460c42b3e151/scripts/slave/unittests/remote_run_test.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/25b7d29724f9e071248f1bba04f15fdef74aa60c

commit 25b7d29724f9e071248f1bba04f15fdef74aa60c
Author: Dan Jacques <dnj@chromium.org>
Date: Tue Feb 28 20:33:03 2017

file: Create "fileutil", remove common import.

Add "fileutil.py", a file maniulation resource cloning the capabilities
of "common/chromium_utils.py", to the "file" recipe module. Replace
imports of "chromium_utils" with "fileutil.py" invocations.

This removes the dependency of these functions "tools/build" being
somewhere on PYTHONPATH, which has always been an invalid assumption
that sort of magically worked anyway. The magic is cut off when run
through Kitchen.

BUG= chromium:584783 , chromium:694911 
TEST=expectations,local
  - Ran each "fileutil.py" subcommand locally, seems to work.

Change-Id: Ia1194be91b39e60cbe3845c222b9e1b2029c0f88
Reviewed-on: https://chromium-review.googlesource.com/448156
Commit-Queue: Daniel Jacques <dnj@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/bisection/android_bisect_staging.expected/perf_tryjob_failed_test_android_nexus6_perf_bisect.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/chromium.expected/full_chromium_fyi_LTO_Linux.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Android_deterministic__dbg_.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/art.expected/aosp-builder-cms__ON__client.art__clobber.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/skia/swarm_trigger.expected/Build-Ubuntu-GCC-x86_64-Release-RemoteRun.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/chromium.expected/full_tryserver_chromium_perf_staging_win_perf_bisect.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/skia/ct_skps.expected/CT_IMG_DECODE_10k_SKPs.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipe_modules/swarming/example.expected/isolated_script_expired_new.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_nexus6_perf_bisect.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus5_perf_bisect.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_recipe_android_one_perf_bisect.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/chromium.expected/full_chromium_perf_Win_7_Intel_GPU_Perf.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/chromium.expected/full_chromium_android_Lollipop_Phone_Tester.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Windows_Clang_deterministic_fail.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/chromium.expected/full_chromium_perf_fyi_Win_Clang_Builder.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/flutter/flutter.expected/mac_cannot_find_xcode.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Linux_deterministic__dbg_.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Chromium_Linux_Goma_Canary_LocalOutputCache.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_recipe_staging_android_nexus5X_perf_bisect.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/chromium.expected/full_chromium_perf_Mac_Pro_10_11_Perf.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Optional_Linux_Release__NVIDIA_.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipe_modules/auto_bisect/example.expected/gathering_references_no_values.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/cronet.expected/android_cronet_builder__dbg_.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Android_Find_Annotated_Test.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipe_modules/auto_bisect/example.expected/basic_mac_bisect.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/syzygy/continuous.expected/full_master_client_syzygy_win_x64_dbg_try.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/cronet.expected/local_test.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/skia/swarm_trigger.expected/Build-Mac-Clang-x86_64-Release.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_one_perf_bisect.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipe_modules/auto_bisect/example.expected/basic_win32_bisect.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClang64.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/return_code.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/bisection/android_bisect.expected/local_basic_recipe_disconnected_device.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/bisection/android_bisect_staging.expected/perf_tryjob_failed_test_android_nexus7_perf_bisect.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_one_perf_bisect.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Chromium_Mac_10_9_Goma_Canary__dbg__clobber_.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/chromium.expected/full_chromium_win_Win7_Tests__1_.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/bisection/desktop_bisect.expected/basic_perf_tryjob.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Linux_Release__NVIDIA_GeForce_730_.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/skia/swarm_trigger.expected/Test-Win8-MSVC-ShuttleB-CPU-AVX2-x86_64-Release.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_webview_arm64_aosp_perf_bisect.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/bisection/android_bisect_staging.expected/local_basic_recipe_no_device.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipe_modules/swarming/example.expected/isolated_script_with_custom_merge.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/chromium.expected/full_client_skia_Win7_Tests__1_.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/chromium.expected/full_client_skia_Mac10_9_Tests_Trybot.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/chromium.expected/full_chromium_chrome_Google_Chrome_Mac.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipe_modules/auto_bisect/example.expected/return_code.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus5X_Perf__1_.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/bisection/desktop_bisect_staging.expected/basic_perf_tryjob_with_bucket.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/chromium.expected/full_chromium_gpu_Mac_Retina_Release__AMD_.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/return_code_fail.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClngLLDdbg_tester.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_recipe_android_webview_nexus6_aosp_perf_bisect.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/chromium.expected/full_chromium_gpu_Linux_Release__NVIDIA_.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Win10_Debug__Intel_HD_530_.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Linux_Release__AMD_R5_230_.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/chromium.expected/full_chromium_win_Win7_Tests__dbg__1_.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/swarming/deterministic_build.expected/full_chromium_swarm_Android_deterministic_fail.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/dart/dart2js_nobuild.expected/dart2js-mac10.11-safari-1-3-be.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_perf_android64_tests__l_nexus9_.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus5X_perf_bisect.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/chromium_codesearch.expected/full_codesearch_gen_chromium_linux.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Android_Remoting_Tests.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus5X_WebView_Perf__1_.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Android__Nexus4_.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/chromium.expected/dynamic_swarmed_failed_isolated_script_test.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/cronet.expected/cronet_try.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/art.expected/host-x86-concurrent-collector__ON__client.art__clobber.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64_ASAN___debug_builder.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_staging_android_nexus5X_perf_bisect.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/chromium.expected/full_chromium_perf_fyi_Mac_Power_Low_End_Perf.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/chromium.expected/full_chromium_lkgr_TSAN_Release.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_archive.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus5_Perf__1_.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipe_modules/auto_bisect/example.expected/failed_build.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_nexus7_perf_bisect.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/skia/swarm_perf.expected/Perf-Win8-MSVC-ShuttleB-GPU-HD4600-x86_64-Release-Trybot.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_one_perf_bisect.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_nexus7_perf_bisect.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/bisection/desktop_bisect.expected/basic_perf_tryjob_with_metric_valueset.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/bisection/android_bisect_staging.expected/perf_tryjob_failed_test_android_fyi_perf_bisect.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Mac10_11.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/skia/swarm_trigger.expected/Test-Android-GCC-Nexus7v2-GPU-Tegra3-Arm7-Release.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/chromium.expected/full_chromium_perf_fyi_Win_10_Low_End_Perf_Tests.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/chromium.expected/full_chromium_perf_fyi_Win_7_Intel_GPU_Perf__Xeon_.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/skia/swarm_test.expected/missing_SK_IMAGE_VERSION_device.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClang64_dbg__tester.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipe_modules/zip/example.expected/linux.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/chromium.expected/full_tryserver_chromium_perf_winx64intel_perf_bisect.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/skia/swarm_trigger.expected/recipe_with_gerrit_patch.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/cronet.expected/android_cronet_marshmallow_64bit_perf.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_nexus6_perf_bisect.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/chromium.expected/full_chromium_perf_Win_10_Perf.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/skia/ct_skps.expected/CT_DM_10k_SKPs.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/chromium.expected/full_chromium_android_Android_WebView_N__dbg_.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_with_revisions_android_fyi_perf_bisect.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/chromium.expected/full_chromium_perf_Win_10_High_DPI_Perf.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_clobber_rel_ng.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClang.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/chromium.expected/msan.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_mac_gpu.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipe_modules/auto_bisect/example.expected/bad_config.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/chromium.expected/full_tryserver_chromium_perf_win_8_perf_bisect.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_with_revisions_android_one_perf_bisect.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClangGoma.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/art.expected/volantis-armv8-ndebug__ON__client.art__clobber.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/chromium.expected/full_chromium_perf_fyi_Win_10_4_Core_Low_End_Perf_Tests.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/chromium.expected/full_chromium_lkgr_UBSan_vptr_Release.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/chromium.expected/dynamic_gtest.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/chromium.expected/dynamic_instrumentation_test.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/chromium.expected/full_tryserver_chromium_perf_win_perf_bisect.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/chromium.expected/full_chromium_win_Win10_Tests_x64.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Win7_Debug__AMD_.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/art.expected/host-x86_64-debug__ON__client.art__clobber.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/chromium.expected/full_tryserver_chromium_perf_mac_air_perf_bisect.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/chromium.expected/full_chromium_Android.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Win10_Debug__NVIDIA_.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/skia/swarm_test.expected/adb_in_path.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/skia/swarm_trigger.expected/Build-Ubuntu-GCC-Arm64-Debug-Android_Vulkan.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_Linux_ChromiumOS_Tests__1_.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/skia/swarm_perf.expected/Perf-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-VisualBench.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_recipe_android_fyi_perf_bisect.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/bisection/android_bisect_staging.expected/perf_tryjob_failed_test_android_one_perf_bisect.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64_ASAN_no_inline___release_builder.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/chromium.expected/full_chromium_fyi_CFI_Linux_CF.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/skia/ct_skps.expected/CT_IMG_DECODE_100k_SKPs.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/chromium.expected/full_tryserver_chromium_perf_winx64_10_perf_bisect.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/skia/swarm_test.expected/big_issue_number.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/basic_buildbot_bisect.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/skia/swarm_trigger.expected/Perf-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Trybot.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/chromium.expected/full_chromium_fyi_CrWinClang_shared__tester.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/syzygy/continuous.expected/full_master_client_syzygy_win_official_try.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Nexus6_WebView_Perf__1_.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Linux_remote_run_Tester.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/chromium.expected/chromium_webkit_parent_revision_chromium.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_staging_android_nexus5X_perf_bisect.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus7_perf_bisect.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/chromium.expected/full_client_skia_Mac10_9_Tests.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/chromium.expected/dynamic_swarmed_instrumentation_test.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Chromium_Mac_10_9_Goma_Canary__clobber_.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_with_metric_android_nexus5_perf_bisect.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_with_metric_android_fyi_perf_bisect.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/chromium.expected/full_chromium_android_fyi_Nougat_Phone_Tester.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/bisection/android_bisect_staging.expected/basic_perf_tryjob_staging_android_nexus5X_perf_bisect.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTWin64_dll__tester.json
[modify] https://crrev.com/25b7d29724f9e071248f1bba04f15fdef74aa60c/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Win7_Release__AMD_R5_230_.json
[m

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/8e12a7b6e31acf2501bb0d6f0de5def90cb76bd8

commit 8e12a7b6e31acf2501bb0d6f0de5def90cb76bd8
Author: Dan Jacques <dnj@chromium.org>
Date: Tue Feb 28 21:05:23 2017

Add Kitchen remote_run bootstrap canary (#5).

Update "remote_run" to introduce a Kitchen canary feature which can be
enabled per-waterfall to use Kitchen to bootstrap recipes instead of
explicitly bootstrapping in "remote_run". This normalizes the LUCI and
non-LUCI approaches to recipe engine remote invocation and removes a
significant part of "remote_run"'s code.

This land doesn't actually enable Kithen, but it lands all of the
Kitchen conditional code. This will allow smaller patches for future
iterations.

BUG= chromium:694911 
TEST=local

Change-Id: I73be41fbc8a457bb62f4864c6dfbf340a89d33dc
Reviewed-on: https://chromium-review.googlesource.com/448097
Reviewed-by: Benjamin Pastene <bpastene@chromium.org>
Commit-Queue: Daniel Jacques <dnj@chromium.org>

[modify] https://crrev.com/8e12a7b6e31acf2501bb0d6f0de5def90cb76bd8/scripts/slave/logdog_bootstrap.py
[modify] https://crrev.com/8e12a7b6e31acf2501bb0d6f0de5def90cb76bd8/scripts/slave/remote_run.py
[modify] https://crrev.com/8e12a7b6e31acf2501bb0d6f0de5def90cb76bd8/scripts/slave/unittests/remote_run_test.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/c97e1ea198c885b842e7852f096bad6a0c3566c4

commit c97e1ea198c885b842e7852f096bad6a0c3566c4
Author: Dan Jacques <dnj@chromium.org>
Date: Thu Mar 02 19:28:06 2017

Use Kitchen for remote_run.py canary.

This enables Kitchen for remote_run canary masters. It explicitly adds
"tools/build" to PYTHONPATH, since some recipes rely on that.

BUG= chromium:694911 
TEST=local

Change-Id: Ib78b5ea9ad4a3599672983fb3c39c76e43414670
Reviewed-on: https://chromium-review.googlesource.com/448724
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Daniel Jacques <dnj@chromium.org>

[modify] https://crrev.com/c97e1ea198c885b842e7852f096bad6a0c3566c4/scripts/slave/remote_run.py
[modify] https://crrev.com/c97e1ea198c885b842e7852f096bad6a0c3566c4/scripts/slave/unittests/remote_run_test.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/1ff0ef17f962010763b522a98ffcbedd4c178332

commit 1ff0ef17f962010763b522a98ffcbedd4c178332
Author: Daniel Jacques <dnj@chromium.org>
Date: Thu Mar 02 19:33:14 2017

Revert "Use Kitchen for remote_run.py canary."

This reverts commit c97e1ea198c885b842e7852f096bad6a0c3566c4.

Reason for revert: https://uberchromegw.corp.google.com/i/chromium.infra.cron/builders/rebaseline-o-matic/builds/620904

Original change's description:
> Use Kitchen for remote_run.py canary.
> 
> This enables Kitchen for remote_run canary masters. It explicitly adds
> "tools/build" to PYTHONPATH, since some recipes rely on that.
> 
> BUG= chromium:694911 
> TEST=local
> 
> Change-Id: Ib78b5ea9ad4a3599672983fb3c39c76e43414670
> Reviewed-on: https://chromium-review.googlesource.com/448724
> Reviewed-by: Nodir Turakulov <nodir@chromium.org>
> Commit-Queue: Daniel Jacques <dnj@chromium.org>
> 

TBR=dnj@chromium.org,nodir@chromium.org,chromium-reviews@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= chromium:694911 

Change-Id: Ib85c4b7ef8cfeee2d5e207e824c0d73a1eff6939
Reviewed-on: https://chromium-review.googlesource.com/448800
Reviewed-by: Daniel Jacques <dnj@chromium.org>
Commit-Queue: Daniel Jacques <dnj@chromium.org>

[modify] https://crrev.com/1ff0ef17f962010763b522a98ffcbedd4c178332/scripts/slave/remote_run.py
[modify] https://crrev.com/1ff0ef17f962010763b522a98ffcbedd4c178332/scripts/slave/unittests/remote_run_test.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/aeca808a622b4f0ae1b46cf5aec029c2802cad87

commit aeca808a622b4f0ae1b46cf5aec029c2802cad87
Author: Dan Jacques <dnj@chromium.org>
Date: Thu Mar 02 19:51:11 2017

Use Kitchen for remote_run.py canary (Round 2)

This enables Kitchen for remote_run canary masters. It explicitly adds
"tools/build" to PYTHONPATH, since some recipes rely on that.

This fixes an issue with the previous attempt where "origin/master",
no longer accepted by Kitchen, needs to be stripped.
Recently-restarted masters will not supply "origin/master", but older
ones will still do this, so we fix it locally.

BUG= chromium:694911 
TEST=local

Change-Id: I97581acaaba54b42b9a57db4826ecd2efe9ca583
Reviewed-on: https://chromium-review.googlesource.com/448820
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Daniel Jacques <dnj@chromium.org>

[modify] https://crrev.com/aeca808a622b4f0ae1b46cf5aec029c2802cad87/scripts/slave/remote_run.py
[modify] https://crrev.com/aeca808a622b4f0ae1b46cf5aec029c2802cad87/scripts/slave/unittests/remote_run_test.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/d3cabc5bbb5aa28a499edd510083467cad20adb8

commit d3cabc5bbb5aa28a499edd510083467cad20adb8
Author: Dan Jacques <dnj@chromium.org>
Date: Thu Mar 02 20:18:28 2017

Add cache, migrate / cleanup Git cache paths.

Add a cache directory ("/b/c") to Kitchen so that it stops using a
temporary cache directory.

Migrate default Git cache directory ("git_cache") to its explicit cache
directory ("git") name. This behavior is specified in
the "depot_tools/infra_paths" recipe module.

BUG= chromium:694911 
TEST=None

Change-Id: I4b74069d0cd34052c904c5547a49ef7a9adcaebe
Reviewed-on: https://chromium-review.googlesource.com/448249
Commit-Queue: Daniel Jacques <dnj@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/d3cabc5bbb5aa28a499edd510083467cad20adb8/scripts/slave/remote_run.py
[modify] https://crrev.com/d3cabc5bbb5aa28a499edd510083467cad20adb8/scripts/slave/unittests/remote_run_test.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/eccd2b7c938c7dc8bf0c31e86b3b3ce4dec63042

commit eccd2b7c938c7dc8bf0c31e86b3b3ce4dec63042
Author: Dan Jacques <dnj@chromium.org>
Date: Thu Mar 02 22:36:54 2017

remote_run: Force canary via build property.

Enable remote_run to force a canary mode via a build property. This will
enable canary testing on waterfalls that are not explicitly canary
waterfalls. Notably, a human can specify this property when using
"Force Build" to test canary mode on that builder.

BUG= chromium:694911 
TEST=None

Change-Id: Idfdd1d8459750464fa685cd85a4e53ca78758c67
Reviewed-on: https://chromium-review.googlesource.com/448763
Commit-Queue: Daniel Jacques <dnj@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/eccd2b7c938c7dc8bf0c31e86b3b3ce4dec63042/scripts/slave/remote_run.py
[modify] https://crrev.com/eccd2b7c938c7dc8bf0c31e86b3b3ce4dec63042/scripts/slave/unittests/remote_run_test.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/0de551d99fc50d1aee79e6986c3974473306713b

commit 0de551d99fc50d1aee79e6986c3974473306713b
Author: Dan Jacques <dnj@chromium.org>
Date: Thu Mar 02 23:30:00 2017

remote_run: Add more consistent python paths.

Add extra Python paths, similar to those included in non-Kitchen remote
run builds.

BUG= chromium:694911 
TEST=None

Change-Id: I03c075a16c29eeeef5e0f9b24daf922d3fb70285
Reviewed-on: https://chromium-review.googlesource.com/448996
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

[modify] https://crrev.com/0de551d99fc50d1aee79e6986c3974473306713b/scripts/slave/remote_run.py
[modify] https://crrev.com/0de551d99fc50d1aee79e6986c3974473306713b/scripts/slave/unittests/remote_run_test.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/592c3d1eb428f76a76b30438dacf4a7697a86d34

commit 592c3d1eb428f76a76b30438dacf4a7697a86d34
Author: Dan Jacques <dnj@chromium.org>
Date: Fri Mar 03 19:13:43 2017

remote_run: Add kitchen-to-remote cache conversion.

Currently, there is a path to convert remote-style caches to
Kitchen-style caches. Add an inverse path to convert kitchen-style caches to
remote-style caches. This should minimize the performance impact on
production systems of successive canary/revert/fix cycles.

BUG= chromium:694911 
TEST=None

Change-Id: I4fee89e027700102de83cfb2297485b0a18b94f1
Reviewed-on: https://chromium-review.googlesource.com/449953
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Daniel Jacques <dnj@chromium.org>

[modify] https://crrev.com/592c3d1eb428f76a76b30438dacf4a7697a86d34/scripts/slave/remote_run.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/fadc6c46a57278b944280e925e3ddbb5789cb4b0

commit fadc6c46a57278b944280e925e3ddbb5789cb4b0
Author: Dan Jacques <dnj@chromium.org>
Date: Fri Mar 03 19:27:40 2017

remote_run: Add more waterfalls to canary.

Add more waterfalls, notably "chromium.fyi", to the canary set.

BUG= chromium:694911 
TEST=None

Change-Id: Icae5384710de46fbab2553a11be8980869bb681a
Reviewed-on: https://chromium-review.googlesource.com/449061
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Daniel Jacques <dnj@chromium.org>

[modify] https://crrev.com/fadc6c46a57278b944280e925e3ddbb5789cb4b0/scripts/slave/remote_run.py

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/56d3b24ea5166d8fd859a3e42c5f12c87268201c

commit 56d3b24ea5166d8fd859a3e42c5f12c87268201c
Author: Dan Jacques <dnj@chromium.org>
Date: Sat Mar 04 01:33:04 2017

Kitchen: Always use result proto with recipes.

Always use the reuslt protobuf with the recipe engine. This invokes the
"new" step runner path, which will capture things like recipe exceptions
and handle them gracefully.

BUG= chromium:694911 
TEST=None

Change-Id: I1da67129bd5553a13f1db179a41518a48e4c84bb
Reviewed-on: https://chromium-review.googlesource.com/450021
Commit-Queue: Daniel Jacques <dnj@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/56d3b24ea5166d8fd859a3e42c5f12c87268201c/go/src/infra/tools/kitchen/cook.go

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/master-manager/+/26486873dc7aa669967d5aee68a87a42e058dc41

commit 26486873dc7aa669967d5aee68a87a42e058dc41
Author: Dan Jacques <dnj@chromium.org>
Date: Sat Mar 04 02:10:25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/5863e385db5c79fdc1055d3b40e9a707f598599d

commit 5863e385db5c79fdc1055d3b40e9a707f598599d
Author: Dan Jacques <dnj@chromium.org>
Date: Sat Mar 04 03:26:00 2017

remote_run: Bump Kitchen canary, use result proto.

Bump Kitchen to 56d3b24ea5166d8fd859a3e42c5f12c87268201c.

This version enables "use_result_proto" by default. Update the output
JSON interpreter accordingly.

BUG= chromium:694911 
TEST=None

Change-Id: Ic7bca8c4fcfcb0190b7e845d079c5056ad2c54d1
Reviewed-on: https://chromium-review.googlesource.com/448947
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Daniel Jacques <dnj@chromium.org>

[modify] https://crrev.com/5863e385db5c79fdc1055d3b40e9a707f598599d/scripts/slave/remote_run.py

Hi, after this is enabled to chromium.fyi, we noticed goma canary buildbot gets slower, and goma started using a lot of memory.

It looks the build directory name is always unique. Since goma is expecting CWD is not so changed, various cache on goma cannot be utilized between builds. Especially compile result cannot be shared in some platforms.

So... can we make build directory name fixed? If we'd like to use unique build directory name, we need to re-consider how to cache various things in goma. Basically we're using abs path. Maybe we need to discuss how to cache more.

Cool! This is exactly the sort of thing I am hoping to to shake out from this! Can you please link some of the builds where you noticed build time differences, as well as the related timing information, so we have a starting point for analysis?

Kitchen does, indeed, create a temporary directory, which it uses to run recipes out of. However, it should generally be behaving the same way as "remote_run" was prior to the switch. There are some subtle differences, and I'm working on resolving them.

Can you tell if the problem is the CWD of the build? Do we need to make that "/b/build/slave/remote_run"? I think, ideally, all cached data would be done in "/b/c/<something>"; maybe we should tune things to run the build out of there instead of the CWD?

I need to explain how goma generates a cache. We have "server side cache" and "client side cache".

server side cache has "compile cache", which is caching the object files, build dependency files, etc.

The compile cache is something like a map from (command line, CWD, input, compiler, ...) -> (object file; *.o, *.d, ...).
Because debug information contains CWD, we need to use CWD as cache key.
(Note: When debug information is not necessary, we're omitting CWD from key, so release build on some platform can utilize compile cache
even if CWD is changed.)

If we can keep to use the same build directory (e.g. /b/build/slave/remote_run as you mentioned), this is not a problem.


"client side cache" is a cache to skip several calculation in goma. If goma can prove the list of source files is not changed from
the previous build, goma re-use the list (DepsCache). This is basically using abs path, so if build directory is changed from the previous
build, goma cannot reuse it. This calculation is a bit heavy and memory consuming, so if we cannot utilize this cache, goma uses more memory.

+phosek@, the last comment is relevant to how Fuchsia is using Goma through LUCI too.

Example taking from "Chromium Mac 10.9 Goma Canary (clobber)" build.

In build 21283, DepsCache was utilized well. From build 21284, DepsCache was not utilized at all.
The memory usage are various among builds, after build 21286, our diagnosis says "using a lot of memory". It triggers when more than 2G~3G memory is used.
After build 21286, goma often uses 3.3G memory.

We're tracking goma canary stats in go/macrt. In "Diagnose goma failure ratio (memory)" graph, error ratio has grown after 03 Mar 12:00 (for non-mac. 02 Mar 12:00 for mac)
Also, in "Goma canary clobber builders: Compile time (12-hour moving window, 90%)" graph, build time gets slower after 03 Mar 12:00 (for all platforms).


Build 21283
depscache: table_size=33742 max=2970 total=20892298 average=619 idtable=36187 hit=15389 updated=2 missed=0
https://uberchromegw.corp.google.com/i/chromium.fyi/builders/Chromium%20Mac%2010.9%20Goma%20Canary%20%28clobber%29/builds/21283
https://uberchromegw.corp.google.com/i/chromium.fyi/builders/Chromium%20Mac%2010.9%20Goma%20Canary%20%28clobber%29/builds/21283/steps/postprocess_for_goma.goma_stat/logs/stdio

Build 21284
depscache: table_size=15368 max=2970 total=9232775 average=600 idtable=36174 hit=23 updated=0 missed=15368
https://uberchromegw.corp.google.com/i/chromium.fyi/builders/Chromium%20Mac%2010.9%20Goma%20Canary%20%28clobber%29/builds/21284
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.fyi%2FChromium_Mac_10.9_Goma_Canary__clobber_%2F21284%2F%2B%2Frecipes%2Fsteps%2Fpostprocess_for_goma%2F0%2Fsteps%2Fgoma_stat%2F0%2Fstdout

Build 21285
depscache: table_size=30736 max=2970 total=18465550 average=600 idtable=72348 hit=23 updated=0 missed=15368
https://uberchromegw.corp.google.com/i/chromium.fyi/builders/Chromium%20Mac%2010.9%20Goma%20Canary%20%28clobber%29/builds/21285
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.fyi%2FChromium_Mac_10.9_Goma_Canary__clobber_%2F21285%2F%2B%2Frecipes%2Fsteps%2Fpostprocess_for_goma%2F0%2Fsteps%2Fgoma_stat%2F0%2Fstdout

Build 21286
depscache: table_size=46104 max=2970 total=27698325 average=600 idtable=108522 hit=23 updated=0 missed=15368
https://uberchromegw.corp.google.com/i/chromium.fyi/builders/Chromium%20Mac%2010.9%20Goma%20Canary%20%28clobber%29/builds/21286
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.fyi%2FChromium_Mac_10.9_Goma_Canary__clobber_%2F21286%2F%2B%2Frecipes%2Fsteps%2Fpostprocess_for_goma%2F0%2Fsteps%2Fgoma_stat%2F0%2Fstdout

Thanks for putting that together.

Environment:
Most of the meaningful environment variables are the same. Notably, the CWD between these two builds is the same (  PWD=/b/build/slave/Chromium_Mac_10_9_Goma_Canary__clobber_/build). The PYTHONPATH is massively different, but I don't think that's the problem.

Recipe Properties:
Most of the recipe properties are the same. "path_config" is "kitchen" in pre-Kitchen builds, and is now not set at all. This may be the problem.

With compile...

Before:
ninja: Entering directory `/b/c/b/Chromium_Mac_10_9_Goma_Canary__clobber_/src/out/Release'

After:
ninja: Entering directory `/b/rr/tmpWbjEIy/w/src/out/Release'

This is missing "builder_cache" setting: https://chromium.googlesource.com/chromium/tools/depot_tools/+/master/recipe_modules/infra_paths/path_config.py#38

This is very useful info, in Fuchsia we're using LUCI (no Buildbot) setup including goma and always doing clean build. That means that we're always building in a different (random) directory set by Kitchen. According to shinyak@'s explanation, it seems like we're not taking any advantage of server-side nor client-side cache. I'd like to see this getting addressed since caching is really crucial for our build performance.

#52 dnj
PYTHONPATH should not affect goma cache, so it should be fine if it's changed.

#54 phosek
Yeah, we recommend to use the same directory name. If you're doing clobber build, 
Note: DepsCache is not enabled by default. To enable it, you need to set GOMA_DEPS_CACHE_FILE env. e.g. GOMA_DEPS_CACHE_FILE=goma.deps (any file name is ok)

FYI also: we're experimenting LocalOutputCache, which saves compile result locally. This consumes disks a lot (GC is performed once a day), but if you're doing a lot of clean build, this will improve build speed (and reduce goma server load).

Currently we're only using GOMA_CACHE_DIR (see https://fuchsia.googlesource.com/infra/recipes/+/master/recipe_modules/goma/api.py#102). How does GOMA_DEPS_CACHE_FILE interact with GOMA_CACHE_DIR? Can the GOMA_DEPS_CACHE_FILE live inside GOMA_CACHE_DIR? How do we enable LocalOutputCache?

#56 phosek

DepsCache is generated in GOMA_CACHE_DIR. $GOMA_CACHE_DIR/$GOMA_DEPS_CACHE_FILE is used for DepsCache cache file.

To use LocalOutputCache, set GOMA_LOCAL_OUTPUT_CACHE_DIR=<path/to/somewhere>. It must be in a large disk. (Note that this feature might be immature. Currently testing only on goma canary bot.)

+ goma members

When base_unittest failed in goma canary bot, we got this kind of error (See  Issue 698984 ).

E:\b\rr\tmpb9wmg6\w>call python E:\b\rr\tmpb9wmg6\rw\scripts\slave\..\..\..\depot_tools\gsutil.py -- cp file://e:\b\rr\tmpjkorcb\tmp88mxdm gs://chrome-gtest-results/raw/2017/3/6/7/f82556aec4c9da97e2ad291603e51fa738840976.json.gz 
python: can't open file 'E:\b\rr\tmpb9wmg6\rw\scripts\slave\..\..\..\depot_tools\gsutil.py': [Errno 2] No such file or directory

Maybe this error is also related to this change?

gsutil is used to upload json to track flakiness, right?

Could we please move the Goma discussion to a different bug? Feel free to mark that bug as blocking this one.

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/7077baff956df6ec29329809711b2d95fb8b43eb

commit 7077baff956df6ec29329809711b2d95fb8b43eb
Author: Nodir Turakulov <nodir@google.com>
Date: Tue Mar 07 18:20:39 2017

#61
I made Issue 699332 for goma & kitchen discussion.

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/master-manager/+/f5022337377bb16466810f4bdd30af447d49db04

commit f5022337377bb16466810f4bdd30af447d49db04
Author: Dan Jacques <dnj@google.com>
Date: Tue Mar 14 00:45:06 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/bf242cc7ae530975bfa82f79b9797d630889b095

commit bf242cc7ae530975bfa82f79b9797d630889b095
Author: Dan Jacques <dnj@chromium.org>
Date: Tue Mar 14 01:03:40 2017

chromium.swarm: Switch builders to "remote_run".

Switch builders from "annotated_run" invocation to "remote_run".

BUG= chromium:694911 
TEST=None

Change-Id: I68748aeeab82e924772e877c0311f7be4ae3f586
Reviewed-on: https://chromium-review.googlesource.com/454279
Reviewed-by: Benjamin Pastene <bpastene@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Daniel Jacques <dnj@chromium.org>

[modify] https://crrev.com/bf242cc7ae530975bfa82f79b9797d630889b095/masters/master.chromium.swarm/master.cfg

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/8335468609fa2a01123bc2ea437983e767891609

commit 8335468609fa2a01123bc2ea437983e767891609
Author: Dan Jacques <dnj@chromium.org>
Date: Wed Mar 15 00:57:04 2017

Incorporate "active_subdir" into remote_run.

Currently, "remote_run" uses a fixed path temporary directory, which is
grooms in between builds. It assumes total ownership of this directory.
On builders with multiple active subdirs (e.g., "my-name#12"), we will
incorporate the subdir name into the temporary directory prefix (e.g.,
"rs/12").

This will prevent a circumstance where multiple simultaneous builds on
the same builder will reuse (and prune) each others' subdirectory.

BUG= chromium:694911 
TEST=None

Change-Id: Ia4c17d0f55655fd93d1b7323fe0466ca140b0aa0
Reviewed-on: https://chromium-review.googlesource.com/455241
Commit-Queue: Daniel Jacques <dnj@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

[modify] https://crrev.com/8335468609fa2a01123bc2ea437983e767891609/scripts/slave/remote_run.py
[modify] https://crrev.com/8335468609fa2a01123bc2ea437983e767891609/scripts/slave/unittests/remote_run_test.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/6bfba7afcf2ac793044c44527932e825c21e508a

commit 6bfba7afcf2ac793044c44527932e825c21e508a
Author: Dan Jacques <dnj@chromium.org>
Date: Thu Mar 30 00:26:28 2017

remote_run: Enable per-builder canary whitelisting

Allow "remote_run" to whitelist individual builders on a master, in
addition to the current full-master whitelisting. This will allow a more
targeted approach to canary deployments and testing as we try and fix
remote_run / Kitchen problems.

BUG= chromium:694911 
TEST=None

Change-Id: If83146006f4837d5e03c3dca54791d8412884481
Reviewed-on: https://chromium-review.googlesource.com/462423
Commit-Queue: Daniel Jacques <dnj@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

[modify] https://crrev.com/6bfba7afcf2ac793044c44527932e825c21e508a/scripts/slave/remote_run.py
[modify] https://crrev.com/6bfba7afcf2ac793044c44527932e825c21e508a/scripts/slave/unittests/remote_run_test.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/6bfba7afcf2ac793044c44527932e825c21e508a

commit 6bfba7afcf2ac793044c44527932e825c21e508a
Author: Dan Jacques <dnj@chromium.org>
Date: Thu Mar 30 00:26:28 2017

remote_run: Enable per-builder canary whitelisting

Allow "remote_run" to whitelist individual builders on a master, in
addition to the current full-master whitelisting. This will allow a more
targeted approach to canary deployments and testing as we try and fix
remote_run / Kitchen problems.

BUG= chromium:694911 
TEST=None

Change-Id: If83146006f4837d5e03c3dca54791d8412884481
Reviewed-on: https://chromium-review.googlesource.com/462423
Commit-Queue: Daniel Jacques <dnj@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

[modify] https://crrev.com/6bfba7afcf2ac793044c44527932e825c21e508a/scripts/slave/remote_run.py
[modify] https://crrev.com/6bfba7afcf2ac793044c44527932e825c21e508a/scripts/slave/unittests/remote_run_test.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/b31fffcd8035b6bf40f337ab77eecbb37ef19653

commit b31fffcd8035b6bf40f337ab77eecbb37ef19653
Author: Dan Jacques <dnj@chromium.org>
Date: Mon Apr 03 17:06:58 2017

remote_run: Enable Kitchen for site isolation FYI

Enable Kitchen specifically for the site isolation builders in
"chromium.fyi". These were problematic last deployment, and need to be
fixed.

BUG= chromium:694911 
TEST=None

Change-Id: Icc8b6934d898485dfefce25ef813aec51c3d684b
Reviewed-on: https://chromium-review.googlesource.com/463808
Commit-Queue: Daniel Jacques <dnj@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/b31fffcd8035b6bf40f337ab77eecbb37ef19653/scripts/slave/remote_run.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/dbe97aafbb818ec2f067764caa8504b8fd4c1701

commit dbe97aafbb818ec2f067764caa8504b8fd4c1701
Author: Dan Jacques <dnj@chromium.org>
Date: Mon Apr 03 23:11:13 2017

Use "kitchen" path config for legacy remote run.

Currently, only the "chromium.swarm" and one internal waterfall use
"remote_run" without explicitly specifying the "kitchen" path config.
This CL just makes "kitchen" the explicit and only supported path
configuration value for "remote_run".

BUG= chromium:694911 
TEST=None

Change-Id: Ie0c11b5f7d97398d0262bcaa36793c89f8922579
Reviewed-on: https://chromium-review.googlesource.com/466550
Commit-Queue: Daniel Jacques <dnj@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/dbe97aafbb818ec2f067764caa8504b8fd4c1701/scripts/slave/remote_run.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/af7fe00e5c33f32cd517f29d91aa57575a8cdda4

commit af7fe00e5c33f32cd517f29d91aa57575a8cdda4
Author: Dan Jacques <dnj@chromium.org>
Date: Tue Apr 04 17:39:40 2017

remote_run: Bump Kitchen, cleanup logic.

Bump the Kitchen pin to pick up "generic" infra path configuration.

Remove filesystem migration logic in favor of file deletion cleanup. Add
migration logic for legacy and kitchen configurations to ensure that
bots don't run out of disk space during these migrations.

BUG= chromium:694911 
TEST=None

Change-Id: I1ece76bc2a9bcf37659d7ff5552c2579044fd924
Reviewed-on: https://chromium-review.googlesource.com/466788
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Daniel Jacques <dnj@chromium.org>

[modify] https://crrev.com/af7fe00e5c33f32cd517f29d91aa57575a8cdda4/scripts/slave/remote_run.py
[modify] https://crrev.com/af7fe00e5c33f32cd517f29d91aa57575a8cdda4/scripts/slave/unittests/remote_run_test.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/11d9ab91893e707116b8cdb090c31bfb7587897b

commit 11d9ab91893e707116b8cdb090c31bfb7587897b
Author: Dan Jacques <dnj@chromium.org>
Date: Tue Apr 04 19:04:54 2017

Use cache directory for build checkout.

If the "builder_cache" directory isn't explicitly specified as a
property, the "chromium_checkout"'s "get_checkout_dir" function returns None.
This lets its callers choose which directory to use for checkout. They
always use "start_dir".

This change makes it so that the function no longer returns None. If the
"builder_checkout" directory doesn't exist, it will use "start_dir"
universally now. In doing this, the "chromium_checkout.get_checkout_dir"
function is not no longer able to return None. Some code paths that
anticipated "None" and used default CWD have had their logic simplified
accoringly.

Most Chromium builds use "remote_run", which already uses this scheme,
checking out Chromium to "/b/c/b/<slavedirname>". Those that use
"annotated_run" will not see a difference.

BUG= chromium:694911 
TEST=expectations

Change-Id: Ie96bae9f35c3a2fb8e211212a97067a08c10af9c
Reviewed-on: https://chromium-review.googlesource.com/450397
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Daniel Jacques <dnj@chromium.org>

[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_passed_isolated_script_test.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_gtest_mac_gpu.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/ios/example.expected/expired.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/ios/unified_builder_tester.expected/goma_compilation_failure.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/findit/chromium/update_components.expected/removal.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_chartjson_test_harness_failure.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/chromium/example.expected/basic_out_dir_goma_module_ping_failure.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/findit/chromium/preemptive_bot_update.expected/linux.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/chromium/example.expected/basic_out_dir_ninja_no_op_failure.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/ios/api.py
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/findit/chromium/update_components.expected/script_error.json
[add] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/generic_path_config.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/chromium/example.expected/basic_out_dir_goma_module_build_failure.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/webrtc/api.py
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_script_test_with_args.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect/example.expected/gathering_references_no_values.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect/example.expected/basic_bisect_other_direction.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_passed_isolated_script_perf_test_empty.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect/example.expected/basic_mac_bisect.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/basic_linux_bisect.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_isolated_script_test_harness_failure_no_json.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium_trybot.expected/analyze_runs_nothing_with_no_source_file_changes.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/blink_downstream.py
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect/example.expected/basic_win32_bisect.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/return_code.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/chromium/example.expected/basic_out_dir_with_goma_module.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/build_dynamic_isolated_script_test_compile_target_overriden.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/ios/example.expected/clobber_build.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_instrumentation_nodefault_test.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_passed_isolated_script_perf_test.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/webrtc/more_configs.expected/full_tryserver_webrtc_android_more_configs.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/build_dynamic_swarmed_isolated_script_test_compile_target_overidden.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/webrtc/more_configs.expected/full_client_webrtc_Linux__more_configs_.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_chartjson_test_missing_shard.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/basic_win32_bisect.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect/example.expected/v8_roll_bisect_bis.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect/example.expected/failed_build_inconclusive_1.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/isolated_script_test_bad_custom_merge_script.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/webrtc/libfuzzer.expected/full_client_webrtc_Linux64_Release__Libfuzzer_.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.py
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/v8_roll_bisect_bis.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/chromium_webkit_revision_webkit.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_gtest_memory_mac64.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect/example.expected/return_code.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_local_isolated_script_test_with_unknown_json_results.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/bad_config.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_invalid_json_isolated_script_test.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/findit/chromium/update_components.expected/addition_into_subdirs.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect/example.expected/return_code_fail.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/return_code_fail.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_instrumentation_test_with_timeout_scale.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/ios/example.expected/timed_out.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_gtest_asan_android.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/basic_win64_bisect.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/chromium/example.expected/basic_out_dir_ninja_build_failure.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/no_repro.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_failed_isolated_script_test.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect/example.expected/retest_bisect.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/ios/example.expected/target_cpu_missing.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/ios/example.expected/no_exit_code.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/findit/chromium/preemptive_bot_update.expected/mac.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_script_test_harness_failure.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/retest_bisect.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect/example.expected/failed_build.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/webrtc/more_configs.expected/full_client_webrtc_Android32__more_configs_.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/ios/example.expected/basic.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_gn_instrumentation_test.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/isolated_script_test_invalid_results_handler.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/findit/chromium/update_components.expected/failed_upload.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/findit/chromium/update_components.expected/conflict.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/failed_buildbucket_get.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/webrtc/more_configs.expected/full_tryserver_webrtc_linux_more_configs.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_gtest_memory_builder.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/failed_build_inconclusive_11.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect/example.expected/basic_win64_bisect.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect/example.expected/basic_resource_sizes_bisect.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_isolated_script_test.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_corrupt_json_isolated_script_test.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect/example.expected/basic_linux_bisect.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/basic_mac_bisect.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_gtest_override_compile_targets.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/msan.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_mac_gpu.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect/example.expected/bad_config.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/chromium_webkit_parent_revision_webkit.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect/example.expected/failed_build_inconclusive_11.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/chromium/example.expected/basic_out_dir_without_compile_py.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect/example.expected/v8_roll_bisect.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/findit/chromium/update_components.expected/no_change.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_gtest_win.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/findit/chromium/preemptive_bot_update.py
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_instrumentation_nodefault_build.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_gtest.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_junit_test.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_gtest.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/chromium_checkout/api.py
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect/example.expected/no_repro.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_isolated_script_test_harness_failure_zero_retcode.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_passed_isolated_script_test.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/build_dynamic_swarmed_isolated_script_test.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/chromium/example.expected/basic_out_dir_goma_module_start_failure.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_linux_gpu.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/ios/example.expected/fyi.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/webrtc/auto_roll_webrtc_deps.expected/rolling_activated.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/basic_buildbot_bisect.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_failed_isolated_script_test.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/findit/chromium/update_components.expected/addition.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/chromium_webkit_parent_revision_chromium.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_gtest_on_builder.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/ios/example.expected/clobber_checkout.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_gtest_android.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_instrumentation_test.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium_trybot.expected/recipe_config_changes_not_retried_without_patch.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_perf_test_ignore_failure.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_instrumentation_test.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/ios/example.expected/errors.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/chromium/example.expected/basic_no_out_dir_with_goma_module.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect/example.expected/failed_buildbucket_get.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/one_failure_keeps_going_dynamic_tests.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_gtest_memory_asan_no_lsan.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_local_isolated_script_test_with_passed_json_results.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/build_dynamic_isolated_script_test.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect/api.py
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/v8_roll_bisect.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect/example.expected/no_values.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/buildnumber_zero.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_passed_with_bad_retcode_isolated_script_test.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_passed_isolated_script_test_with_swarming_failure.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/chromium_webkit_revision_chromium.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_win_non_gpu.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/ios/example.expected/infra_failure.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/gathering_references_no_values.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_serialized_gtests.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect/example.expected/basic_buildbot_bisect.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/failed_build_inconclusive_1.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/chromium_webkit_crash.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_local_isolated_script_test_with_custom_results_handler.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_chartjson_test_disabled.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/ios/example.expected/test_failure.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/chromium/example.expected/basic_out_dir.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_script_test_failure.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_local_isolated_script_test_with_corrupt_json_results.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/failed_build.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/findit/chromium/preemptive_bot_update.expected/win.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_local_isolated_script_test_with_failed_json_results.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/chromium_checkout/__init__.py
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium_trybot.expected/analyze_webkit.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_passed_isolated_script_perf_test_no_chartjson.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/tsan.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/no_values.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/ios/example.expected/is_debug_missing.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/basic_resource_sizes_bisect.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/webrtc/libfuzzer.expected/full_tryserver_webrtc_linux_libfuzzer_r

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/11d9ab91893e707116b8cdb090c31bfb7587897b

commit 11d9ab91893e707116b8cdb090c31bfb7587897b
Author: Dan Jacques <dnj@chromium.org>
Date: Tue Apr 04 19:04:54 2017

Use cache directory for build checkout.

If the "builder_cache" directory isn't explicitly specified as a
property, the "chromium_checkout"'s "get_checkout_dir" function returns None.
This lets its callers choose which directory to use for checkout. They
always use "start_dir".

This change makes it so that the function no longer returns None. If the
"builder_checkout" directory doesn't exist, it will use "start_dir"
universally now. In doing this, the "chromium_checkout.get_checkout_dir"
function is not no longer able to return None. Some code paths that
anticipated "None" and used default CWD have had their logic simplified
accoringly.

Most Chromium builds use "remote_run", which already uses this scheme,
checking out Chromium to "/b/c/b/<slavedirname>". Those that use
"annotated_run" will not see a difference.

BUG= chromium:694911 
TEST=expectations

Change-Id: Ie96bae9f35c3a2fb8e211212a97067a08c10af9c
Reviewed-on: https://chromium-review.googlesource.com/450397
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Daniel Jacques <dnj@chromium.org>

[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_passed_isolated_script_test.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_gtest_mac_gpu.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/ios/example.expected/expired.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/ios/unified_builder_tester.expected/goma_compilation_failure.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/findit/chromium/update_components.expected/removal.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_chartjson_test_harness_failure.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/chromium/example.expected/basic_out_dir_goma_module_ping_failure.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/findit/chromium/preemptive_bot_update.expected/linux.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/chromium/example.expected/basic_out_dir_ninja_no_op_failure.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/ios/api.py
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/findit/chromium/update_components.expected/script_error.json
[add] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/generic_path_config.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/chromium/example.expected/basic_out_dir_goma_module_build_failure.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/webrtc/api.py
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_script_test_with_args.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect/example.expected/gathering_references_no_values.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect/example.expected/basic_bisect_other_direction.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_passed_isolated_script_perf_test_empty.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect/example.expected/basic_mac_bisect.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/basic_linux_bisect.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_isolated_script_test_harness_failure_no_json.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium_trybot.expected/analyze_runs_nothing_with_no_source_file_changes.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/blink_downstream.py
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect/example.expected/basic_win32_bisect.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/return_code.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/chromium/example.expected/basic_out_dir_with_goma_module.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/build_dynamic_isolated_script_test_compile_target_overriden.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/ios/example.expected/clobber_build.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_instrumentation_nodefault_test.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_passed_isolated_script_perf_test.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/webrtc/more_configs.expected/full_tryserver_webrtc_android_more_configs.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/build_dynamic_swarmed_isolated_script_test_compile_target_overidden.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/webrtc/more_configs.expected/full_client_webrtc_Linux__more_configs_.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_chartjson_test_missing_shard.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/basic_win32_bisect.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect/example.expected/v8_roll_bisect_bis.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect/example.expected/failed_build_inconclusive_1.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/isolated_script_test_bad_custom_merge_script.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/webrtc/libfuzzer.expected/full_client_webrtc_Linux64_Release__Libfuzzer_.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.py
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/v8_roll_bisect_bis.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/chromium_webkit_revision_webkit.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_gtest_memory_mac64.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect/example.expected/return_code.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_local_isolated_script_test_with_unknown_json_results.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/bad_config.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_invalid_json_isolated_script_test.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/findit/chromium/update_components.expected/addition_into_subdirs.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect/example.expected/return_code_fail.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/return_code_fail.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_instrumentation_test_with_timeout_scale.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/ios/example.expected/timed_out.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_gtest_asan_android.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/basic_win64_bisect.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/chromium/example.expected/basic_out_dir_ninja_build_failure.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/no_repro.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_failed_isolated_script_test.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect/example.expected/retest_bisect.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/ios/example.expected/target_cpu_missing.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/ios/example.expected/no_exit_code.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/findit/chromium/preemptive_bot_update.expected/mac.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_script_test_harness_failure.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/retest_bisect.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect/example.expected/failed_build.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/webrtc/more_configs.expected/full_client_webrtc_Android32__more_configs_.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/ios/example.expected/basic.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_gn_instrumentation_test.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/isolated_script_test_invalid_results_handler.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/findit/chromium/update_components.expected/failed_upload.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/findit/chromium/update_components.expected/conflict.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/failed_buildbucket_get.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/webrtc/more_configs.expected/full_tryserver_webrtc_linux_more_configs.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_gtest_memory_builder.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/failed_build_inconclusive_11.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect/example.expected/basic_win64_bisect.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect/example.expected/basic_resource_sizes_bisect.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_isolated_script_test.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_corrupt_json_isolated_script_test.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect/example.expected/basic_linux_bisect.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/basic_mac_bisect.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_gtest_override_compile_targets.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/msan.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_mac_gpu.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect/example.expected/bad_config.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/chromium_webkit_parent_revision_webkit.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect/example.expected/failed_build_inconclusive_11.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/chromium/example.expected/basic_out_dir_without_compile_py.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect/example.expected/v8_roll_bisect.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/findit/chromium/update_components.expected/no_change.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_gtest_win.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/findit/chromium/preemptive_bot_update.py
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_instrumentation_nodefault_build.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_gtest.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_junit_test.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_gtest.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/chromium_checkout/api.py
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect/example.expected/no_repro.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_isolated_script_test_harness_failure_zero_retcode.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_passed_isolated_script_test.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/build_dynamic_swarmed_isolated_script_test.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/chromium/example.expected/basic_out_dir_goma_module_start_failure.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_linux_gpu.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/ios/example.expected/fyi.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/webrtc/auto_roll_webrtc_deps.expected/rolling_activated.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/basic_buildbot_bisect.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_failed_isolated_script_test.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/findit/chromium/update_components.expected/addition.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/chromium_webkit_parent_revision_chromium.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_gtest_on_builder.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/ios/example.expected/clobber_checkout.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_gtest_android.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_instrumentation_test.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium_trybot.expected/recipe_config_changes_not_retried_without_patch.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_perf_test_ignore_failure.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_instrumentation_test.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/ios/example.expected/errors.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/chromium/example.expected/basic_no_out_dir_with_goma_module.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect/example.expected/failed_buildbucket_get.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/one_failure_keeps_going_dynamic_tests.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_gtest_memory_asan_no_lsan.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_local_isolated_script_test_with_passed_json_results.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/build_dynamic_isolated_script_test.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect/api.py
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/v8_roll_bisect.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect/example.expected/no_values.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/buildnumber_zero.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_passed_with_bad_retcode_isolated_script_test.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_passed_isolated_script_test_with_swarming_failure.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/chromium_webkit_revision_chromium.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_isolated_script_test_win_non_gpu.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/ios/example.expected/infra_failure.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/gathering_references_no_values.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_serialized_gtests.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect/example.expected/basic_buildbot_bisect.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/failed_build_inconclusive_1.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/chromium_webkit_crash.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_local_isolated_script_test_with_custom_results_handler.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_isolated_chartjson_test_disabled.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/ios/example.expected/test_failure.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/chromium/example.expected/basic_out_dir.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_script_test_failure.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_local_isolated_script_test_with_corrupt_json_results.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/failed_build.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/findit/chromium/preemptive_bot_update.expected/win.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_local_isolated_script_test_with_failed_json_results.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/chromium_checkout/__init__.py
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium_trybot.expected/analyze_webkit.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_passed_isolated_script_perf_test_no_chartjson.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/chromium.expected/tsan.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/no_values.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/ios/example.expected/is_debug_missing.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/basic_resource_sizes_bisect.json
[modify] https://crrev.com/11d9ab91893e707116b8cdb090c31bfb7587897b/scripts/slave/recipes/webrtc/libfuzzer.expected/full_tryserver_webrtc_linux_libfuzzer_r

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/577ed8c48dcad41653d0559a119abbb84f461afe

commit 577ed8c48dcad41653d0559a119abbb84f461afe
Author: Dan Jacques <dnj@chromium.org>
Date: Mon May 08 18:10:01 2017

remote_run: Decouple canary from Kitchen.

Decouple canary configuration from Kitchen configuration. This allows
canarying Recipes/Kitchen packages independently from the decision about
whether or not to actually use Kitchen. Masters that are considered
canary masters are tracked in a separate list.

Allow Kitchen configuration to be expressed through blacklists in
addition to whitelists. The goal of the Kitchen experiment is to migrate
builders over to Kitchen and, if successful, not have them migrate back.
On some large masters, this can be better expressed through a blacklist
of builders that don't work (to burn down) as opposed to a whitelist of
builders that do work.

BUG= chromium:694911 
TEST=unit

Change-Id: I4d93aea7ab482cd27760f884bb2175b14ec52c67
Reviewed-on: https://chromium-review.googlesource.com/498709
Commit-Queue: Daniel Jacques <dnj@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/577ed8c48dcad41653d0559a119abbb84f461afe/scripts/slave/remote_run.py
[modify] https://crrev.com/577ed8c48dcad41653d0559a119abbb84f461afe/scripts/slave/unittests/remote_run_test.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/577ed8c48dcad41653d0559a119abbb84f461afe

commit 577ed8c48dcad41653d0559a119abbb84f461afe
Author: Dan Jacques <dnj@chromium.org>
Date: Mon May 08 18:10:01 2017

remote_run: Decouple canary from Kitchen.

Decouple canary configuration from Kitchen configuration. This allows
canarying Recipes/Kitchen packages independently from the decision about
whether or not to actually use Kitchen. Masters that are considered
canary masters are tracked in a separate list.

Allow Kitchen configuration to be expressed through blacklists in
addition to whitelists. The goal of the Kitchen experiment is to migrate
builders over to Kitchen and, if successful, not have them migrate back.
On some large masters, this can be better expressed through a blacklist
of builders that don't work (to burn down) as opposed to a whitelist of
builders that do work.

BUG= chromium:694911 
TEST=unit

Change-Id: I4d93aea7ab482cd27760f884bb2175b14ec52c67
Reviewed-on: https://chromium-review.googlesource.com/498709
Commit-Queue: Daniel Jacques <dnj@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/577ed8c48dcad41653d0559a119abbb84f461afe/scripts/slave/remote_run.py
[modify] https://crrev.com/577ed8c48dcad41653d0559a119abbb84f461afe/scripts/slave/unittests/remote_run_test.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/577ed8c48dcad41653d0559a119abbb84f461afe

commit 577ed8c48dcad41653d0559a119abbb84f461afe
Author: Dan Jacques <dnj@chromium.org>
Date: Mon May 08 18:10:01 2017

remote_run: Decouple canary from Kitchen.

Decouple canary configuration from Kitchen configuration. This allows
canarying Recipes/Kitchen packages independently from the decision about
whether or not to actually use Kitchen. Masters that are considered
canary masters are tracked in a separate list.

Allow Kitchen configuration to be expressed through blacklists in
addition to whitelists. The goal of the Kitchen experiment is to migrate
builders over to Kitchen and, if successful, not have them migrate back.
On some large masters, this can be better expressed through a blacklist
of builders that don't work (to burn down) as opposed to a whitelist of
builders that do work.

BUG= chromium:694911 
TEST=unit

Change-Id: I4d93aea7ab482cd27760f884bb2175b14ec52c67
Reviewed-on: https://chromium-review.googlesource.com/498709
Commit-Queue: Daniel Jacques <dnj@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>

[modify] https://crrev.com/577ed8c48dcad41653d0559a119abbb84f461afe/scripts/slave/remote_run.py
[modify] https://crrev.com/577ed8c48dcad41653d0559a119abbb84f461afe/scripts/slave/unittests/remote_run_test.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/6fa4d503d7ef77a951b446ca01b5b18a3c9fb79c

commit 6fa4d503d7ef77a951b446ca01b5b18a3c9fb79c
Author: Dan Jacques <dnj@chromium.org>
Date: Tue May 09 16:17:43 2017

remote_run: promote Kitchen canary to stable.

This bumps the Kitchen version and rolls canary PYTHNOPATH behavior into
default behavior. This shouldn't have an impact on upstream, since the
current "stable" pin already has (as a bug) this PYTHONPATH behavior.

BUG= chromium:694911 
TEST=canary

Change-Id: I33397e8354b93dd38ec74d149e2953f67a73bb8e
Reviewed-on: https://chromium-review.googlesource.com/500016
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Commit-Queue: Daniel Jacques <dnj@chromium.org>

[modify] https://crrev.com/6fa4d503d7ef77a951b446ca01b5b18a3c9fb79c/scripts/slave/remote_run.py
[modify] https://crrev.com/6fa4d503d7ef77a951b446ca01b5b18a3c9fb79c/scripts/slave/unittests/remote_run_test.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/363c91e87561385daf733cd30aa1a4391dd249ee

commit 363c91e87561385daf733cd30aa1a4391dd249ee
Author: Dan Jacques <dnj@chromium.org>
Date: Wed May 10 00:46:10 2017

remote_run: Bump canary Kitchen version.

BUG= chromium:694911 
TEST=None
TBR=nodir@chromium.org

Change-Id: Ibe40dcf51d38b99d3e9d85b9d76d76ac10d1db55
Reviewed-on: https://chromium-review.googlesource.com/501230
Reviewed-by: Daniel Jacques <dnj@chromium.org>
Commit-Queue: Daniel Jacques <dnj@chromium.org>

[modify] https://crrev.com/363c91e87561385daf733cd30aa1a4391dd249ee/scripts/slave/remote_run.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/92c859f50299571b9ed2c2d30e5ef9b3c17f9cca

commit 92c859f50299571b9ed2c2d30e5ef9b3c17f9cca
Author: Dan Jacques <dnj@chromium.org>
Date: Wed May 10 02:17:50 2017

remote_run: Roll fixed Kitchen.

Roll fixed Kitchen to properly propagate return codes.

Include "chromium.swarm" waterfall in canary list.

BUG= chromium:694911 
TEST=canary
  - This version has had a pass on canary waterfalls without issue.
TBR=nodir@chromium.org

Change-Id: If96ce0debb4dc66c3689c15577aa63a7ed0d380b
Reviewed-on: https://chromium-review.googlesource.com/500891
Reviewed-by: Daniel Jacques <dnj@chromium.org>
Commit-Queue: Daniel Jacques <dnj@chromium.org>

[modify] https://crrev.com/92c859f50299571b9ed2c2d30e5ef9b3c17f9cca/scripts/slave/remote_run.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/e0f67109eb83c34776076b1ef5072c4cb94a39b3

commit e0f67109eb83c34776076b1ef5072c4cb94a39b3
Author: Dan Jacques <dnj@chromium.org>
Date: Fri May 12 19:16:59 2017

remote_run: Enable Kitchen for experimental.

Enable Kitchen for experimental CQ builders. This should have no
production impact, since these builders are non-enforcing.

BUG= chromium:694911 
TEST=None
R=iannucci@chromium.org, nodir@chromium.org

Change-Id: I8976c9082152163e1c95c592ef51de01bedf191a
Reviewed-on: https://chromium-review.googlesource.com/505171
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Daniel Jacques <dnj@chromium.org>

[modify] https://crrev.com/e0f67109eb83c34776076b1ef5072c4cb94a39b3/scripts/slave/remote_run.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/53ae1cc975a30a8daae67c5471b0e8fe66554cbc

commit 53ae1cc975a30a8daae67c5471b0e8fe66554cbc
Author: Dan Jacques <dnj@chromium.org>
Date: Fri May 12 19:44:26 2017

Opt-in Foundations team members to Kitchen.

All jobs initialted by accounts belonging to the opt-in list will
automatically run with canary / Kitchen configurations.

BUG= chromium:694911 
TEST=unit
R=iannucci@chromium.org

Change-Id: Ia0fb6fd9f519f9829355602ea09cdebd96f12802
Reviewed-on: https://chromium-review.googlesource.com/505174
Commit-Queue: Daniel Jacques <dnj@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

[modify] https://crrev.com/53ae1cc975a30a8daae67c5471b0e8fe66554cbc/scripts/slave/remote_run.py
[modify] https://crrev.com/53ae1cc975a30a8daae67c5471b0e8fe66554cbc/scripts/slave/unittests/remote_run_test.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/9f7d7ed44c3a4622b6b09013bb6e8a322c942071

commit 9f7d7ed44c3a4622b6b09013bb6e8a322c942071
Author: Daniel Jacques <dnj@chromium.org>
Date: Fri May 12 20:10:00 2017

Revert "Opt-in Foundations team members to Kitchen."

This reverts commit 53ae1cc975a30a8daae67c5471b0e8fe66554cbc.

Reason for revert: Unicode

Original change's description:
> Opt-in Foundations team members to Kitchen.
> 
> All jobs initialted by accounts belonging to the opt-in list will
> automatically run with canary / Kitchen configurations.
> 
> BUG= chromium:694911 
> TEST=unit
> R=​iannucci@chromium.org
> 
> Change-Id: Ia0fb6fd9f519f9829355602ea09cdebd96f12802
> Reviewed-on: https://chromium-review.googlesource.com/505174
> Commit-Queue: Daniel Jacques <dnj@chromium.org>
> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
> 

TBR=iannucci@chromium.org,dnj@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= chromium:694911 

Change-Id: I9055114fcaa87cf638d1d19e05a318704a7940c8
Reviewed-on: https://chromium-review.googlesource.com/505177
Reviewed-by: Daniel Jacques <dnj@chromium.org>
Commit-Queue: Daniel Jacques <dnj@chromium.org>

[modify] https://crrev.com/9f7d7ed44c3a4622b6b09013bb6e8a322c942071/scripts/slave/remote_run.py
[modify] https://crrev.com/9f7d7ed44c3a4622b6b09013bb6e8a322c942071/scripts/slave/unittests/remote_run_test.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/0a06a7bb858fc1a4e521c6b26a9f8d7679385e6e

commit 0a06a7bb858fc1a4e521c6b26a9f8d7679385e6e
Author: Dan Jacques <dnj@chromium.org>
Date: Fri May 12 20:28:38 2017

Opt-in Foundations team members to Kitchen.

All jobs initialted by accounts belonging to the opt-in list will
automatically run with canary / Kitchen configurations.

BUG= chromium:694911 
TEST=unit
R=iannucci@chromium.org

Change-Id: I2d387250d711b863799e456d0307b01109bd123c
Reviewed-on: https://chromium-review.googlesource.com/505449
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

[modify] https://crrev.com/0a06a7bb858fc1a4e521c6b26a9f8d7679385e6e/scripts/slave/remote_run.py
[modify] https://crrev.com/0a06a7bb858fc1a4e521c6b26a9f8d7679385e6e/scripts/slave/unittests/remote_run_test.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/384957bd4425660fb818f85f6225778bdf8db1fc

commit 384957bd4425660fb818f85f6225778bdf8db1fc
Author: Dan Jacques <dnj@chromium.org>
Date: Fri May 12 22:23:53 2017

Enable remote run passthrough.

Make it so opt-in users and specific builders on specific waterfalls
using "annotated_run" can passthrough their execution to "remote_run"
instead. This offers a soft and versatile field to test Kitchen and
remote_run on builder.

BUG= chromium:694911 
TEST=None

Change-Id: Icd42733c7517272113e4b7bc6fb75fd99ef307c1
Reviewed-on: https://chromium-review.googlesource.com/505548
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

[modify] https://crrev.com/384957bd4425660fb818f85f6225778bdf8db1fc/scripts/slave/unittests/annotated_run_test.py
[modify] https://crrev.com/384957bd4425660fb818f85f6225778bdf8db1fc/scripts/slave/annotated_run.py
[modify] https://crrev.com/384957bd4425660fb818f85f6225778bdf8db1fc/scripts/slave/remote_run.py
[modify] https://crrev.com/384957bd4425660fb818f85f6225778bdf8db1fc/scripts/slave/unittests/remote_run_test.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/22da36e95697d92463b1b8ea002f7c4b8a4de41a

commit 22da36e95697d92463b1b8ea002f7c4b8a4de41a
Author: Dan Jacques <dnj@chromium.org>
Date: Sun May 21 17:51:48 2017

remote_run: Remove BuildBot Python path injection.

Remove legacy BuildBot Python path injection for canary runs. Now that
all "tools/build" recipes have been converted to bootstrap their tool
invocations through "runit.py", this should work.

BUG= chromium:694911 
TEST=unit
R=iannucci@chromium.org, nodir@chromium.org

Change-Id: I1efaa98cb53582f3f0abb46d53ed4ebc36ba1217
Reviewed-on: https://chromium-review.googlesource.com/508440
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Daniel Jacques <dnj@chromium.org>

[modify] https://crrev.com/22da36e95697d92463b1b8ea002f7c4b8a4de41a/scripts/slave/remote_run.py
[modify] https://crrev.com/22da36e95697d92463b1b8ea002f7c4b8a4de41a/scripts/slave/unittests/remote_run_test.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/22da36e95697d92463b1b8ea002f7c4b8a4de41a

commit 22da36e95697d92463b1b8ea002f7c4b8a4de41a
Author: Dan Jacques <dnj@chromium.org>
Date: Sun May 21 17:51:48 2017

remote_run: Remove BuildBot Python path injection.

Remove legacy BuildBot Python path injection for canary runs. Now that
all "tools/build" recipes have been converted to bootstrap their tool
invocations through "runit.py", this should work.

BUG= chromium:694911 
TEST=unit
R=iannucci@chromium.org, nodir@chromium.org

Change-Id: I1efaa98cb53582f3f0abb46d53ed4ebc36ba1217
Reviewed-on: https://chromium-review.googlesource.com/508440
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Daniel Jacques <dnj@chromium.org>

[modify] https://crrev.com/22da36e95697d92463b1b8ea002f7c4b8a4de41a/scripts/slave/remote_run.py
[modify] https://crrev.com/22da36e95697d92463b1b8ea002f7c4b8a4de41a/scripts/slave/unittests/remote_run_test.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/ec28769396a1c8190760f0708b98343ac4be8367

commit ec28769396a1c8190760f0708b98343ac4be8367
Author: Dan Jacques <dnj@chromium.org>
Date: Wed May 24 20:17:27 2017

[remote_run] Remove Kitchen PYTHONPATH injection.

Remove PYTHONPATH injection hack from Kitchen invocations. Now that all
tools should be running through "runit.py" bootstrap, this hack is no
longer necessary.

This will only impact Kitchen-enabled waterfalls/builders that were not
previously running a canary configuration.

BUG= chromium:694911 
TEST=canary
R=iannucci@chromium.org, nodir@chromium.org

Change-Id: I304c532dd377006989dfb3e801bcde14c43d1292
Reviewed-on: https://chromium-review.googlesource.com/510584
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Daniel Jacques <dnj@chromium.org>

[modify] https://crrev.com/ec28769396a1c8190760f0708b98343ac4be8367/scripts/slave/remote_run.py
[modify] https://crrev.com/ec28769396a1c8190760f0708b98343ac4be8367/scripts/slave/unittests/remote_run_test.py

Note that this is still only rolled out to a minimal number of builders, it's not really fixed.