New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 694902 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature

Blocking:
issue 679838


Show other hotlists

Hotlists containing this issue:
style-dev-current


Sign in to add a comment

Metrics for Custom Properties

Project Member Reported by shans@chromium.org, Feb 22 2017

Issue description

Feature description:

Add tracing metrics for custom properties, so the number of custom property operations can be tracked at the updateStyle level.

design doc: https://docs.google.com/document/d/1pW-_Q_DM80iHhj8fkDY517DrMx6ov7QvlBuRKcYhoXU/edit#
 

Comment 1 by shans@chromium.org, Feb 22 2017

Labels: Pri-3 Type-Feature

Comment 2 by shans@chromium.org, Feb 22 2017

Components: Blink>CSS
Labels: Update-Quarterly
Labels: -Update-Quarterly Update-Monthly
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e58eb32c10cbbdd164b40ba58c5affb2a4140490

commit e58eb32c10cbbdd164b40ba58c5affb2a4140490
Author: shans <shans@chromium.org>
Date: Wed Mar 01 06:18:54 2017

Add "customPropertiesApplied" metric to StyleResolverStats.

To see this in traces you need to opt into the blink_style
category. This metric will then indicate how many custom
properties are applied for each call to updateStyle.

BUG= 694902 

Review-Url: https://codereview.chromium.org/2707113003
Cr-Commit-Position: refs/heads/master@{#453862}

[modify] https://crrev.com/e58eb32c10cbbdd164b40ba58c5affb2a4140490/third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.cpp
[modify] https://crrev.com/e58eb32c10cbbdd164b40ba58c5affb2a4140490/third_party/WebKit/Source/core/css/resolver/StyleResolverStats.cpp
[modify] https://crrev.com/e58eb32c10cbbdd164b40ba58c5affb2a4140490/third_party/WebKit/Source/core/css/resolver/StyleResolverStats.h

Blocking: 679838

Comment 7 by shans@chromium.org, May 10 2017

No progress this month.

Comment 8 by shans@chromium.org, Jun 10 2017

NPTM

Comment 9 by shans@chromium.org, Jul 26 2017

NPTM

Comment 10 by shans@chromium.org, Nov 29 2017

Labels: -Update-Monthly

Comment 11 by e...@chromium.org, Feb 5 2018

Cc: shans@chromium.org
Owner: ----
Status: WontFix (was: Assigned)
Given recent team changes we're unlikely to get to this any time soon.

Sign in to add a comment