New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 694901 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

factory: Eliminate unnecessary test list options

Project Member Reported by hungte@chromium.org, Feb 22 2017

Issue description

Background: issue http://crosbug.com/p/63171.

Currently most projects will try to create their initial factory board drop (chromeos-factory-board) by reference board, or previous generation of platform.

However this creates many legacy, or rarely used options that people are not aware of what it's planned for.

For example, 63171 occurred because kern_a_device and root_device for reef were changed from release image slots (mmcblk0p4 mmcblk0p5) to test image slots (mmcblk1p2 and mmcblk1p3).

Also, there are lots of properties like main_temp_sensor_index and temp_sensors_to_test that almost none of the boards really need them.

This creates an interesting question - should we put "default for test params" in pytests, or test list options, or individual test items?

Since we already have so many boards, my recommendation is to leave most options to pytest, and only keeping needed changes (i.e., those you can find difference between different project overlays) in test list.

We need a full clean up for this.
 

Comment 1 by hungte@chromium.org, Jul 14 2017

Cc: -phoenixshen@chromium.org -pihsun@chromium.org -yllin@chromium.org -stimim@chromium.org -shunhsingou@chromium.org chromeos-factory-eng@chromium.org
Owner: pihsun@chromium.org
Status: Assigned (was: Untriaged)
Assign to latest OEM project owner.
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/eb544cba16513d30502f071972c34e96492b8f86

commit eb544cba16513d30502f071972c34e96492b8f86
Author: Peter Shih <pihsun@chromium.org>
Date: Tue Aug 08 13:47:52 2017

test_lists: Refactor test list to use JSON.

Refactor generic test list to use JSON test list format, and move most
definitions from private overlays to generic test list, so we can share
most definitions across projects.

Also cleaned up some unused generic_* test lists and unused options in
test lists.

CQ-DEPEND=CL:597562
BUG= chromium:738969 , chromium:694901 
TEST=make test
TEST=manually on DUT

Change-Id: I9b1bd5c2fa1fab90675c27b97f8e92456b31a4ad
Reviewed-on: https://chromium-review.googlesource.com/559028
Commit-Ready: Pi-Hsun Shih <pihsun@chromium.org>
Tested-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Pi-Hsun Shih <pihsun@chromium.org>

[add] https://crrev.com/eb544cba16513d30502f071972c34e96492b8f86/py/test/test_lists/generic_run_in.test_list.json
[delete] https://crrev.com/fa415e6867dbe65bb6b1ecde975f61bf428cceb3/py/test/test_lists/generic_control_run.py
[delete] https://crrev.com/fa415e6867dbe65bb6b1ecde975f61bf428cceb3/py/test/test_lists/firmware_stress.py
[delete] https://crrev.com/fa415e6867dbe65bb6b1ecde975f61bf428cceb3/py/test/test_lists/generic_fatp.py
[modify] https://crrev.com/eb544cba16513d30502f071972c34e96492b8f86/py/test/test_lists/manager.py
[delete] https://crrev.com/fa415e6867dbe65bb6b1ecde975f61bf428cceb3/py/test/test_lists/generic_diagnostic.py
[delete] https://crrev.com/fa415e6867dbe65bb6b1ecde975f61bf428cceb3/py/test/test_lists/generic_run_in.py
[add] https://crrev.com/eb544cba16513d30502f071972c34e96492b8f86/py/test/test_lists/generic_grt.test_list.json
[add] https://crrev.com/eb544cba16513d30502f071972c34e96492b8f86/py/test/test_lists/generic_common.test_list.json
[add] https://crrev.com/eb544cba16513d30502f071972c34e96492b8f86/py/test/test_lists/disable_factory_server.test_list.json
[add] https://crrev.com/eb544cba16513d30502f071972c34e96492b8f86/py/test/test_lists/generic_fat.test_list.json
[delete] https://crrev.com/fa415e6867dbe65bb6b1ecde975f61bf428cceb3/py/test/test_lists/generic.py
[delete] https://crrev.com/fa415e6867dbe65bb6b1ecde975f61bf428cceb3/py/test/test_lists/generic_experiment.py
[add] https://crrev.com/eb544cba16513d30502f071972c34e96492b8f86/py/test/test_lists/generic_smt.test_list.json
[add] https://crrev.com/eb544cba16513d30502f071972c34e96492b8f86/py/test/test_lists/generic_rrt.test_list.json
[delete] https://crrev.com/fa415e6867dbe65bb6b1ecde975f61bf428cceb3/py/test/test_lists/generic_tsab.py
[delete] https://crrev.com/fa415e6867dbe65bb6b1ecde975f61bf428cceb3/py/test/test_lists/generic_smt.py
[add] https://crrev.com/eb544cba16513d30502f071972c34e96492b8f86/py/test/test_lists/generic_fft.test_list.json
[delete] https://crrev.com/fa415e6867dbe65bb6b1ecde975f61bf428cceb3/py/test/test_lists/e2e_test.py
[add] https://crrev.com/eb544cba16513d30502f071972c34e96492b8f86/py/test/test_lists/generic_main.test_list.json
[modify] https://crrev.com/eb544cba16513d30502f071972c34e96492b8f86/po/zh-CN.po
[modify] https://crrev.com/eb544cba16513d30502f071972c34e96492b8f86/py/test/test_lists/station_based_test_list.py
[add] https://crrev.com/eb544cba16513d30502f071972c34e96492b8f86/py/test/test_lists/station_based.test_list.json
[delete] https://crrev.com/fa415e6867dbe65bb6b1ecde975f61bf428cceb3/py/test/test_lists/generic_rrt.py
[delete] https://crrev.com/fa415e6867dbe65bb6b1ecde975f61bf428cceb3/py/test/test_lists/generic_vswr.py
[delete] https://crrev.com/fa415e6867dbe65bb6b1ecde975f61bf428cceb3/py/test/test_lists/firmware_stress_generic.py
[delete] https://crrev.com/fa415e6867dbe65bb6b1ecde975f61bf428cceb3/py/test/test_lists/generic_grt.py

Comment 3 by hungte@chromium.org, Sep 26 2017

Status: Fixed (was: Assigned)
I think we've eliminated most of extra options in the migration of JSON test list.

Comment 4 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 5 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment