New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 694885 link

Starred by 1 user
Status: Fixed
Owner:
█ dsansome@chromium.org
Last visit > 30 days ago
Closed: May 2017
Cc:
█ dsansome@chromium.org
ukai@chromium.org
tikuta@chromium.org
yyanagisawa@chromium.org
shinyak@chromium.org
sque@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

ValueError: invalid literal for long() with base 10: 'clobber'

Project Member Reported by shinyak@chromium.org, Feb 22 2017 
https://build.chromium.org/p/tryserver.webrtc/builders/ios_rel/builds/21812/steps/postprocess_for_goma.upload_log/logs/stdio

/usr/bin/python /opt/infra-python/run.py infra.tools.send_ts_mon_values --verbose --ts-mon-target-type task --ts-mon-task-service-name goma-client --ts-mon-task-job-name default --counter "{\"status\": \"success\", \"slave\": \"vm1033-m4\", \"name\": \"goma/status\", \"builder\": \"ios_rel\", \"clobber\": 0, \"master\": \"tryserver.webrtc\", \"value\": 1, \"os\": \"mac\", \"start_time\": 1487709694}" --counter "{\"clobber\": 0, \"master\": \"tryserver.webrtc\", \"name\": \"goma/failure\", \"ping_status_code\": 200, \"slave\": \"vm1033-m4\", \"builder\": \"ios_rel\", \"os\": \"mac\", \"start_time\": 1487709694, \"value\": 1, \"result\": \"exception\"}"
<Thread(Thread-4, started 123145306509312)> ProcessRead: proc.stdout finished.
<Thread(Thread-4, started 123145306509312)> ProcessRead: cleaning up.
<Thread(Thread-6, started daemon 123145310715904)> TimedFlush: Finished
<Thread(Thread-4, started 123145306509312)> ProcessRead: finished.
Execution of send_ts_mon_values failed with code 1
Traceback (most recent call last):
  File "/opt/infra-python/run.py", line 29, in <module>
    sys.exit(run_helper.run_py_main(sys.argv[1:], RUNPY_PATH, ENV_PATH, 'infra'))
  File "/opt/infra-python/bootstrap/run_helper.py", line 125, in run_py_main
    runpy.run_module(args[0], run_name='__main__', alter_sys=True)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/runpy.py", line 176, in run_module
    fname, loader, pkg_name)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/runpy.py", line 82, in _run_module_code
    mod_name, mod_fname, mod_loader, pkg_name)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/runpy.py", line 72, in _run_code
    exec code in run_globals
  File "/opt/infra-python/.cipd/pkgs/infra_python_mac-amd64-mac10_11_rck2KKgUIG/3443d6c550319891852933d8cbdd57b9e12efedf/infra/tools/send_ts_mon_values/__main__.py", line 13, in <module>
    sys.exit(common.main(sys.argv[1:]))
  File "/opt/infra-python/.cipd/pkgs/infra_python_mac-amd64-mac10_11_rck2KKgUIG/3443d6c550319891852933d8cbdd57b9e12efedf/infra/tools/send_ts_mon_values/common.py", line 307, in main
    set_metrics(arg, metric)
  File "/opt/infra-python/.cipd/pkgs/infra_python_mac-amd64-mac10_11_rck2KKgUIG/3443d6c550319891852933d8cbdd57b9e12efedf/infra/tools/send_ts_mon_values/common.py", line 168, in set_metrics
    return [set_metric(md, metric_type) for md in collapsed_metrics if md]
  File "/opt/infra-python/.cipd/pkgs/infra_python_mac-amd64-mac10_11_rck2KKgUIG/3443d6c550319891852933d8cbdd57b9e12efedf/infra/tools/send_ts_mon_values/common.py", line 252, in set_metric
    field_spec.append(field_ctor(value_cast(name)))
ValueError: invalid literal for long() with base 10: 'clobber'

Comment 1 by shinyak@chromium.org, Feb 22 2017 

By the way, why is this step green?
Filed a new bug for that; Issue 694886

Comment 2 by shinyak@chromium.org, Feb 22 2017

Owner: shinyak@chromium.org
clobber should be string :'(
I'll fix it.

Comment 3 by shinyak@chromium.org, Feb 22 2017 

Hmm, then why ping_status_code 200 is OK?

Comment 4 by yyanagisawa@chromium.org, Feb 22 2017

Cc: dsansome@chromium.org
Implementation seems to be chagned recently,
https://chromium.googlesource.com/infra/infra.git/+blame/master/infra/tools/send_ts_mon_values/common.py#233

Comment 6 by yyanagisawa@chromium.org, Feb 22 2017

Labels: -Pri-3 Pri-1
I think ts_mon result on all builders gone.  Let me change priority.

Comment 7 by yyanagisawa@chromium.org, Feb 22 2017

Labels: OS-All

Comment 8 by dsansome@chromium.org, Feb 22 2017

Owner: dsansome@chromium.org
Status: Started (was: Untriaged)
Oops this is my bug in send_ts_mon_values.  value_cast(name) should be value_cast(value).  I'll fix it.

Comment 9 by dsansome@chromium.org, Feb 22 2017 

Actually no, I misread, this is the name of the field, I'm not sure why I'm using the value cast at all here...
Project Member

Comment 10 by bugdroid1@chromium.org, Feb 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/511ea506247df6ee64197344192cb35a5fb80260

commit 511ea506247df6ee64197344192cb35a5fb80260
Author: David Sansome <dsansome@chromium.org>
Date: Wed Feb 22 04:54:15 2017

Oops, fix bad field value casts in send_ts_mon_values

BUG= 694885 

Change-Id: I89f21702fc9485db06a412bd701d857d49901509
Reviewed-on: https://chromium-review.googlesource.com/446196
Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com>
Commit-Queue: Dave Sansome <dsansome@chromium.org>

[modify] https://crrev.com/511ea506247df6ee64197344192cb35a5fb80260/infra/tools/send_ts_mon_values/common.py

Comment 11 by dsansome@chromium.org, Feb 22 2017

Status: Fixed (was: Started)

Comment 12 by yyanagisawa@chromium.org, Mar 3 2017

Status: Available (was: Fixed)
It seems not fixed yet.
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_android/builds/220537/steps/preprocess_for_goma.upload_goma_start_failed_logs/logs/stdio
Execution of send_ts_mon_values failed with code 1
Traceback (most recent call last):
  File "/opt/infra-python/run.py", line 29, in <module>
    sys.exit(run_helper.run_py_main(sys.argv[1:], RUNPY_PATH, ENV_PATH, 'infra'))
  File "/opt/infra-python/bootstrap/run_helper.py", line 125, in run_py_main
    runpy.run_module(args[0], run_name='__main__', alter_sys=True)
  File "/usr/lib/python2.7/runpy.py", line 176, in run_module
    fname, loader, pkg_name)
  File "/usr/lib/python2.7/runpy.py", line 82, in _run_module_code
    mod_name, mod_fname, mod_loader, pkg_name)
  File "/usr/lib/python2.7/runpy.py", line 72, in _run_code
    exec code in run_globals
  File "/opt/infra-python/.cipd/pkgs/infra_python_linux-amd64-ubuntu14_04_tap59FFGuW/b297600ab25f61d73f309de224ea66b68cfdda47/infra/tools/send_ts_mon_values/__main__.py", line 13, in <module>
    sys.exit(common.main(sys.argv[1:]))
  File "/opt/infra-python/.cipd/pkgs/infra_python_linux-amd64-ubuntu14_04_tap59FFGuW/b297600ab25f61d73f309de224ea66b68cfdda47/infra/tools/send_ts_mon_values/common.py", line 307, in main
    set_metrics(arg, metric)
  File "/opt/infra-python/.cipd/pkgs/infra_python_linux-amd64-ubuntu14_04_tap59FFGuW/b297600ab25f61d73f309de224ea66b68cfdda47/infra/tools/send_ts_mon_values/common.py", line 168, in set_metrics
    return [set_metric(md, metric_type) for md in collapsed_metrics if md]
  File "/opt/infra-python/.cipd/pkgs/infra_python_linux-amd64-ubuntu14_04_tap59FFGuW/b297600ab25f61d73f309de224ea66b68cfdda47/infra/tools/send_ts_mon_values/common.py", line 252, in set_metric
    field_spec.append(field_ctor(value_cast(name)))
ValueError: invalid literal for long() with base 10: 'clobber'

Comment 13 by shinyak@chromium.org, Mar 3 2017 

:'(

Comment 14 by dsansome@chromium.org, May 3 2017

Status: Fixed (was: Available)
Are you still seeing this?  If so please re-open.
►

Sign in to add a comment