New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 694884 link

Starred by 2 users
Status: Fixed
Owner:
isherman@chromium.org
Closed: Mar 2017
Cc:
█ amineer@chromium.org
█ nyquist@chromium.org
mark@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Feature

Blocked on:
issue 699809
Blocking:
issue 680814


Participants' hotlists:
Android-O-Background-Check


Sign in to add a comment

Use the JobScheduler API for more efficient crash report uploading on Android

Project Member Reported by isherman@chromium.org, Feb 22 2017 
We currently create new Services for uploading crash reports on Android.  We should instead use the JobScheduler API where available, as it is (a) more efficient and (b) provides exponential backoff.

Comment 1 by isherman@chromium.org, Feb 22 2017

Blocking: 680814

Comment 2 by nyquist@chromium.org, Feb 23 2017

Cc: nyquist@chromium.org

Comment 4 by isherman@chromium.org, Feb 28 2017

Cc: mark@chromium.org
+Mark as an FYI
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb2e1fe56fc33bde8b128817988e7b374ea7d1c3

commit cb2e1fe56fc33bde8b128817988e7b374ea7d1c3
Author: isherman <isherman@chromium.org>
Date: Wed Mar 01 08:27:02 2017

[Cleanup] Clean up the MinidumpUploaderImpl code, mostly by updating comments.

BUG= 694884 
TEST=none
R=tobiasjs@chromium.org

Review-Url: https://codereview.chromium.org/2721143002
Cr-Commit-Position: refs/heads/master@{#453881}

[modify] https://crrev.com/cb2e1fe56fc33bde8b128817988e7b374ea7d1c3/android_webview/java/src/org/chromium/android_webview/crash/MinidumpUploaderImpl.java
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/375b5de438487e3fe5b52014a5962822b59f0d19

commit 375b5de438487e3fe5b52014a5962822b59f0d19
Author: isherman <isherman@chromium.org>
Date: Thu Mar 02 21:57:14 2017

[Android Crash Reporting] Componentize MinidumpUploadImpl.java

BUG= 694884 
TEST=compile, android_webview_test_apk
R=gsennton@chromium.org

Review-Url: https://codereview.chromium.org/2709163008
Cr-Commit-Position: refs/heads/master@{#454390}

[modify] https://crrev.com/375b5de438487e3fe5b52014a5962822b59f0d19/android_webview/BUILD.gn
[modify] https://crrev.com/375b5de438487e3fe5b52014a5962822b59f0d19/android_webview/java/src/org/chromium/android_webview/crash/AwMinidumpUploadJobService.java
[add] https://crrev.com/375b5de438487e3fe5b52014a5962822b59f0d19/android_webview/java/src/org/chromium/android_webview/crash/AwMinidumpUploaderDelegate.java
[modify] https://crrev.com/375b5de438487e3fe5b52014a5962822b59f0d19/android_webview/javatests/src/org/chromium/android_webview/test/crash/MinidumpUploaderTest.java
[modify] https://crrev.com/375b5de438487e3fe5b52014a5962822b59f0d19/components/minidump_uploader/BUILD.gn
[add] https://crrev.com/375b5de438487e3fe5b52014a5962822b59f0d19/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/MinidumpUploaderDelegate.java
[rename] https://crrev.com/375b5de438487e3fe5b52014a5962822b59f0d19/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/MinidumpUploaderImpl.java
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/37716386769b230a22b267a9789d68946b094552

commit 37716386769b230a22b267a9789d68946b094552
Author: isherman <isherman@chromium.org>
Date: Fri Mar 03 00:24:48 2017

[Android Crash Reporting] Mark mCancelUpload as volatile.

It is otherwise theoretically possible for the compiler to hoist the variable
read out of the loop, which would cause updates sent by the writing thread to
never be seen.

BUG= 694884 
TEST=none
R=tobiasjs@chromium.org

Review-Url: https://codereview.chromium.org/2721023004
Cr-Commit-Position: refs/heads/master@{#454451}

[modify] https://crrev.com/37716386769b230a22b267a9789d68946b094552/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/MinidumpUploaderImpl.java
Project Member

Comment 9 by bugdroid1@chromium.org, Mar 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b444f201a0e88282af902010b5c29c808c4fadc

commit 5b444f201a0e88282af902010b5c29c808c4fadc
Author: isherman <isherman@chromium.org>
Date: Wed Mar 08 09:14:30 2017

[Cleanup] Run git cl format on minidump uploader files.

BUG= 694884 
TEST=none
R=mariakhomenko@chromium.org

Review-Url: https://codereview.chromium.org/2735133003
Cr-Commit-Position: refs/heads/master@{#455412}

[modify] https://crrev.com/5b444f201a0e88282af902010b5c29c808c4fadc/chrome/android/java/src/org/chromium/chrome/browser/DeferredStartupHandler.java
[modify] https://crrev.com/5b444f201a0e88282af902010b5c29c808c4fadc/chrome/android/java/src/org/chromium/chrome/browser/crash/LogcatExtractionCallable.java
[modify] https://crrev.com/5b444f201a0e88282af902010b5c29c808c4fadc/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpDirectoryObserver.java
[modify] https://crrev.com/5b444f201a0e88282af902010b5c29c808c4fadc/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpPreparationCallable.java
[modify] https://crrev.com/5b444f201a0e88282af902010b5c29c808c4fadc/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpPreparationService.java
[modify] https://crrev.com/5b444f201a0e88282af902010b5c29c808c4fadc/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadService.java
[modify] https://crrev.com/5b444f201a0e88282af902010b5c29c808c4fadc/chrome/android/javatests/src/org/chromium/chrome/browser/crash/LogcatExtractionCallableTest.java
[modify] https://crrev.com/5b444f201a0e88282af902010b5c29c808c4fadc/chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadServiceTest.java
[modify] https://crrev.com/5b444f201a0e88282af902010b5c29c808c4fadc/chrome/android/junit/src/org/chromium/chrome/browser/crash/LogcatExtractionCallableUnitTest.java
[modify] https://crrev.com/5b444f201a0e88282af902010b5c29c808c4fadc/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/CrashFileManager.java
[modify] https://crrev.com/5b444f201a0e88282af902010b5c29c808c4fadc/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/MinidumpUploadCallable.java
[modify] https://crrev.com/5b444f201a0e88282af902010b5c29c808c4fadc/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/util/HttpURLConnectionFactoryImpl.java

Comment 10 by isherman@chromium.org, Mar 9 2017

Blockedon: 699809
Project Member

Comment 11 by bugdroid1@chromium.org, Mar 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a9a8f4e062bd1c72c3b511de3c41611e24b7949e

commit a9a8f4e062bd1c72c3b511de3c41611e24b7949e
Author: isherman <isherman@chromium.org>
Date: Thu Mar 09 09:05:41 2017

[Android Crash Reporting] Simplify crash report upload code.

In particular: run the code to extract logcat output within the context
of the main Chrome process/service, rather than kicking off the work to
a pair of background services.  Moreover, dramatically simplify the
MetricsUploadService code: remove all but one of the intents that it
handles.

BUG= 694884 
R=mariakhomenko@chromium.org

Review-Url: https://codereview.chromium.org/2727573004
Cr-Commit-Position: refs/heads/master@{#455704}

[modify] https://crrev.com/a9a8f4e062bd1c72c3b511de3c41611e24b7949e/chrome/android/java/AndroidManifest.xml
[modify] https://crrev.com/a9a8f4e062bd1c72c3b511de3c41611e24b7949e/chrome/android/java/src/org/chromium/chrome/browser/DeferredStartupHandler.java
[rename] https://crrev.com/a9a8f4e062bd1c72c3b511de3c41611e24b7949e/chrome/android/java/src/org/chromium/chrome/browser/crash/LogcatExtractionRunnable.java
[delete] https://crrev.com/2f6c9f2a9a793b4b57d3b52fc59e7545dffceb65/chrome/android/java/src/org/chromium/chrome/browser/crash/LogcatExtractionService.java
[modify] https://crrev.com/a9a8f4e062bd1c72c3b511de3c41611e24b7949e/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpDirectoryObserver.java
[add] https://crrev.com/a9a8f4e062bd1c72c3b511de3c41611e24b7949e/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpLogcatPrepender.java
[delete] https://crrev.com/2f6c9f2a9a793b4b57d3b52fc59e7545dffceb65/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpPreparationCallable.java
[delete] https://crrev.com/2f6c9f2a9a793b4b57d3b52fc59e7545dffceb65/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpPreparationService.java
[modify] https://crrev.com/a9a8f4e062bd1c72c3b511de3c41611e24b7949e/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadService.java
[modify] https://crrev.com/a9a8f4e062bd1c72c3b511de3c41611e24b7949e/chrome/android/java_sources.gni
[delete] https://crrev.com/2f6c9f2a9a793b4b57d3b52fc59e7545dffceb65/chrome/android/javatests/src/org/chromium/chrome/browser/crash/LogcatExtractionCallableTest.java
[add] https://crrev.com/a9a8f4e062bd1c72c3b511de3c41611e24b7949e/chrome/android/javatests/src/org/chromium/chrome/browser/crash/LogcatExtractionRunnableTest.java
[modify] https://crrev.com/a9a8f4e062bd1c72c3b511de3c41611e24b7949e/chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadServiceTest.java
[rename] https://crrev.com/a9a8f4e062bd1c72c3b511de3c41611e24b7949e/chrome/android/junit/src/org/chromium/chrome/browser/crash/LogcatExtractionRunnableUnitTest.java
[modify] https://crrev.com/a9a8f4e062bd1c72c3b511de3c41611e24b7949e/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/CrashFileManager.java
[modify] https://crrev.com/a9a8f4e062bd1c72c3b511de3c41611e24b7949e/tools/metrics/histograms/histograms.xml

Comment 12 by isherman@chromium.org, Mar 13 2017

Cc: amineer@chromium.org
Discussed with Alex, will merge the currently committed CLs to M58 today.  There is one more pending CL, which will be merged once it's ready and has had some bake time.
Project Member

Comment 13 by bugdroid1@chromium.org, Mar 13 2017

Labels: merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9394f1af0803a3ac59d8c97996f57813988ee97c

commit 9394f1af0803a3ac59d8c97996f57813988ee97c
Author: Ilya Sherman <isherman@chromium.org>
Date: Mon Mar 13 23:05:43 2017

[Merge to M58] [Cleanup] Run git cl format on minidump uploader files.

BUG= 694884 
TEST=none
R=mariakhomenko@chromium.org

Review-Url: https://codereview.chromium.org/2735133003
Cr-Commit-Position: refs/heads/master@{#455412}
(cherry picked from commit 5b444f201a0e88282af902010b5c29c808c4fadc)

Review-Url: https://codereview.chromium.org/2752493003 .
Cr-Commit-Position: refs/branch-heads/3029@{#171}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/9394f1af0803a3ac59d8c97996f57813988ee97c/chrome/android/java/src/org/chromium/chrome/browser/DeferredStartupHandler.java
[modify] https://crrev.com/9394f1af0803a3ac59d8c97996f57813988ee97c/chrome/android/java/src/org/chromium/chrome/browser/crash/LogcatExtractionCallable.java
[modify] https://crrev.com/9394f1af0803a3ac59d8c97996f57813988ee97c/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpDirectoryObserver.java
[modify] https://crrev.com/9394f1af0803a3ac59d8c97996f57813988ee97c/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpPreparationCallable.java
[modify] https://crrev.com/9394f1af0803a3ac59d8c97996f57813988ee97c/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpPreparationService.java
[modify] https://crrev.com/9394f1af0803a3ac59d8c97996f57813988ee97c/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadService.java
[modify] https://crrev.com/9394f1af0803a3ac59d8c97996f57813988ee97c/chrome/android/javatests/src/org/chromium/chrome/browser/crash/LogcatExtractionCallableTest.java
[modify] https://crrev.com/9394f1af0803a3ac59d8c97996f57813988ee97c/chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadServiceTest.java
[modify] https://crrev.com/9394f1af0803a3ac59d8c97996f57813988ee97c/chrome/android/junit/src/org/chromium/chrome/browser/crash/LogcatExtractionCallableUnitTest.java
[modify] https://crrev.com/9394f1af0803a3ac59d8c97996f57813988ee97c/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/CrashFileManager.java
[modify] https://crrev.com/9394f1af0803a3ac59d8c97996f57813988ee97c/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/MinidumpUploadCallable.java
[modify] https://crrev.com/9394f1af0803a3ac59d8c97996f57813988ee97c/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/util/HttpURLConnectionFactoryImpl.java
Project Member

Comment 14 by bugdroid1@chromium.org, Mar 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02cb7c80b97142fa5b34abea202b7755dcf9e476

commit 02cb7c80b97142fa5b34abea202b7755dcf9e476
Author: Ilya Sherman <isherman@chromium.org>
Date: Mon Mar 13 23:08:13 2017

[Merge to M58] [Android Crash Reporting] Simplify crash report upload code.

In particular: run the code to extract logcat output within the context
of the main Chrome process/service, rather than kicking off the work to
a pair of background services.  Moreover, dramatically simplify the
MetricsUploadService code: remove all but one of the intents that it
handles.

BUG= 694884 
R=mariakhomenko@chromium.org

Review-Url: https://codereview.chromium.org/2727573004
Cr-Commit-Position: refs/heads/master@{#455704}
(cherry picked from commit a9a8f4e062bd1c72c3b511de3c41611e24b7949e)

Review-Url: https://codereview.chromium.org/2748913002 .
Cr-Commit-Position: refs/branch-heads/3029@{#172}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/02cb7c80b97142fa5b34abea202b7755dcf9e476/chrome/android/java/AndroidManifest.xml
[modify] https://crrev.com/02cb7c80b97142fa5b34abea202b7755dcf9e476/chrome/android/java/src/org/chromium/chrome/browser/DeferredStartupHandler.java
[rename] https://crrev.com/02cb7c80b97142fa5b34abea202b7755dcf9e476/chrome/android/java/src/org/chromium/chrome/browser/crash/LogcatExtractionRunnable.java
[delete] https://crrev.com/9394f1af0803a3ac59d8c97996f57813988ee97c/chrome/android/java/src/org/chromium/chrome/browser/crash/LogcatExtractionService.java
[modify] https://crrev.com/02cb7c80b97142fa5b34abea202b7755dcf9e476/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpDirectoryObserver.java
[add] https://crrev.com/02cb7c80b97142fa5b34abea202b7755dcf9e476/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpLogcatPrepender.java
[delete] https://crrev.com/9394f1af0803a3ac59d8c97996f57813988ee97c/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpPreparationCallable.java
[delete] https://crrev.com/9394f1af0803a3ac59d8c97996f57813988ee97c/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpPreparationService.java
[modify] https://crrev.com/02cb7c80b97142fa5b34abea202b7755dcf9e476/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadService.java
[modify] https://crrev.com/02cb7c80b97142fa5b34abea202b7755dcf9e476/chrome/android/java_sources.gni
[delete] https://crrev.com/9394f1af0803a3ac59d8c97996f57813988ee97c/chrome/android/javatests/src/org/chromium/chrome/browser/crash/LogcatExtractionCallableTest.java
[add] https://crrev.com/02cb7c80b97142fa5b34abea202b7755dcf9e476/chrome/android/javatests/src/org/chromium/chrome/browser/crash/LogcatExtractionRunnableTest.java
[modify] https://crrev.com/02cb7c80b97142fa5b34abea202b7755dcf9e476/chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadServiceTest.java
[rename] https://crrev.com/02cb7c80b97142fa5b34abea202b7755dcf9e476/chrome/android/junit/src/org/chromium/chrome/browser/crash/LogcatExtractionRunnableUnitTest.java
[modify] https://crrev.com/02cb7c80b97142fa5b34abea202b7755dcf9e476/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/CrashFileManager.java
[modify] https://crrev.com/02cb7c80b97142fa5b34abea202b7755dcf9e476/tools/metrics/histograms/histograms.xml
Project Member

Comment 15 by bugdroid1@chromium.org, Mar 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a5492dc16ac148bde50b46ca756f95a655fad58

commit 8a5492dc16ac148bde50b46ca756f95a655fad58
Author: isherman <isherman@chromium.org>
Date: Thu Mar 16 22:22:07 2017

[Android Crash Reporting] Allow uploading minidumps via the JobScheduler

The new functionality is guarded behind a Feature.

BUG= 694884 
R=gsennton@chromium.org, mariakhomenko@chromium.org

Review-Url: https://codereview.chromium.org/2737263006
Cr-Commit-Position: refs/heads/master@{#457584}

[modify] https://crrev.com/8a5492dc16ac148bde50b46ca756f95a655fad58/android_webview/BUILD.gn
[modify] https://crrev.com/8a5492dc16ac148bde50b46ca756f95a655fad58/android_webview/java/DEPS
[modify] https://crrev.com/8a5492dc16ac148bde50b46ca756f95a655fad58/android_webview/java/src/org/chromium/android_webview/crash/AwMinidumpUploadJobService.java
[modify] https://crrev.com/8a5492dc16ac148bde50b46ca756f95a655fad58/android_webview/java/src/org/chromium/android_webview/crash/AwMinidumpUploaderDelegate.java
[modify] https://crrev.com/8a5492dc16ac148bde50b46ca756f95a655fad58/android_webview/java/src/org/chromium/android_webview/crash/CrashReceiverService.java
[modify] https://crrev.com/8a5492dc16ac148bde50b46ca756f95a655fad58/chrome/android/java/AndroidManifest.xml
[modify] https://crrev.com/8a5492dc16ac148bde50b46ca756f95a655fad58/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java
[modify] https://crrev.com/8a5492dc16ac148bde50b46ca756f95a655fad58/chrome/android/java/src/org/chromium/chrome/browser/DeferredStartupHandler.java
[add] https://crrev.com/8a5492dc16ac148bde50b46ca756f95a655fad58/chrome/android/java/src/org/chromium/chrome/browser/crash/ChromeMinidumpUploadJobService.java
[add] https://crrev.com/8a5492dc16ac148bde50b46ca756f95a655fad58/chrome/android/java/src/org/chromium/chrome/browser/crash/ChromeMinidumpUploaderDelegate.java
[modify] https://crrev.com/8a5492dc16ac148bde50b46ca756f95a655fad58/chrome/android/java/src/org/chromium/chrome/browser/crash/LogcatExtractionRunnable.java
[modify] https://crrev.com/8a5492dc16ac148bde50b46ca756f95a655fad58/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadService.java
[modify] https://crrev.com/8a5492dc16ac148bde50b46ca756f95a655fad58/chrome/android/java_sources.gni
[modify] https://crrev.com/8a5492dc16ac148bde50b46ca756f95a655fad58/chrome/android/javatests/DEPS
[modify] https://crrev.com/8a5492dc16ac148bde50b46ca756f95a655fad58/chrome/android/javatests/src/org/chromium/chrome/browser/crash/LogcatExtractionRunnableTest.java
[modify] https://crrev.com/8a5492dc16ac148bde50b46ca756f95a655fad58/chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadServiceTest.java
[modify] https://crrev.com/8a5492dc16ac148bde50b46ca756f95a655fad58/chrome/app/generated_resources.grd
[modify] https://crrev.com/8a5492dc16ac148bde50b46ca756f95a655fad58/chrome/browser/about_flags.cc
[modify] https://crrev.com/8a5492dc16ac148bde50b46ca756f95a655fad58/chrome/browser/android/chrome_feature_list.cc
[modify] https://crrev.com/8a5492dc16ac148bde50b46ca756f95a655fad58/chrome/browser/android/chrome_feature_list.h
[modify] https://crrev.com/8a5492dc16ac148bde50b46ca756f95a655fad58/components/background_task_scheduler/android/java/src/org/chromium/components/background_task_scheduler/TaskIds.java
[modify] https://crrev.com/8a5492dc16ac148bde50b46ca756f95a655fad58/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/CrashFileManager.java
[modify] https://crrev.com/8a5492dc16ac148bde50b46ca756f95a655fad58/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/MinidumpUploadJobService.java
[modify] https://crrev.com/8a5492dc16ac148bde50b46ca756f95a655fad58/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/MinidumpUploaderDelegate.java
[modify] https://crrev.com/8a5492dc16ac148bde50b46ca756f95a655fad58/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/MinidumpUploaderImpl.java
[modify] https://crrev.com/8a5492dc16ac148bde50b46ca756f95a655fad58/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/util/CrashReportingPermissionManager.java
[modify] https://crrev.com/8a5492dc16ac148bde50b46ca756f95a655fad58/components/minidump_uploader/android/javatests/src/org/chromium/components/minidump_uploader/CrashFileManagerTest.java
[modify] https://crrev.com/8a5492dc16ac148bde50b46ca756f95a655fad58/testing/variations/fieldtrial_testing_config.json
[modify] https://crrev.com/8a5492dc16ac148bde50b46ca756f95a655fad58/tools/metrics/histograms/histograms.xml

Comment 16 by isherman@chromium.org, Mar 16 2017 

Alright, the final change has landed!  Will let this bake on Canary/Dev for a few days, and then request a merge to M58.

Comment 18 by isherman@chromium.org, Mar 28 2017

Labels: Merge-Request-58
Requesting merge of #457584 and #457650 to M58.  The stability numbers look fairly comparable between the two implementations, so we're likely not losing crashes due to the new implementation (nor does the new impl seem to itself be crashing).
Project Member

Comment 19 by sheriffbot@chromium.org, Mar 28 2017

Labels: -Merge-Request-58 Merge-Review-58 Hotlist-Merge-Review
This bug requires manual review: There is .grd file changes and we are only 27 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 20 by amineer@chromium.org, Mar 28 2017

Labels: -Merge-Review-58 Merge-Approved-58
Approved for M58 branch 3029.
Project Member

Comment 21 by bugdroid1@chromium.org, Mar 28 2017

Labels: -merge-approved-58
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/131af4f023962bf4a4cdc6b246948299f636140b

commit 131af4f023962bf4a4cdc6b246948299f636140b
Author: Ilya Sherman <isherman@chromium.org>
Date: Tue Mar 28 21:16:55 2017

[Merge] [Android Crash Reporting] Allow uploading minidumps via the JobScheduler

The new functionality is guarded behind a Feature.

BUG= 694884 
R=gsennton@chromium.org, mariakhomenko@chromium.org

Review-Url: https://codereview.chromium.org/2737263006
Cr-Commit-Position: refs/heads/master@{#457584}
(cherry picked from commit 8a5492dc16ac148bde50b46ca756f95a655fad58)

Review-Url: https://codereview.chromium.org/2778353002 .
Cr-Commit-Position: refs/branch-heads/3029@{#459}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/131af4f023962bf4a4cdc6b246948299f636140b/android_webview/BUILD.gn
[modify] https://crrev.com/131af4f023962bf4a4cdc6b246948299f636140b/android_webview/java/DEPS
[modify] https://crrev.com/131af4f023962bf4a4cdc6b246948299f636140b/android_webview/java/src/org/chromium/android_webview/crash/AwMinidumpUploadJobService.java
[modify] https://crrev.com/131af4f023962bf4a4cdc6b246948299f636140b/android_webview/java/src/org/chromium/android_webview/crash/AwMinidumpUploaderDelegate.java
[modify] https://crrev.com/131af4f023962bf4a4cdc6b246948299f636140b/android_webview/java/src/org/chromium/android_webview/crash/CrashReceiverService.java
[modify] https://crrev.com/131af4f023962bf4a4cdc6b246948299f636140b/chrome/android/java/AndroidManifest.xml
[modify] https://crrev.com/131af4f023962bf4a4cdc6b246948299f636140b/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java
[modify] https://crrev.com/131af4f023962bf4a4cdc6b246948299f636140b/chrome/android/java/src/org/chromium/chrome/browser/DeferredStartupHandler.java
[add] https://crrev.com/131af4f023962bf4a4cdc6b246948299f636140b/chrome/android/java/src/org/chromium/chrome/browser/crash/ChromeMinidumpUploadJobService.java
[add] https://crrev.com/131af4f023962bf4a4cdc6b246948299f636140b/chrome/android/java/src/org/chromium/chrome/browser/crash/ChromeMinidumpUploaderDelegate.java
[modify] https://crrev.com/131af4f023962bf4a4cdc6b246948299f636140b/chrome/android/java/src/org/chromium/chrome/browser/crash/LogcatExtractionRunnable.java
[modify] https://crrev.com/131af4f023962bf4a4cdc6b246948299f636140b/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadService.java
[modify] https://crrev.com/131af4f023962bf4a4cdc6b246948299f636140b/chrome/android/java_sources.gni
[modify] https://crrev.com/131af4f023962bf4a4cdc6b246948299f636140b/chrome/android/javatests/DEPS
[modify] https://crrev.com/131af4f023962bf4a4cdc6b246948299f636140b/chrome/android/javatests/src/org/chromium/chrome/browser/crash/LogcatExtractionRunnableTest.java
[modify] https://crrev.com/131af4f023962bf4a4cdc6b246948299f636140b/chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadServiceTest.java
[modify] https://crrev.com/131af4f023962bf4a4cdc6b246948299f636140b/chrome/app/generated_resources.grd
[modify] https://crrev.com/131af4f023962bf4a4cdc6b246948299f636140b/chrome/browser/about_flags.cc
[modify] https://crrev.com/131af4f023962bf4a4cdc6b246948299f636140b/chrome/browser/android/chrome_feature_list.cc
[modify] https://crrev.com/131af4f023962bf4a4cdc6b246948299f636140b/chrome/browser/android/chrome_feature_list.h
[modify] https://crrev.com/131af4f023962bf4a4cdc6b246948299f636140b/components/background_task_scheduler/android/java/src/org/chromium/components/background_task_scheduler/TaskIds.java
[modify] https://crrev.com/131af4f023962bf4a4cdc6b246948299f636140b/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/CrashFileManager.java
[modify] https://crrev.com/131af4f023962bf4a4cdc6b246948299f636140b/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/MinidumpUploadJobService.java
[modify] https://crrev.com/131af4f023962bf4a4cdc6b246948299f636140b/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/MinidumpUploaderDelegate.java
[modify] https://crrev.com/131af4f023962bf4a4cdc6b246948299f636140b/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/MinidumpUploaderImpl.java
[modify] https://crrev.com/131af4f023962bf4a4cdc6b246948299f636140b/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/util/CrashReportingPermissionManager.java
[modify] https://crrev.com/131af4f023962bf4a4cdc6b246948299f636140b/components/minidump_uploader/android/javatests/src/org/chromium/components/minidump_uploader/CrashFileManagerTest.java
[modify] https://crrev.com/131af4f023962bf4a4cdc6b246948299f636140b/testing/variations/fieldtrial_testing_config.json
[modify] https://crrev.com/131af4f023962bf4a4cdc6b246948299f636140b/tools/metrics/histograms/histograms.xml

Comment 23 by isherman@chromium.org, Mar 28 2017

Status: Fixed (was: Started)

Comment 24 by isherman@chromium.org, Mar 29 2017

Status: Started (was: Fixed)
Need to merge more carefully due to code drift: https://bugs.chromium.org/p/chromium/issues/detail?id=706254
Project Member

Comment 25 by bugdroid1@chromium.org, Mar 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/453e42120a1d38e71c3f2b315b83899f8b310aef

commit 453e42120a1d38e71c3f2b315b83899f8b310aef
Author: isherman <isherman@chromium.org>
Date: Wed Mar 29 04:05:18 2017

Revert of [Merge] Fix minidump-related JobScheduler test failures. (patchset #1 id:1 of https://codereview.chromium.org/2779693004/ )

Reason for revert:
Caused a build failure: crbug.com/706254.  The tests need to be updated to use the old way of testing a Feature.

Original issue's description:
> [Merge] Fix minidump-related JobScheduler test failures.
>
> BUG= 694884 
> TEST=none
> R=dfalcantara@chromium.org
>
> Review-Url: https://codereview.chromium.org/2753173002
> Cr-Commit-Position: refs/heads/master@{#457650}
> (cherry picked from commit 0c77af249cab19e99fc0024b828373b1751633e2)
>
> Review-Url: https://codereview.chromium.org/2779693004 .
> Cr-Commit-Position: refs/branch-heads/3029@{#460}
> Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}
> Committed: https://chromium.googlesource.com/chromium/src/+/2159626e1e7064876a3f9dc1c420b721f9aac1c2

TBR=dfalcantara@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 694884 

Review-Url: https://codereview.chromium.org/2783833002
Cr-Commit-Position: refs/branch-heads/3029@{#467}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/453e42120a1d38e71c3f2b315b83899f8b310aef/chrome/android/javatests/src/org/chromium/chrome/browser/crash/LogcatExtractionRunnableTest.java
[modify] https://crrev.com/453e42120a1d38e71c3f2b315b83899f8b310aef/chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadServiceTest.java
Project Member

Comment 26 by bugdroid1@chromium.org, Mar 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ce3ccb9d8093a1eb542098f2e68fd51c90fa989d

commit ce3ccb9d8093a1eb542098f2e68fd51c90fa989d
Author: isherman <isherman@chromium.org>
Date: Wed Mar 29 04:31:00 2017

[Crash Reporting] Enable the JobScheduler API by default for Android M+.

BUG= 694884 
TEST=none
R=mariakhomenko@chromium.org
TBR=thakis@chromium.org

Review-Url: https://codereview.chromium.org/2780933002
Cr-Commit-Position: refs/heads/master@{#460279}

[modify] https://crrev.com/ce3ccb9d8093a1eb542098f2e68fd51c90fa989d/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java
[modify] https://crrev.com/ce3ccb9d8093a1eb542098f2e68fd51c90fa989d/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadService.java
[modify] https://crrev.com/ce3ccb9d8093a1eb542098f2e68fd51c90fa989d/chrome/android/javatests/src/org/chromium/chrome/browser/crash/LogcatExtractionRunnableTest.java
[modify] https://crrev.com/ce3ccb9d8093a1eb542098f2e68fd51c90fa989d/chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadServiceTest.java
[modify] https://crrev.com/ce3ccb9d8093a1eb542098f2e68fd51c90fa989d/chrome/browser/about_flags.cc
[modify] https://crrev.com/ce3ccb9d8093a1eb542098f2e68fd51c90fa989d/chrome/browser/android/chrome_feature_list.cc
[modify] https://crrev.com/ce3ccb9d8093a1eb542098f2e68fd51c90fa989d/chrome/browser/android/chrome_feature_list.h
[modify] https://crrev.com/ce3ccb9d8093a1eb542098f2e68fd51c90fa989d/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/ce3ccb9d8093a1eb542098f2e68fd51c90fa989d/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/ce3ccb9d8093a1eb542098f2e68fd51c90fa989d/testing/variations/fieldtrial_testing_config.json

Comment 28 by isherman@chromium.org, Mar 29 2017

Status: Fixed (was: Started)
►

Sign in to add a comment