New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 694865 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Feb 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

Visiting www.virginamerica.com redirects me to about:blank

Project Member Reported by pkl@chromium.org, Feb 22 2017

Issue description

App Version (from "Chrome Settings > About Chrome"): 56.0.2924.79
iOS Version: 9.3.5, 10.3 (beta)
Device: iPhone SE, iPhone 5S

Steps to reproduce: 
Visit https://www.virginamerica.com/ in a new tab

Observed behavior: 
The page loads and *immediately* after it is loaded, the page jumped to about:blank.
If you tap and hold on the back arrow, you can see that virginamerica.com is still on the navigation history. But if you navigate back, the page loads and then jumped to about:blank again.

Expected behavior: 
The page should load and I can interact with Virgin America web site.

Frequency: 
Every time.

Additional comments: 

 

Comment 1 by pkl@chromium.org, Feb 22 2017

Cc: kkhorimoto@chromium.org michaeldo@chromium.org cma...@chromium.org
Components: Mobile>WebView>Glue
Labels: -Restrict-View-Google ReleaseBlock-Stable M-57
Owner: eugene...@chromium.org
Status: Assigned (was: Untriaged)
Please investigate to see whether this can happen with other web sites as well. It's bad that I cannot check in to my Virgin America flight using Chrome. I had to use Safari which worked just fine. We should understand why this is happening. I tried this on an iOS 10.1 iPhone that still has Chrome M54 installed and it can visit Virgin America web site properly.

Note that I can repro the problem on iOS simulator as well. This error message is seen in my console:

[0221/174143.193945:WARNING:crw_web_controller.mm(2577)] Message from JS ignored due to non-matching windowID: 0x6380002706c0 != 0x610000272300
[0221/174143.194072:WARNING:crw_web_controller.mm(2551)] Message from JS not handled due to invalid format


Cc: linds...@chromium.org
Labels: -Pri-2 Pri-1
Peter, I can not reproduce with the given steps on iPhone SE, 10.2.1 using Chrome 56.0.2924.79 or Chrome 58.0.3011.0. Could you please try clearing your Cookies and try again?

Lindsay, could you please ask QA to investigate.

Thanks!

I just tried on M58 canary on iPhone7 with 10.3 and able to reproduce.
Regular tab and Incognito tabs as well.
Soon as I navigated to virginamerica.com it redirects me to about:blank.
Working fine in Safari, Firefox.

Let me know what additional information would be helpful.

Thanks, so maybe 10.3 is the key.

Comment 5 by pkl@chromium.org, Feb 22 2017

Problem exists on my iPhone SE running iOS 9.3.5 as well, i.e. 10.3 is NOT the key.
Cc: pinkerton@chromium.org
I wonder if pre-rendering may be causing the differences in how this triggers. Can we get a video so we're all on the same page? 

(note I cannot repro this on 10.2.x iPhone7 in either M58dev or a HEAD build compiled today.)
Issue reproduces even with pre-loading disabled.
Here is a video on my iPhone7 with latest iOS10.3 beta. I was unable to reproduce on other iPhones with 10.2.1 public release iOS.
https://drive.google.com/file/d/0B-xmXLQhjeKuZmJLNE96dm5nSjQ/view
Status: Started (was: Assigned)
Was able to reproduce on 10.3 simulator (but not on 10.2). Fix is here: https://codereview.chromium.org/2709383002
Project Member

Comment 10 by bugdroid1@chromium.org, Feb 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/74d58648b7106e3cf8dc31f667eb5e902e15caaa

commit 74d58648b7106e3cf8dc31f667eb5e902e15caaa
Author: eugenebut <eugenebut@chromium.org>
Date: Thu Feb 23 03:20:43 2017

Do not load about:blank if iframe requested to load invalid URL.

https://codereview.chromium.org/2397623002 prevents loading the page
with invalid url and loads about blank:instead. This CL prevents
loading about:blank if request is coming from iframe.

BUG= 694865 

Review-Url: https://codereview.chromium.org/2709383002
Cr-Commit-Position: refs/heads/master@{#452371}

[modify] https://crrev.com/74d58648b7106e3cf8dc31f667eb5e902e15caaa/ios/web/web_state/ui/crw_web_controller.mm

Labels: Merge-Request-57
Status: Fixed (was: Started)
Project Member

Comment 12 by sheriffbot@chromium.org, Feb 23 2017

Labels: -Merge-Request-57 Hotlist-Merge-Review Merge-Review-57
This bug requires manual review: Less than 15 days to go before AppStore submit on M57
Please contact the milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 13 by bugdroid1@chromium.org, Feb 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/79b6f0b6ef5566a8be1b4650004142b53f862023

commit 79b6f0b6ef5566a8be1b4650004142b53f862023
Author: eugenebut <eugenebut@chromium.org>
Date: Fri Feb 24 19:31:52 2017

Added test cases for  crbug.com/694865  regression.

IFrameWithInvalidURL loads <iframe src='http://%3'/> page and expects
that about:blank navigation will not happen.

LoadInvalidURL loads a page with invalid URL and expects that
about:blank is loaded instead.

BUG= 694865 

Review-Url: https://codereview.chromium.org/2712643007
Cr-Commit-Position: refs/heads/master@{#452903}

[modify] https://crrev.com/79b6f0b6ef5566a8be1b4650004142b53f862023/ios/web/web_state/ui/crw_web_controller_unittest.mm

Status: Verified (was: Fixed)
Virgin America webpage loads fine on M58.0.3025.0 canary, iPhone7, iOS 10.3 beta#4
Labels: -Hotlist-Merge-Review -Merge-Review-57 Merge-Approved-57
Verified on chrome canary version 58.0.3026.0 on iPhone 7plus 10.2.1, and iPhone6 10.3 beta 3 Virgin America webpage loads fine.   
Project Member

Comment 17 by sheriffbot@chromium.org, Mar 3 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 18 by bugdroid1@chromium.org, Mar 3 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a938a18f838db140a0ed9068ba6ac6320730599

commit 8a938a18f838db140a0ed9068ba6ac6320730599
Author: Eugene But <eugenebut@google.com>
Date: Fri Mar 03 18:29:27 2017

Do not load about:blank if iframe requested to load invalid URL.

https://codereview.chromium.org/2397623002 prevents loading the page
with invalid url and loads about blank:instead. This CL prevents
loading about:blank if request is coming from iframe.

BUG= 694865 

Review-Url: https://codereview.chromium.org/2709383002
Cr-Commit-Position: refs/heads/master@{#452371}
(cherry picked from commit 74d58648b7106e3cf8dc31f667eb5e902e15caaa)

Review-Url: https://codereview.chromium.org/2726083006 .
Cr-Commit-Position: refs/branch-heads/2987@{#753}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/8a938a18f838db140a0ed9068ba6ac6320730599/ios/web/web_state/ui/crw_web_controller.mm

Virgin America webpage loads fine on M57.0.2987.95 beta, on iPhone6+ 10.3(beta4),iPhone 7+  10.2.1.

Sign in to add a comment