It looks like this usage was introduced with https://chromium.googlesource.com/chromium/src/+/ec8edae43017bf5ea65d3b65edbcfd740af453c7

It seems like we hit NOTIMPLEMENTED if we query GetFormat on certain GLSurface subclasses which do not override GetFormat. On linux we appear to be using one of these.

klausw@, can you take a look?

I'm investigating, the fallback behavior should be correct in this case but it should of course not be hitting the NOTIMPLEMENTED marker. Should be easy to fix.

 Issue 695431  has been merged into this issue.

Proposed fix in https://codereview.chromium.org/2702403009 .

I don't think that this was actually causing issues other than logfile noise - if I'm reading it right in https://cs.chromium.org/chromium/src/base/logging.h the default NOTIMPLEMENTED_POLICY=4 prints an error but continues executing, and the fallback return value seems appropriate for the cases that didn't have overrides.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/10aaaf5a41d02653d144a4e78c43c29974860e39

commit 10aaaf5a41d02653d144a4e78c43c29974860e39
Author: klausw <klausw@chromium.org>
Date: Fri Feb 24 00:50:53 2017

Make surface GetFormat pure virtual, add missing overrides.

The base fallback with NOTIMPLEMENTED() warning was unhelpful,
change it to explicitly require overrides in subclasses so
there's no ambiguity if the default is ok or not.

BUG= 694857 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2702403009
Cr-Commit-Position: refs/heads/master@{#452695}

[modify] https://crrev.com/10aaaf5a41d02653d144a4e78c43c29974860e39/android_webview/browser/aw_gl_surface.cc
[modify] https://crrev.com/10aaaf5a41d02653d144a4e78c43c29974860e39/android_webview/browser/aw_gl_surface.h
[modify] https://crrev.com/10aaaf5a41d02653d144a4e78c43c29974860e39/gpu/ipc/service/image_transport_surface_overlay_mac.h
[modify] https://crrev.com/10aaaf5a41d02653d144a4e78c43c29974860e39/gpu/ipc/service/image_transport_surface_overlay_mac.mm
[modify] https://crrev.com/10aaaf5a41d02653d144a4e78c43c29974860e39/ui/gl/gl_surface.cc
[modify] https://crrev.com/10aaaf5a41d02653d144a4e78c43c29974860e39/ui/gl/gl_surface.h
[modify] https://crrev.com/10aaaf5a41d02653d144a4e78c43c29974860e39/ui/gl/gl_surface_format.h
[modify] https://crrev.com/10aaaf5a41d02653d144a4e78c43c29974860e39/ui/gl/gl_surface_glx.cc
[modify] https://crrev.com/10aaaf5a41d02653d144a4e78c43c29974860e39/ui/gl/gl_surface_glx.h
[modify] https://crrev.com/10aaaf5a41d02653d144a4e78c43c29974860e39/ui/gl/gl_surface_stub.cc
[modify] https://crrev.com/10aaaf5a41d02653d144a4e78c43c29974860e39/ui/gl/gl_surface_stub.h
[modify] https://crrev.com/10aaaf5a41d02653d144a4e78c43c29974860e39/ui/gl/gl_surface_wgl.cc
[modify] https://crrev.com/10aaaf5a41d02653d144a4e78c43c29974860e39/ui/gl/gl_surface_wgl.h
[modify] https://crrev.com/10aaaf5a41d02653d144a4e78c43c29974860e39/ui/gl/init/gl_factory_mac.cc