New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 694856 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

cr-dialog, cr-action-menu can cause a 2nd scrollbar

Project Member Reported by dpa...@chromium.org, Feb 22 2017

Issue description

Repro 1: cr-action-menu
 1) Navigate to MD Settings
 2) Focus the "dots" icon for in the "on startup" section.
 3) Make the window small enough such that the "dots" icon falls outside the right edge.
 4) Press space/enter.

Observe a 2nd scrollbar appearing on the bottom. Scrolling to the right reveals odd blank space (see action_menu_double_scroll_bar.png)

Repro 2: cr-dialog
 1) Navigate to MD Settings, go to the "Reset" section (at the bottom of the advanced options).
 2) Click "Reset" to open the dialog.
 3) Make the window small enough such that the dialog does not fit into the visible space.

Observe a 2nd scrollbar appearing on the bottom. Scrolling to the right reveals odd blank space (see dialog_double_scroll_bar.png)

Both of these elements use a <dialog> under the cover. Hopefully the problem could be fixed by tweaking our dialog's CSS (and not having to modify blink's <dialog> implementation).


Planning to consolidating multiple bug reports caused by the same underlying issue to this bug.
 
dialog_double_scroll_bar.png
53.6 KB View Download
action_menu_double_scroll_bar.png
56.4 KB View Download
dialog_double_scroll_bar.mp4
216 KB View Download
action_menu_double_scroll_bar.mp4
242 KB View Download

Comment 1 by dpa...@chromium.org, Feb 22 2017

Cc: ranjitkan@chromium.org jmukthavaram@chromium.org dpa...@chromium.org msrchandra@chromium.org brajkumar@chromium.org tsergeant@chromium.org michae...@chromium.org steve...@chromium.org nyerramilli@chromium.org rbasuvula@chromium.org tkonch...@chromium.org
 Issue 653800  has been merged into this issue.
 Issue 657768  has been merged into this issue.
 Issue 659597  has been merged into this issue.
 Issue 678511  has been merged into this issue.
 Issue 694443  has been merged into this issue.

Comment 2 by dpa...@chromium.org, Feb 22 2017

@dbeam: Some of the bugs merged into this one were blocking  issue 671375 . Can you re-add this if you think is worth blocking on this?

Comment 3 by dpa...@chromium.org, Feb 24 2017

 Issue 695803  has been merged into this issue.

Comment 4 by dbeam@chromium.org, Feb 25 2017

Owner: dpa...@chromium.org
Status: Assigned (was: Untriaged)

Comment 5 by dbeam@chromium.org, Feb 25 2017

intentionally did not block 671375 this time, but if somebody somewhere can convince me this is important, i guess we could

Comment 6 by dbeam@chromium.org, Feb 27 2017

Labels: Hotlist-MD-Settings-General

Comment 7 by dpa...@chromium.org, Feb 27 2017

Status: Started (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54620e7a10bd00609a7c428a3f734ac121abcacb

commit 54620e7a10bd00609a7c428a3f734ac121abcacb
Author: dpapad <dpapad@chromium.org>
Date: Wed Mar 01 19:17:57 2017

MD Settings: Eliminate potential 2nd scrollbar when dialog is shown.

BUG= 694856 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2722453003
Cr-Commit-Position: refs/heads/master@{#453993}

[modify] https://crrev.com/54620e7a10bd00609a7c428a3f734ac121abcacb/chrome/browser/resources/settings/settings.html

Project Member

Comment 9 by bugdroid1@chromium.org, Mar 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/88db8a1e6b522e67bfe49c1789dcde1f9d32ac22

commit 88db8a1e6b522e67bfe49c1789dcde1f9d32ac22
Author: dpapad <dpapad@chromium.org>
Date: Tue Mar 14 17:08:42 2017

MD History: Eliminate potential 2nd scrollbar when dialog is shown.

BUG= 694856 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2747783003
Cr-Commit-Position: refs/heads/master@{#456741}

[modify] https://crrev.com/88db8a1e6b522e67bfe49c1789dcde1f9d32ac22/chrome/browser/resources/md_history/history.html

Status: Fixed (was: Started)
I believe this is addressed now. I could not find a way to reproduce on the Downloads page.

Sign in to add a comment