New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 694851 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
inactive
Closed: Feb 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

NewTabPageRecyclerViewTest#testSnapScrollCondensedLayout failing on tablets

Project Member Reported by aelias@chromium.org, Feb 22 2017

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Feb 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a0be9febc6a33b487eaade15f7ec08cdd5e6b0d

commit 8a0be9febc6a33b487eaade15f7ec08cdd5e6b0d
Author: aelias <aelias@chromium.org>
Date: Wed Feb 22 01:04:58 2017

Revert of [Android NTP] Allow overlapping snap scroll regions. (patchset #3 id:40001 of https://codereview.chromium.org/2708653002/ )

Reason for revert:
NewTabPageRecyclerViewTest#testSnapScrollCondensedLayout failing on tablets

BUG= 694851 

Original issue's description:
> [Android NTP] Allow overlapping snap scroll regions.
>
> Previously the code assumed that snap scroll regions would never overlap.
> That assumption became false with the condensed NTP layout, with the result that
> only the first snap would be applied and the NTP would come to rest in a
> position it should have scrolled out of.
>
> We now apply all snaps in order and have an assertion that the desired position
> does not change after one pass.
>
> BUG=693095
>
> Review-Url: https://codereview.chromium.org/2708653002
> Cr-Commit-Position: refs/heads/master@{#451767}
> Committed: https://chromium.googlesource.com/chromium/src/+/6617e48c6e0733436a8fc430a17399038975926e

TBR=mvanouwerkerk@chromium.org,peconn@chromium.org,bauerb@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=693095

Review-Url: https://codereview.chromium.org/2705343003
Cr-Commit-Position: refs/heads/master@{#451861}

[modify] https://crrev.com/8a0be9febc6a33b487eaade15f7ec08cdd5e6b0d/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
[modify] https://crrev.com/8a0be9febc6a33b487eaade15f7ec08cdd5e6b0d/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java
[modify] https://crrev.com/8a0be9febc6a33b487eaade15f7ec08cdd5e6b0d/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerViewTest.java

Comment 2 by aelias@chromium.org, Feb 22 2017

Status: Fixed (was: Assigned)

Sign in to add a comment