Mus in renderer results in blue sign in page |
|||||||||||||||||
Issue descriptionLaunch mash on the desktop using the login-manager: rm -rf /tmp/xx ; ./out/Debug2/chrome --mash --login-manager --disable-setuid-sandbox --no-sandbox --user-data-dir=/tmp/xx --ozone-platform=x11 . Choose a network. . The login panel shows all blue. Running with --no-use-mus-in-renderer fixes it. I've attached two screenshots, one of what it should look like (good.png) and other as it actually looks.
,
Feb 22 2017
Heh. Yea it's a webview. I guess that makes me the right OWNER for this bug. I'll pick it up tomorrow.
,
Feb 28 2017
--> fsamuel@ as per c#2
,
Mar 6 2017
Saw this on today's ToT too. The webview is still usable (i.e. you can login if you typed everything correctly), just not visible.
,
Mar 7 2017
I've also seen this on device, and also with a white rectangle. And as xiyuan notes, I was able to type into it and log in.
,
Mar 7 2017
,
Mar 7 2017
,
Mar 13 2017
Roughly what I think needs to happen: 1. RenderWidgetHostViewChildFrame needs to get a mus window. 2. The parent RendererWindowTreeClient needs to identify which window gets the embedding. This is tricky because Chrome FrameSinkIds and Mus FrameSinkIds do not match. One solution is to hang the Chrome FrameSinkId as a property off the mus window that is then propagated to the parent. For BrowserPlugin-based <webview>, we probably need to stick the instance ID on the window. IIRC that's just a routing ID.
,
Mar 15 2017
mknowles@ / wjmaclean@ can you assign appropriately
,
Mar 17 2017
Looks like James is on vacation. Mike, do you know someone that has time for this?
,
Mar 20 2017
Lucas - could you take a look?
,
Mar 20 2017
I can look at it, but I have a couple of other bugs I need to prioritize first. Does this needs to be Pri 1?
,
Mar 20 2017
I would like to resolve this in the next week. Will you have time for that? If not, just say so and I'll see if someone else has time.
,
Mar 20 2017
That would be better. I'm just coming back from vacation and have too many things on my plate for this week.
,
Mar 20 2017
,
Mar 23 2017
Issue 704559 has been merged into this issue.
,
Mar 27 2017
,
Apr 6 2017
,
Apr 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1e0366fc5f961223c1862ff96a0bcd1302df32cd commit 1e0366fc5f961223c1862ff96a0bcd1302df32cd Author: sadrul <sadrul@chromium.org> Date: Mon Apr 10 19:52:55 2017 mus: Fix showing guest views in --mash and --mus. It is necessary to notify the RenderWidgetHostViewChildFrame of the surface associated with the child-frame, so that it can correctly notify the embedder. This fixes the login screen, opening pdf files in chrome, etc. BUG= 694846 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2804753002 Cr-Commit-Position: refs/heads/master@{#463372} [modify] https://crrev.com/1e0366fc5f961223c1862ff96a0bcd1302df32cd/content/browser/frame_host/render_widget_host_view_child_frame.cc [modify] https://crrev.com/1e0366fc5f961223c1862ff96a0bcd1302df32cd/content/browser/frame_host/render_widget_host_view_child_frame.h [modify] https://crrev.com/1e0366fc5f961223c1862ff96a0bcd1302df32cd/content/browser/renderer_host/render_widget_host_view_aura.cc [modify] https://crrev.com/1e0366fc5f961223c1862ff96a0bcd1302df32cd/content/browser/renderer_host/render_widget_host_view_aura.h [modify] https://crrev.com/1e0366fc5f961223c1862ff96a0bcd1302df32cd/content/browser/renderer_host/render_widget_host_view_base.h [modify] https://crrev.com/1e0366fc5f961223c1862ff96a0bcd1302df32cd/ui/aura/mus/window_port_mus.cc [modify] https://crrev.com/1e0366fc5f961223c1862ff96a0bcd1302df32cd/ui/aura/window_delegate.h
,
Apr 10 2017
,
May 30 2017
,
Aug 1 2017
,
Jan 22 2018
|
|||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||
Comment 1 by sadrul@chromium.org
, Feb 22 2017