struct MediaSink { enum IconType { .... } } generates a nested class enum in the mojom.h. It would save some typing to hoist this to the top level. https://codereview.chromium.org/2675033002/diff/160001/chrome/browser/media/router/mojo/media_router.mojom
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eff097998fb62ea127e725ef60a9ada3d58f74d6 commit eff097998fb62ea127e725ef60a9ada3d58f74d6 Author: Bin Zhao <zhaobin@chromium.org> Date: Thu Jul 20 17:48:01 2017 [Media Router] Move MediaSink::IconType class to top level Move IconType class out of MediaSink class in media_sink.h and media_router.mojom Bug: 694841 Change-Id: I710adea06557c63e061bb428dbaed7038eb8d956 Reviewed-on: https://chromium-review.googlesource.com/574900 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Derek Cheng <imcheng@chromium.org> Reviewed-by: mark a. foltz <mfoltz@chromium.org> Commit-Queue: Bin Zhao <zhaobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#488297} [modify] https://crrev.com/eff097998fb62ea127e725ef60a9ada3d58f74d6/chrome/browser/media/android/router/media_router_android_bridge.cc [modify] https://crrev.com/eff097998fb62ea127e725ef60a9ada3d58f74d6/chrome/browser/media/router/discovery/dial/dial_media_sink_service_impl.cc [modify] https://crrev.com/eff097998fb62ea127e725ef60a9ada3d58f74d6/chrome/browser/media/router/discovery/mdns/cast_media_sink_service.cc [modify] https://crrev.com/eff097998fb62ea127e725ef60a9ada3d58f74d6/chrome/browser/media/router/discovery/media_sink_service_base_unittest.cc [modify] https://crrev.com/eff097998fb62ea127e725ef60a9ada3d58f74d6/chrome/browser/media/router/media_sinks_observer_unittest.cc [modify] https://crrev.com/eff097998fb62ea127e725ef60a9ada3d58f74d6/chrome/browser/media/router/mojo/media_router_mojo_impl_unittest.cc [modify] https://crrev.com/eff097998fb62ea127e725ef60a9ada3d58f74d6/chrome/browser/media/router/presentation_media_sinks_observer_unittest.cc [modify] https://crrev.com/eff097998fb62ea127e725ef60a9ada3d58f74d6/chrome/browser/ui/ash/system_tray_tray_cast_browsertest_media_router_chromeos.cc [modify] https://crrev.com/eff097998fb62ea127e725ef60a9ada3d58f74d6/chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc [modify] https://crrev.com/eff097998fb62ea127e725ef60a9ada3d58f74d6/chrome/browser/ui/webui/media_router/media_router_webui_message_handler_unittest.cc [modify] https://crrev.com/eff097998fb62ea127e725ef60a9ada3d58f74d6/chrome/browser/ui/webui/media_router/query_result_manager_unittest.cc [modify] https://crrev.com/eff097998fb62ea127e725ef60a9ada3d58f74d6/chrome/common/media_router/discovery/media_sink_internal.h [modify] https://crrev.com/eff097998fb62ea127e725ef60a9ada3d58f74d6/chrome/common/media_router/discovery/media_sink_internal_unittest.cc [modify] https://crrev.com/eff097998fb62ea127e725ef60a9ada3d58f74d6/chrome/common/media_router/media_sink.cc [modify] https://crrev.com/eff097998fb62ea127e725ef60a9ada3d58f74d6/chrome/common/media_router/media_sink.h [modify] https://crrev.com/eff097998fb62ea127e725ef60a9ada3d58f74d6/chrome/common/media_router/media_sink_unittest.cc [modify] https://crrev.com/eff097998fb62ea127e725ef60a9ada3d58f74d6/chrome/common/media_router/mojo/media_router.mojom [modify] https://crrev.com/eff097998fb62ea127e725ef60a9ada3d58f74d6/chrome/common/media_router/mojo/media_router_struct_traits.cc [modify] https://crrev.com/eff097998fb62ea127e725ef60a9ada3d58f74d6/chrome/common/media_router/mojo/media_router_struct_traits.h [modify] https://crrev.com/eff097998fb62ea127e725ef60a9ada3d58f74d6/chrome/common/media_router/mojo/media_router_struct_traits_unittest.cc
Comment 1 by sko...@chromium.org
, Mar 2 2017Status: Available (was: Untriaged)