New issue
Advanced search Search tips

Issue 694819 link

Starred by 1 user
Status: Fixed
Owner:
dpa...@chromium.org
Closed: Feb 2017
Cc:
dbeam@chromium.org
bettes@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

[Search engine] Change "omnibox" to "address bar"

Project Member Reported by srahim@chromium.org, Feb 21 2017 
User-facing text should refer to the "address bar" and not the "omnibox."

Please update this string:
<message name="IDS_SETTINGS_SEARCH_EXPLANATION" desc="Explanation for the search engine dropdown setting.">
+    Search engine used when searching from the <ph name="BEGIN_LINK">&lt;a target="_blank" href="$1"&gt;</ph>omnibox<ph name="END_LINK">&lt;/a&gt;</ph>
   </message>

Comment 1 by dpa...@chromium.org, Feb 21 2017

Cc: dbeam@chromium.org
Is there a reason for having the Restrict-View-Google label?

Comment 2 by dbeam@chromium.org, Feb 23 2017

Labels: -Restrict-View-Google Hotlist-MD-Settings-SearchEngines
Status: Assigned (was: Untriaged)

Comment 3 by dpa...@chromium.org, Feb 28 2017

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1adcb83eede09036e7ca43abb0ea0e01e7d4f36

commit e1adcb83eede09036e7ca43abb0ea0e01e7d4f36
Author: dpapad <dpapad@chromium.org>
Date: Tue Feb 28 02:20:55 2017

MD Settings: Change "omnibox" to "address bar"

BUG= 694819 

Review-Url: https://codereview.chromium.org/2718283002
Cr-Commit-Position: refs/heads/master@{#453461}

[modify] https://crrev.com/e1adcb83eede09036e7ca43abb0ea0e01e7d4f36/chrome/app/settings_strings.grdp

Comment 5 by dpa...@chromium.org, Feb 28 2017

Status: Fixed (was: Started)
►

Sign in to add a comment