New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 694805 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug
Hotlist-MemoryInfra

Blocking:
issue 686208



Sign in to add a comment

Upgrade native allocator shim in Windows to handle all different pools and follow new shim architecture

Project Member Reported by ajwong@chromium.org, Feb 21 2017

Issue description

In windows, by default, multiple DLLs don't merge their dynamic symbols such that they end up using the same heap like they do on linux. They behave closer to having Bsymoblic enabled everywhere.

Because of this, the current shim in windows only works on chrome.dll and not chrome.exe (maybe this os okay??? how much is actually in chrome.exe?)

It's also unclear how well it handles differentiating between different allocator calls (malloc vs VirtualAlloc vs HeapAlloc, etc etc).

Lastly, the shim was built before the current memory infrastructure meaning it is different from everything else.

Resolve all these bits.
 

Comment 1 by ajwong@chromium.org, Feb 21 2017

Blocking: 686208

Comment 2 by w...@chromium.org, Mar 3 2017

Labels: -Pri-3 M-59 Pri-2
Owner: w...@chromium.org
Status: Assigned (was: Available)

Comment 3 by w...@chromium.org, Apr 14 2017

Labels: M-60

Comment 4 by w...@chromium.org, Apr 14 2017

Labels: -M-59

Comment 5 by w...@chromium.org, Jun 26 2017

Labels: -M-60 M-62
Owner: ajwong@chromium.org
ajwong: The old shim code is gone, but we still need the Windows-specific bits of the common implementation updating to hook non-CRT allocations.

Sign in to add a comment