Increase backtrace size on windows for use in Native Heap Profiling |
|||||
Issue descriptionThis is the windows equivalent of https://bugs.chromium.org/p/chromium/issues/detail?id=617772. Needed because the native heap profiling code expects a certain number of frames and windows is lagging other platforms. Note that the existing stack walk code (Based on RtlCaptureStackBackTrace) apparently has an internal limit that we will hit so it may not be as simple as changing a constant.
,
Feb 21 2017
,
Feb 23 2017
,
Feb 23 2017
Hmm, so heap profiler on Windows is using RtlCaptureStackBackTrace and not base::debug::TraceStackFramePointers? How does RtlCaptureStackBackTrace work - does it rely on frame pointers?
,
Mar 12 2017
Re #4: TraceStackFramePointers() isn't currently implemented for Windows, and Windows only supports frame pointers in x86, not x64 or ARM. base::debug::StackTrace has secondary implementations for Windows which use StackWalk64, which should work for arbitrary stack depths, but requires dbghelp.dll, so we probably need an alternative impl based on RtlVirtualUnwind() or similar.
,
Oct 31 2017
Unable to triage this issue from TE-End, hence adding TE-NeedsTriageHelp label for further triage
,
Oct 31
Issue has not been modified or commented on in the last 365 days, please re-open or file a new bug if this is still an issue. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by ajwong@chromium.org
, Feb 21 2017