New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 694786 link

Starred by 2 users
Status: Fixed
Owner:
dalecur...@chromium.org
Closed: Apr 2017
Cc:
skare@chromium.org
isherman@chromium.org
asvitk...@chromium.org
█ rkaplow@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Redundant presubmit for histograms pretty print if git cl format presubmit is enabled

Project Member Reported by asvitk...@chromium.org, Feb 21 2017 
Redundant presubmit for histograms pretty print if git cl format presubmit is enabled.

Since git cl format now formats histograms.xml, we can now just enable it for tools/metrics directory and remove the custom pretty_print presubmit for histograms.xml

Comment 1 by dalecur...@chromium.org, Feb 21 2017 

https://cs.chromium.org/chromium/src/PRESUBMIT.py?l=2319 enabled clang format by default everywhere; so I think you can drop the histograms/ PRESUBMIT entirely.

Comment 2 by asvitk...@chromium.org, Apr 3 2017

Owner: dalecur...@chromium.org
Dale took this one before I had a chance to get to it. Thanks!
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/94124abb3ca82523119708171401921ba1c3c779

commit 94124abb3ca82523119708171401921ba1c3c779
Author: dalecurtis <dalecurtis@chromium.org>
Date: Mon Apr 03 19:06:18 2017

Remove pretty_print step from histograms presubmit, git cl format handles this.

Since git cl format handles histogram formatting, this is causing
us to take twice the time on upload if there are histogram changes.

BUG= 694786 
TEST=none

Review-Url: https://codereview.chromium.org/2792723002
Cr-Commit-Position: refs/heads/master@{#461496}

[modify] https://crrev.com/94124abb3ca82523119708171401921ba1c3c779/tools/metrics/histograms/PRESUBMIT.py

Comment 4 by dalecur...@chromium.org, Apr 3 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment