Issue 694773 link

Starred by 1 user

Issue metadata

Status:	Verified
Owner:	slangley@chromium.org
Closed:	Feb 2017
Cc:	esprehn@chromium.org
Components:	Blink>Internals>Modularization
EstimatedDays:	----
NextAction:	----
OS:	All
Pri:	3
Type:	Task

Rename FrameLoaderClient to LocalFrameClient.

Project Member Reported by slangley@chromium.org, Feb 21 2017

Issue description

"FrameLoader"Client is not really related to FrameLoader.

FrameLoaderClient is used mainly to call WebLocalFrameImpl's methods (in web/) from LocalFrame (in core/). 

FrameLoaderClient should be renamed to LocalFrameClient. This is more consistent with the fact that a remote frame uses RemoteFrameClient for that purpose.

Comment 1 by slangley@chromium.org, Feb 21 2017

Status: Started (was: Assigned)

Project Member

Comment 2 by bugdroid1@chromium.org, Feb 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/445e237611d315d10ba6f7d97b6f40fc5cb404de

commit 445e237611d315d10ba6f7d97b6f40fc5cb404de
Author: slangley <slangley@chromium.org>
Date: Fri Feb 24 09:47:47 2017

Part 1 Of Renaming FrameLoaderClient to LocalFrameClient.

*** This patch is a rename-only change; no logic changes. ***

This patch does the following:

a. Rename FrameLoaderClient related files to LocalFrameClient.
b. Create an alias for LocalFrameClient to FrameLoaderClient.
c. Where FrameLoaderClient was being forward declared, either
  i. Replace with alias to LocalFrameClient, or
  ii. Just Use LocalFrameClient directly where possible.

Subsequent patches will start moving usage of FrameLoaderClient to
LocalFrameClient in a set of logically associated change lists.

BUG= 694773 

Review-Url: https://codereview.chromium.org/2712033002
Cr-Commit-Position: refs/heads/master@{#452781}

[modify] https://crrev.com/445e237611d315d10ba6f7d97b6f40fc5cb404de/third_party/WebKit/Source/core/frame/LocalFrame.h
[add] https://crrev.com/445e237611d315d10ba6f7d97b6f40fc5cb404de/third_party/WebKit/Source/core/frame/LocalFrameClient.h
[modify] https://crrev.com/445e237611d315d10ba6f7d97b6f40fc5cb404de/third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.h
[modify] https://crrev.com/445e237611d315d10ba6f7d97b6f40fc5cb404de/third_party/WebKit/Source/core/loader/DocumentLoader.cpp
[modify] https://crrev.com/445e237611d315d10ba6f7d97b6f40fc5cb404de/third_party/WebKit/Source/core/loader/DocumentLoader.h
[modify] https://crrev.com/445e237611d315d10ba6f7d97b6f40fc5cb404de/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
[modify] https://crrev.com/445e237611d315d10ba6f7d97b6f40fc5cb404de/third_party/WebKit/Source/core/loader/FrameFetchContext.h
[modify] https://crrev.com/445e237611d315d10ba6f7d97b6f40fc5cb404de/third_party/WebKit/Source/core/loader/FrameLoader.h
[modify] https://crrev.com/445e237611d315d10ba6f7d97b6f40fc5cb404de/third_party/WebKit/Source/core/loader/FrameLoaderClient.h
[modify] https://crrev.com/445e237611d315d10ba6f7d97b6f40fc5cb404de/third_party/WebKit/Source/core/loader/ProgressTracker.cpp
[modify] https://crrev.com/445e237611d315d10ba6f7d97b6f40fc5cb404de/third_party/WebKit/Source/core/loader/ProgressTracker.h
[modify] https://crrev.com/445e237611d315d10ba6f7d97b6f40fc5cb404de/third_party/WebKit/Source/web/BUILD.gn
[modify] https://crrev.com/445e237611d315d10ba6f7d97b6f40fc5cb404de/third_party/WebKit/Source/web/FrameLoaderClientImpl.h
[rename] https://crrev.com/445e237611d315d10ba6f7d97b6f40fc5cb404de/third_party/WebKit/Source/web/LocalFrameClientImpl.cpp
[add] https://crrev.com/445e237611d315d10ba6f7d97b6f40fc5cb404de/third_party/WebKit/Source/web/LocalFrameClientImpl.h
[modify] https://crrev.com/445e237611d315d10ba6f7d97b6f40fc5cb404de/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
[modify] https://crrev.com/445e237611d315d10ba6f7d97b6f40fc5cb404de/third_party/WebKit/Source/web/WebLocalFrameImpl.h
[rename] https://crrev.com/445e237611d315d10ba6f7d97b6f40fc5cb404de/third_party/WebKit/Source/web/tests/LocalFrameClientImplTest.cpp

Project Member

Comment 3 by bugdroid1@chromium.org, Feb 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b39e4cecb07231262bbce0ab825c31b1fe9bc76d

commit b39e4cecb07231262bbce0ab825c31b1fe9bc76d
Author: slangley <slangley@chromium.org>
Date: Sat Feb 25 04:45:17 2017

Replace FrameLoaderClient.h with LocalFrameClient.h and replace usage of
FrameLoaderClient with LocalFrameClient for files located under
third_party/WebKit/Source/core/frame.

*** This is just a rename CL - There are no logic changes ***

BUG= 694773 

Review-Url: https://codereview.chromium.org/2711763007
Cr-Commit-Position: refs/heads/master@{#453069}

[modify] https://crrev.com/b39e4cecb07231262bbce0ab825c31b1fe9bc76d/third_party/WebKit/Source/core/frame/Frame.cpp
[modify] https://crrev.com/b39e4cecb07231262bbce0ab825c31b1fe9bc76d/third_party/WebKit/Source/core/frame/FrameView.cpp
[modify] https://crrev.com/b39e4cecb07231262bbce0ab825c31b1fe9bc76d/third_party/WebKit/Source/core/frame/History.cpp
[modify] https://crrev.com/b39e4cecb07231262bbce0ab825c31b1fe9bc76d/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp
[modify] https://crrev.com/b39e4cecb07231262bbce0ab825c31b1fe9bc76d/third_party/WebKit/Source/core/frame/LocalFrame.cpp
[modify] https://crrev.com/b39e4cecb07231262bbce0ab825c31b1fe9bc76d/third_party/WebKit/Source/core/frame/VisualViewport.cpp
[modify] https://crrev.com/b39e4cecb07231262bbce0ab825c31b1fe9bc76d/third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.cpp

Project Member

Comment 4 by bugdroid1@chromium.org, Feb 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e339b2c841d7ed2c32ba00ba8ba2eec27c675ce9

commit e339b2c841d7ed2c32ba00ba8ba2eec27c675ce9
Author: slangley <slangley@chromium.org>
Date: Sat Feb 25 23:52:20 2017

Replace usage of FrameLoaderClient.h with LocalFrameClient.h for files in:
- bindings/v8
- bindings

*** This is just a rename CL - There are no logic changes ***

BUG= 694773 

Review-Url: https://codereview.chromium.org/2710263003
Cr-Commit-Position: refs/heads/master@{#453108}

[modify] https://crrev.com/e339b2c841d7ed2c32ba00ba8ba2eec27c675ce9/third_party/WebKit/Source/bindings/core/v8/LocalWindowProxy.cpp
[modify] https://crrev.com/e339b2c841d7ed2c32ba00ba8ba2eec27c675ce9/third_party/WebKit/Source/bindings/core/v8/RemoteWindowProxy.cpp
[modify] https://crrev.com/e339b2c841d7ed2c32ba00ba8ba2eec27c675ce9/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp
[modify] https://crrev.com/e339b2c841d7ed2c32ba00ba8ba2eec27c675ce9/third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp
[modify] https://crrev.com/e339b2c841d7ed2c32ba00ba8ba2eec27c675ce9/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp

Project Member

Comment 5 by bugdroid1@chromium.org, Feb 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7e0002a7d8f98fe00f51a9d187816cdab1c527e

commit d7e0002a7d8f98fe00f51a9d187816cdab1c527e
Author: slangley <slangley@chromium.org>
Date: Mon Feb 27 01:53:03 2017

Replace FrameLoaderClient.h with LocalFrameClient.h and replace usage of
FrameLoaderClient with LocalFrameClient for files located under
third_party/WebKit/Source/core/html.

*** This is just a rename CL - There are no logic changes ***

BUG= 694773 

Review-Url: https://codereview.chromium.org/2721473003
Cr-Commit-Position: refs/heads/master@{#453136}

[modify] https://crrev.com/d7e0002a7d8f98fe00f51a9d187816cdab1c527e/third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp
[modify] https://crrev.com/d7e0002a7d8f98fe00f51a9d187816cdab1c527e/third_party/WebKit/Source/core/html/HTMLEmbedElement.cpp
[modify] https://crrev.com/d7e0002a7d8f98fe00f51a9d187816cdab1c527e/third_party/WebKit/Source/core/html/HTMLFormControlElementWithState.cpp
[modify] https://crrev.com/d7e0002a7d8f98fe00f51a9d187816cdab1c527e/third_party/WebKit/Source/core/html/HTMLFormElement.cpp
[modify] https://crrev.com/d7e0002a7d8f98fe00f51a9d187816cdab1c527e/third_party/WebKit/Source/core/html/HTMLFrameElementBase.cpp
[modify] https://crrev.com/d7e0002a7d8f98fe00f51a9d187816cdab1c527e/third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.cpp
[modify] https://crrev.com/d7e0002a7d8f98fe00f51a9d187816cdab1c527e/third_party/WebKit/Source/core/html/HTMLFrameSetElement.cpp
[modify] https://crrev.com/d7e0002a7d8f98fe00f51a9d187816cdab1c527e/third_party/WebKit/Source/core/html/HTMLLinkElement.cpp
[modify] https://crrev.com/d7e0002a7d8f98fe00f51a9d187816cdab1c527e/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
[modify] https://crrev.com/d7e0002a7d8f98fe00f51a9d187816cdab1c527e/third_party/WebKit/Source/core/html/HTMLMetaElement.cpp
[modify] https://crrev.com/d7e0002a7d8f98fe00f51a9d187816cdab1c527e/third_party/WebKit/Source/core/html/HTMLObjectElement.cpp
[modify] https://crrev.com/d7e0002a7d8f98fe00f51a9d187816cdab1c527e/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp

Project Member

Comment 6 by bugdroid1@chromium.org, Feb 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/983682ac5f1fc3332506eb3969c23b4f8301185a

commit 983682ac5f1fc3332506eb3969c23b4f8301185a
Author: slangley <slangley@chromium.org>
Date: Mon Feb 27 03:53:34 2017

Rename all uses of EmptyFrameLoaderClient with EmptyLocalFrameClient.

In some places, the definition was being included transitively so also added
the header file for LocalFrameClient.

This is part of a larger effort to rename FrameLoaderClient to LocalFrameClient.

*** This is a rename only change - there are no logic changes ***

BUG= 694773 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2721503002
Cr-Commit-Position: refs/heads/master@{#453142}

[modify] https://crrev.com/983682ac5f1fc3332506eb3969c23b4f8301185a/third_party/WebKit/Source/core/dom/ElementVisibilityObserverTest.cpp
[modify] https://crrev.com/983682ac5f1fc3332506eb3969c23b4f8301185a/third_party/WebKit/Source/core/html/HTMLVideoElementTest.cpp
[modify] https://crrev.com/983682ac5f1fc3332506eb3969c23b4f8301185a/third_party/WebKit/Source/core/html/shadow/MediaControlsOrientationLockDelegateTest.cpp
[modify] https://crrev.com/983682ac5f1fc3332506eb3969c23b4f8301185a/third_party/WebKit/Source/core/html/shadow/MediaControlsTest.cpp
[modify] https://crrev.com/983682ac5f1fc3332506eb3969c23b4f8301185a/third_party/WebKit/Source/core/layout/LayoutObjectTest.cpp
[modify] https://crrev.com/983682ac5f1fc3332506eb3969c23b4f8301185a/third_party/WebKit/Source/core/layout/LayoutTestHelper.h
[modify] https://crrev.com/983682ac5f1fc3332506eb3969c23b4f8301185a/third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinderTest.cpp
[modify] https://crrev.com/983682ac5f1fc3332506eb3969c23b4f8301185a/third_party/WebKit/Source/core/loader/EmptyClients.cpp
[modify] https://crrev.com/983682ac5f1fc3332506eb3969c23b4f8301185a/third_party/WebKit/Source/core/loader/EmptyClients.h
[modify] https://crrev.com/983682ac5f1fc3332506eb3969c23b4f8301185a/third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp
[modify] https://crrev.com/983682ac5f1fc3332506eb3969c23b4f8301185a/third_party/WebKit/Source/core/loader/MixedContentCheckerTest.cpp
[modify] https://crrev.com/983682ac5f1fc3332506eb3969c23b4f8301185a/third_party/WebKit/Source/core/loader/PingLoaderTest.cpp
[modify] https://crrev.com/983682ac5f1fc3332506eb3969c23b4f8301185a/third_party/WebKit/Source/core/loader/ProgressTrackerTest.cpp
[modify] https://crrev.com/983682ac5f1fc3332506eb3969c23b4f8301185a/third_party/WebKit/Source/core/page/FrameTree.cpp
[modify] https://crrev.com/983682ac5f1fc3332506eb3969c23b4f8301185a/third_party/WebKit/Source/core/paint/PaintLayerClipperTest.cpp
[modify] https://crrev.com/983682ac5f1fc3332506eb3969c23b4f8301185a/third_party/WebKit/Source/core/paint/PaintLayerScrollableAreaTest.cpp
[modify] https://crrev.com/983682ac5f1fc3332506eb3969c23b4f8301185a/third_party/WebKit/Source/core/paint/PrePaintTreeWalkTest.cpp
[modify] https://crrev.com/983682ac5f1fc3332506eb3969c23b4f8301185a/third_party/WebKit/Source/core/paint/VideoPainterTest.cpp
[modify] https://crrev.com/983682ac5f1fc3332506eb3969c23b4f8301185a/third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp
[modify] https://crrev.com/983682ac5f1fc3332506eb3969c23b4f8301185a/third_party/WebKit/Source/core/testing/DummyPageHolder.cpp
[modify] https://crrev.com/983682ac5f1fc3332506eb3969c23b4f8301185a/third_party/WebKit/Source/modules/webaudio/BaseAudioContextTest.cpp
[modify] https://crrev.com/983682ac5f1fc3332506eb3969c23b4f8301185a/third_party/WebKit/Source/web/InspectorOverlay.cpp
[modify] https://crrev.com/983682ac5f1fc3332506eb3969c23b4f8301185a/third_party/WebKit/Source/web/WebPagePopupImpl.cpp

Project Member

Comment 7 by bugdroid1@chromium.org, Feb 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3188f925b5c11711a53b2dd31e55c4b3cb0a13bc

commit 3188f925b5c11711a53b2dd31e55c4b3cb0a13bc
Author: slangley <slangley@chromium.org>
Date: Mon Feb 27 05:09:02 2017

Rename classes that derived from EmptyLocalFrameClient.

Renamed classes include:
* MockFrameLoaderClient -> MockLocalFrameClient
* FrameLoaderClientWithParent -> LocalFrameClientWithParent
* SingleChildFrameLoaderClient -> SingleChildLocalFrameClient
* StubFrameLoaderClient -> StubLocalFrameClient

*** This is a rename change only - There are no logic changes. ***

BUG= 694773 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2719813002
Cr-Commit-Position: refs/heads/master@{#453154}

[modify] https://crrev.com/3188f925b5c11711a53b2dd31e55c4b3cb0a13bc/third_party/WebKit/Source/core/dom/ElementVisibilityObserverTest.cpp
[modify] https://crrev.com/3188f925b5c11711a53b2dd31e55c4b3cb0a13bc/third_party/WebKit/Source/core/html/HTMLVideoElementTest.cpp
[modify] https://crrev.com/3188f925b5c11711a53b2dd31e55c4b3cb0a13bc/third_party/WebKit/Source/core/html/shadow/MediaControlsOrientationLockDelegateTest.cpp
[modify] https://crrev.com/3188f925b5c11711a53b2dd31e55c4b3cb0a13bc/third_party/WebKit/Source/core/html/shadow/MediaControlsTest.cpp
[modify] https://crrev.com/3188f925b5c11711a53b2dd31e55c4b3cb0a13bc/third_party/WebKit/Source/core/layout/LayoutTestHelper.cpp
[modify] https://crrev.com/3188f925b5c11711a53b2dd31e55c4b3cb0a13bc/third_party/WebKit/Source/core/layout/LayoutTestHelper.h
[modify] https://crrev.com/3188f925b5c11711a53b2dd31e55c4b3cb0a13bc/third_party/WebKit/Source/core/layout/MapCoordinatesTest.cpp
[modify] https://crrev.com/3188f925b5c11711a53b2dd31e55c4b3cb0a13bc/third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp
[modify] https://crrev.com/3188f925b5c11711a53b2dd31e55c4b3cb0a13bc/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp
[modify] https://crrev.com/3188f925b5c11711a53b2dd31e55c4b3cb0a13bc/third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp
[modify] https://crrev.com/3188f925b5c11711a53b2dd31e55c4b3cb0a13bc/third_party/WebKit/Source/core/loader/MixedContentCheckerTest.cpp
[modify] https://crrev.com/3188f925b5c11711a53b2dd31e55c4b3cb0a13bc/third_party/WebKit/Source/core/page/PrintContextTest.cpp
[modify] https://crrev.com/3188f925b5c11711a53b2dd31e55c4b3cb0a13bc/third_party/WebKit/Source/core/paint/BoxPaintInvalidatorTest.cpp
[modify] https://crrev.com/3188f925b5c11711a53b2dd31e55c4b3cb0a13bc/third_party/WebKit/Source/core/paint/PaintLayerTest.cpp
[modify] https://crrev.com/3188f925b5c11711a53b2dd31e55c4b3cb0a13bc/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.h
[modify] https://crrev.com/3188f925b5c11711a53b2dd31e55c4b3cb0a13bc/third_party/WebKit/Source/core/paint/PaintPropertyTreePrinterTest.cpp
[modify] https://crrev.com/3188f925b5c11711a53b2dd31e55c4b3cb0a13bc/third_party/WebKit/Source/core/paint/VideoPainterTest.cpp

Project Member

Comment 8 by bugdroid1@chromium.org, Feb 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a2e69bfc0c4c828211ec6b0ece0d26bc8aecd5f

commit 8a2e69bfc0c4c828211ec6b0ece0d26bc8aecd5f
Author: slangley <slangley@chromium.org>
Date: Mon Feb 27 07:09:07 2017

Rename FrameLoaderClient* to LocalFrameClient* in web/

Remove no longer referenced FrameLoaderClientImpl.h

*** This is a rename cl only - there are no logic changes ***

BUG= 694773 

Review-Url: https://codereview.chromium.org/2712343003
Cr-Commit-Position: refs/heads/master@{#453164}

[modify] https://crrev.com/8a2e69bfc0c4c828211ec6b0ece0d26bc8aecd5f/third_party/WebKit/Source/web/AssertMatchingEnums.cpp
[modify] https://crrev.com/8a2e69bfc0c4c828211ec6b0ece0d26bc8aecd5f/third_party/WebKit/Source/web/BUILD.gn
[delete] https://crrev.com/ca9bdd5d277923120dd3be9955023cc48a817ecb/third_party/WebKit/Source/web/FrameLoaderClientImpl.h
[modify] https://crrev.com/8a2e69bfc0c4c828211ec6b0ece0d26bc8aecd5f/third_party/WebKit/Source/web/RemoteFrameClientImpl.cpp
[modify] https://crrev.com/8a2e69bfc0c4c828211ec6b0ece0d26bc8aecd5f/third_party/WebKit/Source/web/WebHelperPluginImpl.cpp
[modify] https://crrev.com/8a2e69bfc0c4c828211ec6b0ece0d26bc8aecd5f/third_party/WebKit/Source/web/WebHelperPluginImpl.h
[modify] https://crrev.com/8a2e69bfc0c4c828211ec6b0ece0d26bc8aecd5f/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
[modify] https://crrev.com/8a2e69bfc0c4c828211ec6b0ece0d26bc8aecd5f/third_party/WebKit/Source/web/WebLocalFrameImpl.h
[modify] https://crrev.com/8a2e69bfc0c4c828211ec6b0ece0d26bc8aecd5f/third_party/WebKit/Source/web/WebNode.cpp
[modify] https://crrev.com/8a2e69bfc0c4c828211ec6b0ece0d26bc8aecd5f/third_party/WebKit/Source/web/WebViewImpl.cpp
[modify] https://crrev.com/8a2e69bfc0c4c828211ec6b0ece0d26bc8aecd5f/third_party/WebKit/public/web/WebSettings.h

Project Member

Comment 9 by bugdroid1@chromium.org, Feb 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/de7db06819bf2fa12037d90e666bafe463a86d7b

commit de7db06819bf2fa12037d90e666bafe463a86d7b
Author: slangley <slangley@chromium.org>
Date: Mon Feb 27 09:48:42 2017

Move to core/frame/LocalFrameClient.h instead of core/loader/FrameLoaderClient.h

This only changes files where there we no other references to FrameLoaderClient,
only the inclusion of the header file.

*** This is a rename change only - there are no logic changes. ***

BUG= 694773 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2720633002
Cr-Commit-Position: refs/heads/master@{#453177}

[modify] https://crrev.com/de7db06819bf2fa12037d90e666bafe463a86d7b/third_party/WebKit/Source/core/html/ImageDocument.cpp
[modify] https://crrev.com/de7db06819bf2fa12037d90e666bafe463a86d7b/third_party/WebKit/Source/core/html/LinkManifest.cpp
[modify] https://crrev.com/de7db06819bf2fa12037d90e666bafe463a86d7b/third_party/WebKit/Source/core/html/LinkStyle.cpp
[modify] https://crrev.com/de7db06819bf2fa12037d90e666bafe463a86d7b/third_party/WebKit/Source/core/html/MediaDocument.cpp
[modify] https://crrev.com/de7db06819bf2fa12037d90e666bafe463a86d7b/third_party/WebKit/Source/core/html/PluginDocument.cpp
[modify] https://crrev.com/de7db06819bf2fa12037d90e666bafe463a86d7b/third_party/WebKit/Source/core/html/parser/HTMLConstructionSite.cpp
[modify] https://crrev.com/de7db06819bf2fa12037d90e666bafe463a86d7b/third_party/WebKit/Source/core/html/parser/XSSAuditorDelegate.cpp
[modify] https://crrev.com/de7db06819bf2fa12037d90e666bafe463a86d7b/third_party/WebKit/Source/core/input/EventHandler.cpp
[modify] https://crrev.com/de7db06819bf2fa12037d90e666bafe463a86d7b/third_party/WebKit/Source/core/input/KeyboardEventManager.cpp
[modify] https://crrev.com/de7db06819bf2fa12037d90e666bafe463a86d7b/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp
[modify] https://crrev.com/de7db06819bf2fa12037d90e666bafe463a86d7b/third_party/WebKit/Source/core/loader/CookieJar.cpp
[modify] https://crrev.com/de7db06819bf2fa12037d90e666bafe463a86d7b/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
[modify] https://crrev.com/de7db06819bf2fa12037d90e666bafe463a86d7b/third_party/WebKit/Source/core/loader/NavigationScheduler.cpp
[modify] https://crrev.com/de7db06819bf2fa12037d90e666bafe463a86d7b/third_party/WebKit/Source/core/loader/PingLoader.cpp
[modify] https://crrev.com/de7db06819bf2fa12037d90e666bafe463a86d7b/third_party/WebKit/Source/core/loader/ProgressTracker.cpp
[modify] https://crrev.com/de7db06819bf2fa12037d90e666bafe463a86d7b/third_party/WebKit/Source/core/loader/appcache/ApplicationCacheHost.cpp
[modify] https://crrev.com/de7db06819bf2fa12037d90e666bafe463a86d7b/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
[modify] https://crrev.com/de7db06819bf2fa12037d90e666bafe463a86d7b/third_party/WebKit/Source/core/workers/SharedWorker.cpp
[modify] https://crrev.com/de7db06819bf2fa12037d90e666bafe463a86d7b/third_party/WebKit/Source/core/xml/XSLTProcessor.cpp
[modify] https://crrev.com/de7db06819bf2fa12037d90e666bafe463a86d7b/third_party/WebKit/Source/modules/donottrack/NavigatorDoNotTrack.cpp
[modify] https://crrev.com/de7db06819bf2fa12037d90e666bafe463a86d7b/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp
[modify] https://crrev.com/de7db06819bf2fa12037d90e666bafe463a86d7b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerClient.cpp
[modify] https://crrev.com/de7db06819bf2fa12037d90e666bafe463a86d7b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerLinkResource.cpp
[modify] https://crrev.com/de7db06819bf2fa12037d90e666bafe463a86d7b/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContext.cpp
[modify] https://crrev.com/de7db06819bf2fa12037d90e666bafe463a86d7b/third_party/WebKit/Source/modules/webgl/WebGLRenderingContext.cpp
[modify] https://crrev.com/de7db06819bf2fa12037d90e666bafe463a86d7b/third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp

Project Member

Comment 10 by bugdroid1@chromium.org, Feb 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/16bd9a5826c9ff951b7f7def34c619b3a2d31858

commit 16bd9a5826c9ff951b7f7def34c619b3a2d31858
Author: slangley <slangley@chromium.org>
Date: Mon Feb 27 11:10:25 2017

Final rename from FrameLoaderClient to LocalFrameClient:

- Change all includes of FrameLoaderClient.h to LocalFrameClient.h
- Update all references to LocalFrameClient and rename variables are required.
- Remove FrameLoaderClient.h

*** This is a rename CL only - there are not logic changes. ***

BUG= 694773 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2715173002
Cr-Commit-Position: refs/heads/master@{#453187}

[modify] https://crrev.com/16bd9a5826c9ff951b7f7def34c619b3a2d31858/third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp
[modify] https://crrev.com/16bd9a5826c9ff951b7f7def34c619b3a2d31858/third_party/WebKit/Source/core/dom/CSSSelectorWatch.cpp
[modify] https://crrev.com/16bd9a5826c9ff951b7f7def34c619b3a2d31858/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/16bd9a5826c9ff951b7f7def34c619b3a2d31858/third_party/WebKit/Source/core/dom/DocumentUserGestureToken.h
[modify] https://crrev.com/16bd9a5826c9ff951b7f7def34c619b3a2d31858/third_party/WebKit/Source/core/dom/ElementVisibilityObserverTest.cpp
[modify] https://crrev.com/16bd9a5826c9ff951b7f7def34c619b3a2d31858/third_party/WebKit/Source/core/frame/FrameClient.h
[modify] https://crrev.com/16bd9a5826c9ff951b7f7def34c619b3a2d31858/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp
[modify] https://crrev.com/16bd9a5826c9ff951b7f7def34c619b3a2d31858/third_party/WebKit/Source/core/layout/LayoutTestHelper.cpp
[modify] https://crrev.com/16bd9a5826c9ff951b7f7def34c619b3a2d31858/third_party/WebKit/Source/core/layout/LayoutTestHelper.h
[modify] https://crrev.com/16bd9a5826c9ff951b7f7def34c619b3a2d31858/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp
[modify] https://crrev.com/16bd9a5826c9ff951b7f7def34c619b3a2d31858/third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp
[modify] https://crrev.com/16bd9a5826c9ff951b7f7def34c619b3a2d31858/third_party/WebKit/Source/core/loader/FrameLoader.cpp
[delete] https://crrev.com/3f27e52ec5d3ab082fc1b8cb4835cbefbac0ce6f/third_party/WebKit/Source/core/loader/FrameLoaderClient.h
[modify] https://crrev.com/16bd9a5826c9ff951b7f7def34c619b3a2d31858/third_party/WebKit/Source/core/loader/MixedContentChecker.cpp
[modify] https://crrev.com/16bd9a5826c9ff951b7f7def34c619b3a2d31858/third_party/WebKit/Source/core/loader/PingLoaderTest.cpp
[modify] https://crrev.com/16bd9a5826c9ff951b7f7def34c619b3a2d31858/third_party/WebKit/Source/core/page/PrintContextTest.cpp
[modify] https://crrev.com/16bd9a5826c9ff951b7f7def34c619b3a2d31858/third_party/WebKit/Source/core/paint/VideoPainterTest.cpp
[modify] https://crrev.com/16bd9a5826c9ff951b7f7def34c619b3a2d31858/third_party/WebKit/Source/core/testing/DummyPageHolder.cpp
[modify] https://crrev.com/16bd9a5826c9ff951b7f7def34c619b3a2d31858/third_party/WebKit/Source/core/testing/DummyPageHolder.h
[modify] https://crrev.com/16bd9a5826c9ff951b7f7def34c619b3a2d31858/third_party/WebKit/Source/modules/webaudio/BaseAudioContextTest.cpp
[modify] https://crrev.com/16bd9a5826c9ff951b7f7def34c619b3a2d31858/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
[modify] https://crrev.com/16bd9a5826c9ff951b7f7def34c619b3a2d31858/tools/valgrind/memcheck/suppressions.txt

Comment 11 by slangley@chromium.org, Feb 27 2017

Status: Verified (was: Started)

►

Issue 694773 link

Issue metadata

Rename FrameLoaderClient to LocalFrameClient.

Issue description

Comment 1 by slangley@chromium.org, Feb 21 2017

Comment 1 Deleted

Comment 2 by bugdroid1@chromium.org, Feb 24 2017

Comment 2 Deleted

Comment 3 by bugdroid1@chromium.org, Feb 25 2017

Comment 3 Deleted

Comment 4 by bugdroid1@chromium.org, Feb 25 2017

Comment 4 Deleted

Comment 5 by bugdroid1@chromium.org, Feb 27 2017

Comment 5 Deleted

Comment 6 by bugdroid1@chromium.org, Feb 27 2017

Comment 6 Deleted

Comment 7 by bugdroid1@chromium.org, Feb 27 2017

Comment 7 Deleted

Comment 8 by bugdroid1@chromium.org, Feb 27 2017

Comment 8 Deleted

Comment 9 by bugdroid1@chromium.org, Feb 27 2017

Comment 9 Deleted

Comment 10 by bugdroid1@chromium.org, Feb 27 2017

Comment 10 Deleted

Comment 11 by slangley@chromium.org, Feb 27 2017

Comment 11 Deleted

Sign in to add a comment