New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 694766 link

Starred by 2 users

Issue metadata

Status: Archived
Owner: ----
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

ssh_host.run() converts ignore_status flag to stderr_is_expected

Project Member Reported by semenzato@chromium.org, Feb 21 2017

Issue description

The code for _run() (called by run()) in server/host/ssh_host.py:

        result = utils.run(full_cmd, timeout, True, stdout, stderr,
                           verbose=False, stdin=stdin,
                           stderr_is_expected=ignore_status,
                           ignore_timeout=ignore_timeout)

This confuses me, and may be wrong.  From client/common_lib/base_utils.py:

    @param stderr_is_expected: if True, stderr will be logged at the same level
            as stdout

so that parameter only impacts logging.  If ignore_status is True (which cannot happen when called by ssh_host._run()), the call will return the status of the command, otherwise it will throw an exception when the status is non-zero.  Ssh_host.run() accepts the keyword parameter ignore_status, but doesn't document it.
 
Cc: snanda@chromium.org

Comment 2 by autumn@chromium.org, Mar 15 2017

Labels: Hotlist-Fixit
Status: Archived (was: Untriaged)
This bug is very old, is Untriaged, and has no owner.  If it is still relevant, reopen as Untriaged or open a new bug

Sign in to add a comment