New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 694761 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

Console in dedicated DevTools for Node is broken

Project Member Reported by phulce@chromium.org, Feb 21 2017

Issue description

Chrome Version: 58.0.3019.0 (Official Build) canary (64-bit)
OS: OS X 10.12.3

What steps will reproduce the problem?
(1) Navigate to chrome://inspect
(2) Click "Open dedicated DevTools for Node"
(3) Launch any node process with --inspect and --debug-brk flags
(4) Enter text into the DevTools console and hit enter

What is the expected result? Console output appears in console pane

What happens instead? Nothing (console output does appear in the attached node process though)



For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

 
dedicated node devtools.mp4
579 KB View Download
Labels: -Pri-2 ReleaseBlock-Stable Pri-1
Owner: eostroukhov@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/13edaa9f1b449a0de7fb6529c5227751668a4ec9

commit 13edaa9f1b449a0de7fb6529c5227751668a4ec9
Author: eostroukhov <eostroukhov@chromium.org>
Date: Wed Mar 01 22:00:22 2017

[DevTools] Console should wait for the main target

BUG= 694761 

Review-Url: https://codereview.chromium.org/2726933002
Cr-Commit-Position: refs/heads/master@{#454054}

[modify] https://crrev.com/13edaa9f1b449a0de7fb6529c5227751668a4ec9/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js

Status: Fixed (was: Assigned)
Labels: Merge-Request-57
Is this a regression on M57?
No, this is a major bug in a new functionality introduced in M57. It makes it impossible for most users to use Devtools to debug Node.JS applications.
Before we approve merge to M57, could you please confirm change is well baked/verified in canary, had enough automation test coverage and will be a safe merge to M57?
Labels: M-57 M-58
I don't think the change made it to Canary yet. I will update the bug once I verified it is fixed in Canary.
eostroukhov@, Latest Mac Canary #58.0.3028.3 got pushed @ 1:30 PM PT today (few mins back). Please verify the change. Thank you.
Thanks for the ping. I manually confirmed that bug was there for pre-update Canary and went away post update. Our automated tests tell me there are no regressions.

Thank you!
Project Member

Comment 12 by sheriffbot@chromium.org, Mar 2 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 13 by bugdroid1@chromium.org, Mar 3 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/135dd9d1d83609b2a0c4c0458f9b9cdb5b46b68a

commit 135dd9d1d83609b2a0c4c0458f9b9cdb5b46b68a
Author: eostroukhov <eostroukhov@chromium.org>
Date: Fri Mar 03 23:48:58 2017

[DevTools] Console should wait for the main target

BUG= 694761 
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2726933002
Cr-Commit-Position: refs/heads/master@{#454054}
(cherry picked from commit 13edaa9f1b449a0de7fb6529c5227751668a4ec9)

Review-Url: https://codereview.chromium.org/2733463003
Cr-Commit-Position: refs/branch-heads/2987@{#759}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/135dd9d1d83609b2a0c4c0458f9b9cdb5b46b68a/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js

Cc: pbomm...@chromium.org gov...@chromium.org
Labels: Needs-Feedback
Can some one please help us a sample test file to execute step 3. This will help us to verify the issue.

Thanks.!
This can be reproduced by running node with an endless loop - e.g. 'node --inspect -e "while(true);"'
Cc: ranjitkan@chromium.org
Labels: TE-Verified-M59 TE-Verified-59.0.3032.0
@eostroukhov: Thanks a lot for the details provided.

Rechecked the issue on chrome canary version 59.0.3032.0 on MAC 10.12.3 by following the below steps:

1) Installed Node and from terminal executed node --inspect -e "while(true);"
2) Got the debugging URL to run on chrome.
3) Navigated to chrome://inspect and clicked on "Open dedicated DevTools for Node" link
4) In console typed "console.log("Hello"); and hit enter.

Observed that "Hello" was printed in the console. Fix is working as intended. Adding TE-Verified labels.

Thanks.!

Comment 17 by ajha@chromium.org, Mar 7 2017

Labels: TE-Verified-M58 TE-Verified-58.0.3029.6
Fix landed before the M-58 branch. However, just to update, verified the fix on the latest M-58(58.0.3029.6) on Mac OS 10.12.3 as well. This is working as intended as per the above test steps and 'Hello' is printed in the console.

Attached is the screenshot.
694761.png
333 KB View Download
Labels: TE-Verified-57.0.2987.96 TE-Verified-M57
Verified this issue on Mac OS 10.12 using chrome latest M57 #57.0.2987.96 by following steps mentioned in the comment #16, observed dedicated dev tools for node is displaying the results and working as expected. Hence adding TE-Verified label.
Screen Shot 2017-03-08 at 2.27.25 PM.png
163 KB View Download

Comment 19 by kgra...@gmail.com, Mar 20 2017

I'm getting duplicate console.log messages each time it attaches.
Three screenshots, each time I ctrl-C the node.js process and start it up again.

Chrome canary 59.0.3046.0 (Official Build) canary (64-bit)
Revision	6719c20584c6c916a4f5820a0f3b458ab612dfad-refs/heads/master@{#457952}

node v7.7.3
Screen Shot 2017-03-20 at 12.22.16 PM.png
12.5 KB View Download
Screen Shot 2017-03-20 at 12.22.23 PM.png
25.3 KB View Download
Screen Shot 2017-03-20 at 12.22.29 PM.png
42.8 KB View Download
kgraehl@gmail.com that issue is tracked separately.
See https://bugs.chromium.org/p/chromium/issues/detail?id=698823 to follow.

Sign in to add a comment