Console in dedicated DevTools for Node is broken |
||||||||||
Issue descriptionChrome Version: 58.0.3019.0 (Official Build) canary (64-bit) OS: OS X 10.12.3 What steps will reproduce the problem? (1) Navigate to chrome://inspect (2) Click "Open dedicated DevTools for Node" (3) Launch any node process with --inspect and --debug-brk flags (4) Enter text into the DevTools console and hit enter What is the expected result? Console output appears in console pane What happens instead? Nothing (console output does appear in the attached node process though) For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Mar 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/13edaa9f1b449a0de7fb6529c5227751668a4ec9 commit 13edaa9f1b449a0de7fb6529c5227751668a4ec9 Author: eostroukhov <eostroukhov@chromium.org> Date: Wed Mar 01 22:00:22 2017 [DevTools] Console should wait for the main target BUG= 694761 Review-Url: https://codereview.chromium.org/2726933002 Cr-Commit-Position: refs/heads/master@{#454054} [modify] https://crrev.com/13edaa9f1b449a0de7fb6529c5227751668a4ec9/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
,
Mar 1 2017
,
Mar 1 2017
,
Mar 2 2017
Is this a regression on M57?
,
Mar 2 2017
No, this is a major bug in a new functionality introduced in M57. It makes it impossible for most users to use Devtools to debug Node.JS applications.
,
Mar 2 2017
Before we approve merge to M57, could you please confirm change is well baked/verified in canary, had enough automation test coverage and will be a safe merge to M57?
,
Mar 2 2017
,
Mar 2 2017
I don't think the change made it to Canary yet. I will update the bug once I verified it is fixed in Canary.
,
Mar 2 2017
eostroukhov@, Latest Mac Canary #58.0.3028.3 got pushed @ 1:30 PM PT today (few mins back). Please verify the change. Thank you.
,
Mar 2 2017
Thanks for the ping. I manually confirmed that bug was there for pre-update Canary and went away post update. Our automated tests tell me there are no regressions. Thank you!
,
Mar 2 2017
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/135dd9d1d83609b2a0c4c0458f9b9cdb5b46b68a commit 135dd9d1d83609b2a0c4c0458f9b9cdb5b46b68a Author: eostroukhov <eostroukhov@chromium.org> Date: Fri Mar 03 23:48:58 2017 [DevTools] Console should wait for the main target BUG= 694761 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2726933002 Cr-Commit-Position: refs/heads/master@{#454054} (cherry picked from commit 13edaa9f1b449a0de7fb6529c5227751668a4ec9) Review-Url: https://codereview.chromium.org/2733463003 Cr-Commit-Position: refs/branch-heads/2987@{#759} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} [modify] https://crrev.com/135dd9d1d83609b2a0c4c0458f9b9cdb5b46b68a/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
,
Mar 6 2017
Can some one please help us a sample test file to execute step 3. This will help us to verify the issue. Thanks.!
,
Mar 6 2017
This can be reproduced by running node with an endless loop - e.g. 'node --inspect -e "while(true);"'
,
Mar 7 2017
@eostroukhov: Thanks a lot for the details provided.
Rechecked the issue on chrome canary version 59.0.3032.0 on MAC 10.12.3 by following the below steps:
1) Installed Node and from terminal executed node --inspect -e "while(true);"
2) Got the debugging URL to run on chrome.
3) Navigated to chrome://inspect and clicked on "Open dedicated DevTools for Node" link
4) In console typed "console.log("Hello"); and hit enter.
Observed that "Hello" was printed in the console. Fix is working as intended. Adding TE-Verified labels.
Thanks.!
,
Mar 7 2017
Fix landed before the M-58 branch. However, just to update, verified the fix on the latest M-58(58.0.3029.6) on Mac OS 10.12.3 as well. This is working as intended as per the above test steps and 'Hello' is printed in the console. Attached is the screenshot.
,
Mar 8 2017
Verified this issue on Mac OS 10.12 using chrome latest M57 #57.0.2987.96 by following steps mentioned in the comment #16, observed dedicated dev tools for node is displaying the results and working as expected. Hence adding TE-Verified label.
,
Mar 20 2017
I'm getting duplicate console.log messages each time it attaches. Three screenshots, each time I ctrl-C the node.js process and start it up again. Chrome canary 59.0.3046.0 (Official Build) canary (64-bit) Revision 6719c20584c6c916a4f5820a0f3b458ab612dfad-refs/heads/master@{#457952} node v7.7.3
,
Mar 20 2017
kgraehl@gmail.com that issue is tracked separately. See https://bugs.chromium.org/p/chromium/issues/detail?id=698823 to follow. |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by lushnikov@chromium.org
, Feb 24 2017Owner: eostroukhov@chromium.org
Status: Assigned (was: Untriaged)