When Google is not the default search engine, search button should include name of engine |
|||
Issue descriptionChrome 58.0.3019.0 From the PRD: for another DSE, use generic magnifying glass and “Search [engine name]” eg Search Bing.
,
Feb 21 2017
I see. I think that was my mistake. The PRD says “Search [engine name]”, which will be shorter than the default text for Google ("Search or type URL"). The search engine names are not very long.
,
Feb 21 2017
The default ones are not, but it's possible to edit their names and add other search engines with longer names. This is a edge case with a very, very low chance though, so we probably don't need to worry too much it. Worst case, the text will be cut off in the button. Forgot to mention this too, the search engine name might make the text a bit strange too. For Yahoo, the name contains an exclamation mark so the string will come out as "Search Yahoo! or type URL". These are nitpicks though, if we're not too concerned about this, I'll make the text change when I add the G search icon back in. Note: This is a search engine that appeared under "Other Search" thanks to my history The Riverwood Conservancy http://www.theriverwoodconservancy.org/index.php?option=com_search&searchword=%s
,
Feb 21 2017
Per the PRD the Yahoo case would be "Search Yahoo!" not "Search Yahoo! or type URL" (for the record).
,
Feb 22 2017
Oh sorry, I misunderstood #2 and mixed the strings up. Sure things, that sounds good to me. Can you link me to the PRD? The only specs I've been getting is from Issue 675254
,
Feb 24 2017
,
Feb 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c73de4e7f56bfa4ece4ebb69086861ae40f17564 commit c73de4e7f56bfa4ece4ebb69086861ae40f17564 Author: spqchan <spqchan@chromium.org> Date: Fri Feb 24 18:15:23 2017 [Mac] Adjustments to the Default State Touch Bar - Modified the text on the search button - Use Google Search icon when the default search provider is Google - New Tab button moved to the back - Active star color should be blue BUG= 694754 , 694760 , 694756 , 694753 Review-Url: https://codereview.chromium.org/2711443003 Cr-Commit-Position: refs/heads/master@{#452874} [modify] https://crrev.com/c73de4e7f56bfa4ece4ebb69086861ae40f17564/chrome/app/generated_resources.grd [modify] https://crrev.com/c73de4e7f56bfa4ece4ebb69086861ae40f17564/chrome/browser/ui/cocoa/browser_window_touch_bar.mm [modify] https://crrev.com/c73de4e7f56bfa4ece4ebb69086861ae40f17564/ui/gfx/vector_icons/BUILD.gn [add] https://crrev.com/c73de4e7f56bfa4ece4ebb69086861ae40f17564/ui/gfx/vector_icons/google_search_mac_touchbar.icon
,
Feb 24 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by spqc...@chromium.org
, Feb 21 2017Cc: bettes@chromium.org