Cookies Table: Delete Selected button should be disabled if there is nothing to delete
Reported by
kdzwinel@gmail.com,
Feb 21 2017
|
||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3018.0 Safari/537.36 Steps to reproduce the problem: 1. Go to Application > Cookies Table 2. Remove all cookies 3. Select first row What is the expected behavior? "Remove Selected" button should be disabled What went wrong? "Remove Selected" is enabled. This is inconsistent with Storage tables. Did this work before? No Chrome version: 58.0.3018.0 Channel: n/a OS Version: OS X 10.12.3 Flash Version: TBH it's weird that "Remove Selected" is not always disabled for the "add new" (creationNode) rows, but only when the table is empty.
,
Feb 22 2017
Able to reproduce this issue on Mac 10.12.2, Ubuntu 14.04& windows 7 using chrome reported version -58.0.3018.0 and latest Canary-58.0.3019.0 . Issue seen from 58.0.2994.0 to latest Canary and observed no records after deleting all rows from cookies ( 'This site has no cookies' message displayed) in the earlier builds of 58.0.2993.0. As this is non regression issue, marking it as Untriaged. Please find the attached screencast of 58.0.2993.0 for reference. Thanks!!
,
Feb 24 2017
Eric, could you please take a look?
,
Mar 21 2017
I started it here: https://codereview.chromium.org/2764903002
,
Mar 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1a4a8261d05a2700334f969dae54dbdce05002c3 commit 1a4a8261d05a2700334f969dae54dbdce05002c3 Author: kdzwinel <kdzwinel@gmail.com> Date: Wed Mar 22 20:40:41 2017 DevTools: Disable delete button if selected node is not associated with any cookie object Now it works like this: http://i.imgur.com/bVLesi7.gif BUG= 694759 Review-Url: https://codereview.chromium.org/2764903002 Cr-Commit-Position: refs/heads/master@{#458863} [modify] https://crrev.com/1a4a8261d05a2700334f969dae54dbdce05002c3/third_party/WebKit/Source/devtools/front_end/resources/CookieItemsView.js
,
Mar 28 2017
Thanks kdzwinel@! |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by ajha@chromium.org
, Feb 22 2017