New issue
Advanced search Search tips

Issue 694758 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Feb 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

DCHECK in OOBE

Project Member Reported by sky@chromium.org, Feb 21 2017

Issue description

rm -rf /tmp/xx ; ./out/Debug2/chrome --login-manager --disable-setuid-sandbox --no-sandbox --user-data-dir=/tmp/xx --ozone-platform=x11

. Connect to a network.
. Don't sign in, instead click browse as guest

Hit this DCHECK:
sky@sky:/tertiary/builds/build2/src$ [100787:100787:0221/141352.436940:FATAL:profile_helper.cc(108)] Check failed: !user_id_hash.empty().
#0 0x7f17746efc9b base::debug::StackTrace::StackTrace()
#1 0x7f17746ee31c base::debug::StackTrace::StackTrace()
#2 0x7f177475499c logging::LogMessage::~LogMessage()
#3 0x7f17768c1812 chromeos::ProfileHelper::GetProfilePathByUserIdHash()
#4 0x7f177664c3c6 chromeos::UserSessionManager::OverrideHomedir()
#5 0x7f17766d76c7 chromeos::ChromeUserManagerImpl::NotifyOnLogin()
#6 0x7f176662e765 user_manager::UserManagerBase::UserLoggedIn()
#7 0x7f17632b3bfb session_manager::SessionManager::NotifyUserLoggedIn()
#8 0x7f177664c18e chromeos::ChromeSessionManager::NotifyUserLoggedIn()
#9 0x7f17632b3a48 session_manager::SessionManager::CreateSessionInternal()
#10 0x7f17632b3a8a session_manager::SessionManager::CreateSessionForRestart()
#11 0x7f17763bb357 chromeos::ChromeBrowserMainPartsChromeos::PreProfileInit()
#12 0x7f177743dcc1 ChromeBrowserMainParts::PreMainMessageLoopRunImpl()
#13 0x7f177743d320 ChromeBrowserMainParts::PreMainMessageLoopRun()
#14 0x7f17763bae14 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun()
#15 0x7f176df191f1 content::BrowserMainLoop::PreMainMessageLoopRun()
#16 0x7f176d4896e5 _ZN4base8internal13FunctorTraitsIMN7content22IndexedDBCallbacksImpl13InternalStateEFvvEvE6InvokeIPS4_JEEEvS6_OT_DpOT0_
#17 0x7f176df23411 _ZN4base8internal12InvokeHelperILb0EiE8MakeItSoIRKMN7content15BrowserMainLoopEFivEJPS5_EEEiOT_DpOT0_
#18 0x7f176df233b7 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE7RunImplIRKS6_RKSt5tupleIJS8_EEJL\
m0EEEEiOT_OT0_NS_13IndexSequenceIJXspT1_EEEE
#19 0x7f176df232fc _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE3RunEPNS0_13BindStateBaseE
#20 0x7f176d37a25b base::internal::RunMixin<>::Run()
#21 0x7f176ea04a3b content::StartupTaskRunner::RunAllTasksNow()
#22 0x7f176df16ed0 content::BrowserMainLoop::CreateStartupTasks()
#23 0x7f176df26e97 content::BrowserMainRunnerImpl::Initialize()
#24 0x7f176df135bf content::BrowserMain()
#25 0x7f176f5b2af6 content::RunNamedProcessTypeMain()
#26 0x7f176f5b4b0e content::ContentMainRunnerImpl::Run()
#27 0x7f176f5b1b32 content::ContentMain()
#28 0x7f17756f69b6 ChromeMain
#29 0x7f17756f6872 main
#30 0x7f175e5b6f45 __libc_start_main
#31 0x7f17756f6775 <unknown>

I didn't try a release build to see if this is fatal.
 

Comment 1 by xiy...@chromium.org, Feb 21 2017

Are you running on device? Or your dev box?

"Browse as guest" would need help from the session manager deamon. The chrome code would set the guest command line and asks the daemon to restart chrome with the command line.

Comment 2 by sky@chromium.org, Feb 21 2017

This is not on a device but my local machine. I listed the command line args I'm supplying above. Maybe I have them wrong?

Comment 3 by xiy...@chromium.org, Feb 21 2017

Okay. Toni recently made "Browse as guest" work on dev boxes.

Having

  --login-profile=user

would make the DCHECK go away. [1] is where the value of the switch is fetched as user id hash. Not sure why guest login still uses that though. 

[1]: https://cs.chromium.org/chromium/src/chrome/browser/chromeos/chrome_browser_main_chromeos.cc?rcl=dd47ba396451348cc15ecbc53255cb618e457414&l=586

Comment 4 by sky@chromium.org, Feb 21 2017

Status: WontFix (was: Untriaged)
Ok, thanks for the pointer. I' close this out as it looks like it's my fault.

Sign in to add a comment