Google "G" is missing from the Touch Bar when Google is default search engine |
||||
Issue descriptionChrome 58.0.3019.0 I don't see the Google "G" in the Touch Bar.
,
Feb 21 2017
Can you reexplain c#1? I don't fully understand what you're saying. For now can you just land the icon somewhere so that we get some air time with it before branch? Unless what you're talking about in c#1 will happen in the next few days? I am of course not against the icon living in the "right" spot, but we should not be blocking waiting for the right spot to happen.
,
Feb 21 2017
So the icon should probably go into src-internal, estade@ was looking into that. To ensure that the CL landed before the feature freeze, I removed the G search icon and is planning to add it back in a follow up CL once things are figured out. Will aim to get that done within the next few days
,
Feb 22 2017
I don't think we need to put any assets in src-internal, but while that debate simmers, I think we can go ahead and put this one in src/. Iconography for Google services that we connect to already lives in src/, for example the Google Translate png in //ui/resources. The only things in src-internal are google chrome specific, but presumably a build of chromium that uses Google as the search engine would still want this G.
,
Feb 22 2017
Thank you estade@ for helping move this along.
,
Feb 22 2017
Awesome thanks!
,
Feb 24 2017
Hi spqchan@, what is the status of this bug (and the other two issues I reported)? We need to send this to UI review and M58 branch is in less than 1 week.
,
Feb 24 2017
In review: https://codereview.chromium.org/2711443003/ I shall ping it
,
Feb 24 2017
OK, thanks. Can you mark this bug (and the others, if appropriate) as Started?
,
Feb 24 2017
,
Feb 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c73de4e7f56bfa4ece4ebb69086861ae40f17564 commit c73de4e7f56bfa4ece4ebb69086861ae40f17564 Author: spqchan <spqchan@chromium.org> Date: Fri Feb 24 18:15:23 2017 [Mac] Adjustments to the Default State Touch Bar - Modified the text on the search button - Use Google Search icon when the default search provider is Google - New Tab button moved to the back - Active star color should be blue BUG= 694754 , 694760 , 694756 , 694753 Review-Url: https://codereview.chromium.org/2711443003 Cr-Commit-Position: refs/heads/master@{#452874} [modify] https://crrev.com/c73de4e7f56bfa4ece4ebb69086861ae40f17564/chrome/app/generated_resources.grd [modify] https://crrev.com/c73de4e7f56bfa4ece4ebb69086861ae40f17564/chrome/browser/ui/cocoa/browser_window_touch_bar.mm [modify] https://crrev.com/c73de4e7f56bfa4ece4ebb69086861ae40f17564/ui/gfx/vector_icons/BUILD.gn [add] https://crrev.com/c73de4e7f56bfa4ece4ebb69086861ae40f17564/ui/gfx/vector_icons/google_search_mac_touchbar.icon
,
Feb 24 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by spqc...@chromium.org
, Feb 21 2017