New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 694754 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

Google "G" is missing from the Touch Bar when Google is default search engine

Project Member Reported by shrike@chromium.org, Feb 21 2017

Issue description

Chrome 58.0.3019.0

I don't see the Google "G" in the Touch Bar.

 
Cc: est...@chromium.org
Ah yes, I removed it. estade@ is in the works of determining the asset should be stored  internally or not 

Comment 2 by shrike@chromium.org, Feb 21 2017

Cc: rpop@chromium.org
Can you reexplain c#1? I don't fully understand what you're saying.

For now can you just land the icon somewhere so that we get some air time with it before branch? Unless what you're talking about in c#1 will happen in the next few days? I am of course not against the icon living in the "right" spot, but we should not be blocking waiting for the right spot to happen.


So the icon should probably go into src-internal, estade@ was looking into that. To ensure that the CL landed before the feature freeze, I removed the G search icon and is planning to add it back in a follow up CL once things are figured out. Will aim to get that done within the next few days

Comment 4 by est...@chromium.org, Feb 22 2017

I don't think we need to put any assets in src-internal, but while that debate simmers, I think we can go ahead and put this one in src/. Iconography for Google services that we connect to already lives in src/, for example the Google Translate png in //ui/resources. The only things in src-internal are google chrome specific, but presumably a build of chromium that uses Google as the search engine would still want this G.

Comment 5 by shrike@chromium.org, Feb 22 2017

Thank you estade@ for helping move this along.
Awesome thanks!

Comment 7 by shrike@chromium.org, Feb 24 2017

Hi spqchan@, what is the status of this bug (and the other two issues I reported)? We need to send this to UI review and M58 branch is in less than 1 week.

In review: https://codereview.chromium.org/2711443003/
I shall ping it

Comment 9 by shrike@chromium.org, Feb 24 2017

OK, thanks. Can you mark this bug (and the others, if appropriate) as Started?
Status: Started (was: Assigned)
Project Member

Comment 11 by bugdroid1@chromium.org, Feb 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c73de4e7f56bfa4ece4ebb69086861ae40f17564

commit c73de4e7f56bfa4ece4ebb69086861ae40f17564
Author: spqchan <spqchan@chromium.org>
Date: Fri Feb 24 18:15:23 2017

[Mac] Adjustments to the Default State Touch Bar

- Modified the text on the search button
- Use Google Search icon when the default search provider is Google
- New Tab button moved to the back
- Active star color should be blue

BUG= 694754 ,  694760 ,  694756 ,  694753 

Review-Url: https://codereview.chromium.org/2711443003
Cr-Commit-Position: refs/heads/master@{#452874}

[modify] https://crrev.com/c73de4e7f56bfa4ece4ebb69086861ae40f17564/chrome/app/generated_resources.grd
[modify] https://crrev.com/c73de4e7f56bfa4ece4ebb69086861ae40f17564/chrome/browser/ui/cocoa/browser_window_touch_bar.mm
[modify] https://crrev.com/c73de4e7f56bfa4ece4ebb69086861ae40f17564/ui/gfx/vector_icons/BUILD.gn
[add] https://crrev.com/c73de4e7f56bfa4ece4ebb69086861ae40f17564/ui/gfx/vector_icons/google_search_mac_touchbar.icon

Status: Fixed (was: Started)

Sign in to add a comment