New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 694748 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

[Findit] Flake Analyzer - Flake Analysis may hit infinite loop

Project Member Reported by lijeffrey@chromium.org, Feb 21 2017

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Feb 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/a15cde7705d611ac89c81635508658f67c723720

commit a15cde7705d611ac89c81635508658f67c723720
Author: Jeffrey Li <lijeffrey@chromium.org>
Date: Mon Feb 27 21:33:33 2017

[Findit] Flake Analyzer - Fix infinitely running tryjobs

The root cause is the case where a flaky test is newly added is not accounted for correctly. The lookback algorithm should check for such a case and return the revision that adds the flaky test as the culprit, rather than rely on the calling code to check for next_run_number and realize the run number has already been analyzed and complete accordingly.

BUG= 694748 

Change-Id: I2401035cfdc7bd2e3cf12d03a8769ccf6ed55c2f
Reviewed-on: https://chromium-review.googlesource.com/446002
Reviewed-by: Chan Li <chanli@chromium.org>
Commit-Queue: Jeffrey Li <lijeffrey@chromium.org>

[modify] https://crrev.com/a15cde7705d611ac89c81635508658f67c723720/appengine/findit/waterfall/flake/lookback_algorithm.py
[modify] https://crrev.com/a15cde7705d611ac89c81635508658f67c723720/appengine/findit/waterfall/flake/recursive_flake_try_job_pipeline.py
[modify] https://crrev.com/a15cde7705d611ac89c81635508658f67c723720/appengine/findit/waterfall/flake/test/lookback_algorithm_test.py

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)

Sign in to add a comment