New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 694742 link

Starred by 5 users
Status: Fixed
Owner:
lanwei@chromium.org
Closed: May 2017
Cc:
lfg@chromium.org
kenrb@chromium.org
jam@chromium.org
nzolghadr@chromium.org
clamy@chromium.org
█ yzshen@chromium.org
creis@chromium.org
lanwei@chromium.org
█ nasko@chromium.org
Components:
EstimatedDays: ----
NextAction: 2017-03-31
OS: All
Pri: 3
Type: Bug

Blocking:
issue 694403



Sign in to add a comment

Failing DCHECK_EQ in PointerEventFactory.cpp on id

Project Member Reported by lanwei@chromium.org, Feb 21 2017 
There are some flaky tests failed on
[1:1:0220/085659.710205:FATAL:PointerEventFactory.cpp(276)] Check failed: mouseEvent.id == coalescedMouseEvent.id (2147483647 vs. 0)

We are currently disabling this DCHECK. We will inject id from low-level OS events and add this DCHECK back again.

Comment 1 by lfg@chromium.org, Feb 22 2017

Cc: kenrb@chromium.org creis@chromium.org lfg@chromium.org
I can consistently hit this DCHECK when loading a page with out-of-process iframes.

Repro:

1. Launch chrome with --site-per-process flag.
2. Navigate to http://csreis.github.io/tests/cross-site-iframe-simple.html

Comment 2 by dtapu...@chromium.org, Feb 22 2017 

 Issue 694183  has been merged into this issue.

Comment 3 by fdoray@chromium.org, Feb 22 2017 

 Issue 693832  has been merged into this issue.

Comment 4 by nzolghadr@chromium.org, Feb 23 2017 

 Issue 694403  has been merged into this issue.

Comment 5 by nzolghadr@chromium.org, Feb 23 2017 

 Issue 694472  has been merged into this issue.
Project Member

Comment 6 by chromium...@appspot.gserviceaccount.com, Feb 23 2017

Labels: Sheriff-Chromium
Detected 4 new flakes for test/step "WebRtcFromWebAccessibleResourceTest.GetUserMediaInWebAccessibleResourceSuccess". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyWQsSBUZsYWtlIk5XZWJSdGNGcm9tV2ViQWNjZXNzaWJsZVJlc291cmNlVGVzdC5HZXRVc2VyTWVkaWFJbldlYkFjY2Vzc2libGVSZXNvdXJjZVN1Y2Nlc3MM. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).

Comment 7 by fsam...@chromium.org, Feb 27 2017

Labels: -Sheriff-Chromium
The DCHECK has been commented out so I'm removing the sheriff label.

Comment 8 by dtapu...@chromium.org, Apr 28 2017

Cc: jam@chromium.org clamy@chromium.org nasko@chromium.org yzshen@chromium.org lanwei@chromium.org
 Issue 695067  has been merged into this issue.
Project Member

Comment 9 by bugdroid1@chromium.org, May 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2db36b51a5de1d110a0d9dbe6969ab9603df9ad8

commit 2db36b51a5de1d110a0d9dbe6969ab9603df9ad8
Author: lanwei <lanwei@chromium.org>
Date: Tue May 16 14:58:21 2017

Add pointer id to the WebMouseEvent's constructors

In order to make the WebMouseEvent's pointer id consistent with ui::MouseEvent, we
add pointer id to the WebMouseEvent's constructors. Then we can enable the DCHECK
of pointer id in PointerEventFactory.

BUG= 694742 

Review-Url: https://codereview.chromium.org/2849083002
Cr-Commit-Position: refs/heads/master@{#472106}

[modify] https://crrev.com/2db36b51a5de1d110a0d9dbe6969ab9603df9ad8/third_party/WebKit/Source/core/events/PointerEventFactory.cpp
[modify] https://crrev.com/2db36b51a5de1d110a0d9dbe6969ab9603df9ad8/third_party/WebKit/Source/platform/WebMouseEvent.cpp
[modify] https://crrev.com/2db36b51a5de1d110a0d9dbe6969ab9603df9ad8/third_party/WebKit/public/platform/WebMouseEvent.h
[modify] https://crrev.com/2db36b51a5de1d110a0d9dbe6969ab9603df9ad8/third_party/WebKit/public/platform/WebMouseWheelEvent.h
[modify] https://crrev.com/2db36b51a5de1d110a0d9dbe6969ab9603df9ad8/third_party/WebKit/public/platform/WebPointerProperties.h
[modify] https://crrev.com/2db36b51a5de1d110a0d9dbe6969ab9603df9ad8/third_party/WebKit/public/platform/WebTouchPoint.h
[modify] https://crrev.com/2db36b51a5de1d110a0d9dbe6969ab9603df9ad8/ui/events/blink/web_input_event.cc
[modify] https://crrev.com/2db36b51a5de1d110a0d9dbe6969ab9603df9ad8/ui/events/blink/web_input_event_builders_win.cc
[modify] https://crrev.com/2db36b51a5de1d110a0d9dbe6969ab9603df9ad8/ui/events/event.cc
[modify] https://crrev.com/2db36b51a5de1d110a0d9dbe6969ab9603df9ad8/ui/events/event.h

Comment 10 by lanwei@chromium.org, May 25 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment