New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 694741 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Cookies Table: 'delete selected' doesn't select previous row

Reported by kdzwinel@gmail.com, Feb 21 2017

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36

Steps to reproduce the problem:
1. Go to Application > Cookies Table
2. Make sure you have at least two cookies
3. Select one
4. Click 'Remove Selected' button

What is the expected behavior?
Cookie should get removed and another cookie should get selected

What went wrong?
Cookie gets removed but next/previous row is not getting selected. This is inconsistent with Storage tables.

Did this work before? No 

Chrome version: 56.0.2924.87  Channel: stable
OS Version: OS X 10.12.3
Flash Version: Shockwave Flash 24.0 r0
 
delete_selected.mov
848 KB Download

Comment 1 by kdzwinel@gmail.com, Feb 21 2017

Correction: In Chrome 56 the button is titled 'Delete', In Chrome 58 (where the bug is still present) it's titled 'Remove Selected'.

Comment 2 by ajha@chromium.org, Feb 22 2017

Labels: Needs-Triage-M56
Labels: -Needs-Triage-M56 M-58 OS-Linux OS-Windows
Status: Untriaged (was: Unconfirmed)
seems like a feature request.Marking it as Untriaged to get more inputs from dev team.

Thanks,

Comment 4 by phulce@chromium.org, Feb 24 2017

Owner: phulce@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/63095504581ef0e664faf74614e5ca98f9cb9047

commit 63095504581ef0e664faf74614e5ca98f9cb9047
Author: phulce <phulce@chromium.org>
Date: Wed Mar 01 19:49:13 2017

DevTools: Fixes to Storage panel inconsistencies

* Fixes Backspace delete in CookiesTable
* Fixes selection preservation when 'Delete Selected' is used in CookiesTable
* Fixes selection removal when 'Clear All' is used in Storage panes

BUG= 694399 , 694741 

Review-Url: https://codereview.chromium.org/2714913002
Cr-Commit-Position: refs/heads/master@{#454002}

[modify] https://crrev.com/63095504581ef0e664faf74614e5ca98f9cb9047/third_party/WebKit/Source/devtools/front_end/cookie_table/CookiesTable.js
[modify] https://crrev.com/63095504581ef0e664faf74614e5ca98f9cb9047/third_party/WebKit/Source/devtools/front_end/resources/CookieItemsView.js
[modify] https://crrev.com/63095504581ef0e664faf74614e5ca98f9cb9047/third_party/WebKit/Source/devtools/front_end/resources/DOMStorageItemsView.js

Status: Fixed (was: Started)
Labels: Needs-Feedback
Tested this issue on Windows7,Mac 10.12.3 & Ubuntu 14.04 using chrome version-58.0.3029.6 as per the steps mentioned in comment#0 & observed below behaviour:
1.Selected cookie is getting removed and next cookie is getting selected when we remove cookies from top to bottom direction.

2.Selected cookie is getting removed but previous cookie is not getting selected when we remove cookies from bottom to top direction.

Please find the attached screencast for reference & confirm the fix on step-2. 

Note: As per the reported provided screencast, issue should work in step-2 scenario also.
Thank you!!

694741.mp4
1.2 MB View Download
Cc: jmukthavaram@chromium.org
Ah good find @jmukthavaram! It's a bad interaction with the new editable cookies functionality. Fix for it is in review now.

Project Member

Comment 10 by bugdroid1@chromium.org, Mar 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a3ea6d2b334319300f45f1bc74b9db0de0e7d67

commit 1a3ea6d2b334319300f45f1bc74b9db0de0e7d67
Author: phulce <phulce@chromium.org>
Date: Wed Mar 08 17:42:16 2017

DevTools: Fix previous cookie selection

* Fixes issue where the previous cookie would not be selected
  if selection was at the bottom of the table.

BUG= 694741 

Review-Url: https://codereview.chromium.org/2734943004
Cr-Commit-Position: refs/heads/master@{#455485}

[modify] https://crrev.com/1a3ea6d2b334319300f45f1bc74b9db0de0e7d67/third_party/WebKit/Source/devtools/front_end/cookie_table/CookiesTable.js

Sign in to add a comment