New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 694740 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 567132
Owner:
Last visit > 30 days ago
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

YouTube appears twice in the NTP

Project Member Reported by mlamouri@chromium.org, Feb 21 2017

Issue description

Once in TOP_SITES as http://www.youtube.com and once in POPULAR as https://m.youtube.com

It's even more annoying because these are the only entries with an icon on my Canary build :)
 

Comment 1 by treib@chromium.org, Feb 22 2017

Cc: treib@chromium.org mastiz@chromium.org
Labels: zine-ntp-pe
Status: Available (was: Untriaged)
Hrm. We de-dupe between TOP_SITES and POPULAR based on the hostname, so I guess this is expected. The question is why www.youtube.com shows up at all; if you're on mobile, I'd expect m.youtube.com.

Comment 2 by jkrcal@chromium.org, Feb 23 2017

Wouldn't it be better to de-dupe between TOP_SITES and POPULAR based on the domain (i.e. "youtube") and keep the top site entry if there is a conflict?

Does TopSites correcty handle redirects? If I type in www.youtube.com 3 times, whould I get www.youtube.com or m.youtube.com?

Comment 3 by jkrcal@chromium.org, Feb 23 2017

crbug.com/567132 seems to talk about similar problems with redirects. 
Can it be that it also affects Android?

Comment 4 by treib@chromium.org, Feb 23 2017

It's possible bug 567132 is the same thing. Yes, it probably affects all platforms.

The problem with "domain" is that it's surprisingly poorly defined. I guess eTLD+1 is the most common convention, but it's not foolproof - e.g. we'd merge mail.google.com with maps.google.com.

Comment 5 by sfiera@chromium.org, Mar 13 2017

Mergedinto: 567132
Owner: sfiera@chromium.org
Status: Duplicate (was: Available)
Sent out https://crrev.com/2747843002; I think this bug is a dupe.

Sign in to add a comment