[UI string] [QR code scanner] QR code scanner copy is missing a verb |
||||||
Issue descriptionString currently says: "QR Code or barcode" Please update to: "Position QR code or barcode in this frame" per discussion with amyroberts@
,
Feb 22 2017
The text is extremely close to the edge of the screen on a 5S (IMG_0002). It's not very close on a 6S (IMG_0494). Should we shorten the length of the text or is this implementation ok? Thanks.
,
Feb 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3974d9eded98f5261afbc2b4315f0c22fdd10072 commit 3974d9eded98f5261afbc2b4315f0c22fdd10072 Author: jif <jif@chromium.org> Date: Wed Feb 22 13:11:20 2017 Make the QR Code scanner caption fit on multiple lines. BUG= 694739 Review-Url: https://codereview.chromium.org/2709943002 Cr-Commit-Position: refs/heads/master@{#452022} [modify] https://crrev.com/3974d9eded98f5261afbc2b4315f0c22fdd10072/ios/chrome/browser/ui/qr_scanner/qr_scanner_view.mm
,
Feb 22 2017
This CL adds padding between the edges of the screen and the string, and allows the text to run on multiple lines. That should help for the problem mentioned in #2. The CL does *not* actually change the string.
,
Feb 22 2017
Jif, could you please update the status.
,
Feb 23 2017
jif: Could you add screenshots similar to those in #2 with the new padding? I'm unable to build at the moment. Thanks!
,
Feb 23 2017
Screenshot taken on the simulator, hence the error dialogs.
,
Feb 23 2017
Is the implementation in #7 (especially for 5S) okay? If so, we can land the change. Thanks!
,
Mar 1 2017
The padding looked a bit off to me so I asked Amy for a sanity check. She found that the padding around the text doesn't match the padding around the frame and suggested we increase the padding around text so it's same as the frame - 31 pts. She will attach a mock.
,
Mar 1 2017
mock attached. new padding tested in english and longest language (german) per go/translate50. After that string issue should be good to go.
,
Mar 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ae62f34fd5f4883f1a7dc5c8cf0e895b1d6624ef commit ae62f34fd5f4883f1a7dc5c8cf0e895b1d6624ef Author: jif <jif@chromium.org> Date: Thu Mar 02 13:36:49 2017 Update QR Code scanner caption string and padding. BUG= 694739 Review-Url: https://codereview.chromium.org/2715673002 Cr-Commit-Position: refs/heads/master@{#454246} [modify] https://crrev.com/ae62f34fd5f4883f1a7dc5c8cf0e895b1d6624ef/ios/chrome/app/strings/ios_strings.grd [modify] https://crrev.com/ae62f34fd5f4883f1a7dc5c8cf0e895b1d6624ef/ios/chrome/browser/ui/qr_scanner/qr_scanner_view.mm
,
Mar 2 2017
Padding and string changed.
,
Mar 7 2017
Verified in 58.0.3029.6 Canary, iPhone 5S iOS 10.2 The string "Position QR code or barcode in this frame" looks good, Translations are not in yet, Need to retest once translations in. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by jasonkliu@chromium.org
, Feb 21 2017