New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 694735 link

Starred by 1 user
Status: Fixed
Owner:
█ rkaplow@chromium.org
Last visit > 30 days ago
Closed: Feb 2017
Cc:
skare@chromium.org
isherman@chromium.org
asvitk...@chromium.org
█ rkaplow@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

UKM data is tagged as UMA for data usage histograms

Project Member Reported by rkaplow@chromium.org, Feb 21 2017 
See https://codesearch.chromium.org/chromium/src/components/metrics/net/net_metrics_log_uploader.cc?l=32

This logic is used by UKM

Should be parametrized to split up the data usage.
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c420825985ca92a144a7e74ec114cd06759bf9a

commit 9c420825985ca92a144a7e74ec114cd06759bf9a
Author: rkaplow <rkaplow@chromium.org>
Date: Fri Feb 24 15:29:57 2017

Switch UKM service to properly mark upload data as UKM and not UMA.

This also refactors the api such that new services can more easily do the correct attribution.

TBR=olivierrobin@chromium.org,boliu@chromium.org

BUG= 694735 

Review-Url: https://codereview.chromium.org/2708293002
Cr-Commit-Position: refs/heads/master@{#452830}

[modify] https://crrev.com/9c420825985ca92a144a7e74ec114cd06759bf9a/android_webview/native/aw_metrics_service_client_impl.cc
[modify] https://crrev.com/9c420825985ca92a144a7e74ec114cd06759bf9a/android_webview/native/aw_metrics_service_client_impl.h
[modify] https://crrev.com/9c420825985ca92a144a7e74ec114cd06759bf9a/chrome/browser/metrics/chrome_metrics_service_client.cc
[modify] https://crrev.com/9c420825985ca92a144a7e74ec114cd06759bf9a/chrome/browser/metrics/chrome_metrics_service_client.h
[modify] https://crrev.com/9c420825985ca92a144a7e74ec114cd06759bf9a/chromecast/browser/metrics/cast_metrics_service_client.cc
[modify] https://crrev.com/9c420825985ca92a144a7e74ec114cd06759bf9a/chromecast/browser/metrics/cast_metrics_service_client.h
[modify] https://crrev.com/9c420825985ca92a144a7e74ec114cd06759bf9a/components/data_use_measurement/core/data_use_user_data.cc
[modify] https://crrev.com/9c420825985ca92a144a7e74ec114cd06759bf9a/components/data_use_measurement/core/data_use_user_data.h
[modify] https://crrev.com/9c420825985ca92a144a7e74ec114cd06759bf9a/components/metrics/metrics_log_uploader.cc
[modify] https://crrev.com/9c420825985ca92a144a7e74ec114cd06759bf9a/components/metrics/metrics_log_uploader.h
[modify] https://crrev.com/9c420825985ca92a144a7e74ec114cd06759bf9a/components/metrics/metrics_service.cc
[modify] https://crrev.com/9c420825985ca92a144a7e74ec114cd06759bf9a/components/metrics/metrics_service_client.h
[modify] https://crrev.com/9c420825985ca92a144a7e74ec114cd06759bf9a/components/metrics/net/net_metrics_log_uploader.cc
[modify] https://crrev.com/9c420825985ca92a144a7e74ec114cd06759bf9a/components/metrics/net/net_metrics_log_uploader.h
[modify] https://crrev.com/9c420825985ca92a144a7e74ec114cd06759bf9a/components/metrics/net/net_metrics_log_uploader_unittest.cc
[modify] https://crrev.com/9c420825985ca92a144a7e74ec114cd06759bf9a/components/metrics/test_metrics_log_uploader.cc
[modify] https://crrev.com/9c420825985ca92a144a7e74ec114cd06759bf9a/components/metrics/test_metrics_log_uploader.h
[modify] https://crrev.com/9c420825985ca92a144a7e74ec114cd06759bf9a/components/metrics/test_metrics_service_client.cc
[modify] https://crrev.com/9c420825985ca92a144a7e74ec114cd06759bf9a/components/metrics/test_metrics_service_client.h
[modify] https://crrev.com/9c420825985ca92a144a7e74ec114cd06759bf9a/components/ukm/ukm_service.cc
[modify] https://crrev.com/9c420825985ca92a144a7e74ec114cd06759bf9a/ios/chrome/browser/metrics/ios_chrome_metrics_service_client.h
[modify] https://crrev.com/9c420825985ca92a144a7e74ec114cd06759bf9a/ios/chrome/browser/metrics/ios_chrome_metrics_service_client.mm
[modify] https://crrev.com/9c420825985ca92a144a7e74ec114cd06759bf9a/ios/chrome/today_extension/today_metrics_logger.mm
[modify] https://crrev.com/9c420825985ca92a144a7e74ec114cd06759bf9a/tools/metrics/histograms/histograms.xml

Comment 2 by rkaplow@chromium.org, Feb 24 2017

Status: Fixed (was: Untriaged)
►

Sign in to add a comment