New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 694732 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 694730



Sign in to add a comment

Do not report stage failure to CIDB if the stage passed

Project Member Reported by nxia@chromium.org, Feb 21 2017

Issue description

For stages cancelled by exceptions like timeout background failures, we should only report stage failures to CIDB if the stages are not marked as pass.
 

Comment 1 by nxia@chromium.org, Feb 21 2017

For example, stage UploadTestArtifacts passed successfully, but failure entries were inserted for stage UploadTestArtifacts.

mysql> select * from buildStageTable where id='38559826';
+----------+----------+---------------------+-------+--------+---------------------+---------------------+---------------------+-------+
| id       | build_id | name                | board | status | last_updated        | start_time          | finish_time         | final |
+----------+----------+---------------------+-------+--------+---------------------+---------------------+---------------------+-------+
| 38559826 |  1337105 | UploadTestArtifacts | cyan  | pass   | 2017-02-21 18:08:21 | 2017-02-21 17:57:20 | 2017-02-21 18:08:21 |     1 |





mysql> select * from failureTable  where build_stage_id='38559826';
+---------+----------------+------------------+-------------------+--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+--------------------+------------+---------------------+
| id      | build_stage_id | outer_failure_id | exception_type    | exception_message                                                                                                                                                                                                                                | exception_category | extra_info | timestamp           |
+---------+----------------+------------------+-------------------+--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+--------------------+------------+---------------------+
| 1913128 |       38559826 |             NULL | BackgroundFailure | <class 'chromite.lib.failures_lib.StepFailure'>: 
Traceback (most recent call last):
  File "/b/cbuild.cyan/chromite/lib/parallel.py", line 440, in _Run
    self._task(*self._task_args, **self._task_kwargs)
  File "/b/cbuild.cyan/chromite/c | unknown            | NULL       | 2017-02-21 19:44:26 |
| 1913129 |       38559826 |          1913128 | StepFailure       |                                                                                                                                                                                                                                                  | unknown            | NULL       | 2017-02-21 19:44:26 |
+---------+----------------+------------------+-------------------+--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+--------------------+------------+---------------------+





Project Member

Comment 2 by bugdroid1@chromium.org, Mar 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/ce7e9bb309bf9c90d403d08cad4562adb0f7471d

commit ce7e9bb309bf9c90d403d08cad4562adb0f7471d
Author: Ningning Xia <nxia@chromium.org>
Date: Wed Mar 01 21:19:49 2017

generic_builders: report stage status and stage failures.

In builders._runParallelStages exception handler, for stage without
stage status or with stage status in non_failure_status, if no failures
message found in failureTable, report stage failures for this stage to
failureTable; for stage with stage status not None and not in
completed_status, mark stage status as final status 'fail' in
buildTable.

BUG= chromium:694732 
TEST=unit_tests

Change-Id: I3bb4715ed0aa4fdde7dc36f6cdb9ab033f8ec3b8
Reviewed-on: https://chromium-review.googlesource.com/446900
Commit-Ready: Ningning Xia <nxia@chromium.org>
Tested-by: Ningning Xia <nxia@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/ce7e9bb309bf9c90d403d08cad4562adb0f7471d/lib/cidb.py
[add] https://crrev.com/ce7e9bb309bf9c90d403d08cad4562adb0f7471d/cbuildbot/builders/generic_builders_unittest
[add] https://crrev.com/ce7e9bb309bf9c90d403d08cad4562adb0f7471d/cbuildbot/builders/generic_builders_unittest.py
[modify] https://crrev.com/ce7e9bb309bf9c90d403d08cad4562adb0f7471d/lib/fake_cidb.py
[modify] https://crrev.com/ce7e9bb309bf9c90d403d08cad4562adb0f7471d/cbuildbot/builders/generic_builders.py
[modify] https://crrev.com/ce7e9bb309bf9c90d403d08cad4562adb0f7471d/lib/cidb_integration_test.py

Comment 3 by nxia@chromium.org, Mar 13 2017

Status: Fixed (was: Untriaged)

Comment 4 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 5 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 6 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment