More details: go/eliminating-status-pickles
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/b2e4d5684f2a71eaf47ac07c0c75c8a587ad4f83 commit b2e4d5684f2a71eaf47ac07c0c75c8a587ad4f83 Author: Ningning Xia <nxia@chromium.org> Date: Thu Mar 16 23:15:02 2017 SlaveStatus: make GetAllSlaveBuildbucketInfo public and static. GetAllSlaveBuildbucketInfo should be a public and static for getting buildbucket information for given slave build dict. BuilderStatusManager will call it to get buildbucket information for slave builds. BUG= chromium:694730 TEST=unit_tests Change-Id: I9c335d780004b4455daf6f7a1bd88c9821317f5a Reviewed-on: https://chromium-review.googlesource.com/448847 Commit-Ready: Ningning Xia <nxia@chromium.org> Tested-by: Ningning Xia <nxia@chromium.org> Reviewed-by: Chris Ching <chingcodes@chromium.org> [modify] https://crrev.com/b2e4d5684f2a71eaf47ac07c0c75c8a587ad4f83/cbuildbot/build_status_unittest.py [modify] https://crrev.com/b2e4d5684f2a71eaf47ac07c0c75c8a587ad4f83/cbuildbot/relevant_changes.py [modify] https://crrev.com/b2e4d5684f2a71eaf47ac07c0c75c8a587ad4f83/cbuildbot/build_status.py [modify] https://crrev.com/b2e4d5684f2a71eaf47ac07c0c75c8a587ad4f83/cbuildbot/manifest_version_unittest.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/205d5edd38adebf71583033aec033a0358f7cbab commit 205d5edd38adebf71583033aec033a0358f7cbab Author: Ningning Xia <nxia@chromium.org> Date: Thu Mar 16 23:15:02 2017 SlaveStatus: make GetAllSlaveCIDBStatusInfo public and static. Make GetAllSlaveCIDBStatusInfo public and static, so that BuilderStatusManager can call it to get CIDB status for all slave builds of a master build. BUG= chromium:694730 TEST=unit_tests Change-Id: Ib3f30a607c38b73919fbe30017e96aebd01f8fb7 Reviewed-on: https://chromium-review.googlesource.com/449017 Commit-Ready: Ningning Xia <nxia@chromium.org> Tested-by: Ningning Xia <nxia@chromium.org> Reviewed-by: Chris Ching <chingcodes@chromium.org> [modify] https://crrev.com/205d5edd38adebf71583033aec033a0358f7cbab/cbuildbot/build_status_unittest.py [modify] https://crrev.com/205d5edd38adebf71583033aec033a0358f7cbab/cbuildbot/relevant_changes.py [modify] https://crrev.com/205d5edd38adebf71583033aec033a0358f7cbab/cbuildbot/build_status.py [modify] https://crrev.com/205d5edd38adebf71583033aec033a0358f7cbab/cbuildbot/manifest_version_unittest.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/f88e07e9ba4db2d6030924ebab128e9838a16f55 commit f88e07e9ba4db2d6030924ebab128e9838a16f55 Author: Ningning Xia <nxia@chromium.org> Date: Fri Mar 17 01:06:59 2017 Add EncodeExtraInfo methods to StepFailure and its subclasses. Slave builds will encode extra info of failure messages into a json string which can be stored in CIDB, so the master build can get and decode the extra infos of its slave builds from CDIB. BUG= chromium:694730 TEST=unit_tests Change-Id: I412e59304a455cf77afc86fca6ec504a944adbd5 Reviewed-on: https://chromium-review.googlesource.com/456756 Commit-Ready: Ningning Xia <nxia@chromium.org> Tested-by: Ningning Xia <nxia@chromium.org> Reviewed-by: Aviv Keshet <akeshet@chromium.org> [modify] https://crrev.com/f88e07e9ba4db2d6030924ebab128e9838a16f55/lib/failures_lib_unittest.py [modify] https://crrev.com/f88e07e9ba4db2d6030924ebab128e9838a16f55/lib/failures_lib.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/f4dd6a3ce1a2ee621a298c505890a9f1ae3365ed commit f4dd6a3ce1a2ee621a298c505890a9f1ae3365ed Author: Ningning Xia <nxia@chromium.org> Date: Fri Mar 31 19:59:15 2017 Include dashboard url in BuildbucketInfo. 1) In order to construct BuilderStatus from CIDB/Buildbucket, include dashboard url in BuildbucketInfo. 2) Rename _GetNewlyCompletedSlaveCIDBStatusInfo to _GetNewSlaveCIDBStatusInfo, as it returns all new information for builds not in the completed set, not only the newly completed slave builds. BUG= chromium:694730 TEST=unit_tests Change-Id: Iead4e2569d5cac819433721bca3a87c4f32bf3b5 Reviewed-on: https://chromium-review.googlesource.com/459083 Commit-Ready: Ningning Xia <nxia@chromium.org> Tested-by: Ningning Xia <nxia@chromium.org> Reviewed-by: Ningning Xia <nxia@chromium.org> [modify] https://crrev.com/f4dd6a3ce1a2ee621a298c505890a9f1ae3365ed/cbuildbot/build_status_unittest.py [modify] https://crrev.com/f4dd6a3ce1a2ee621a298c505890a9f1ae3365ed/lib/buildbucket_lib.py [modify] https://crrev.com/f4dd6a3ce1a2ee621a298c505890a9f1ae3365ed/cbuildbot/build_status.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/4ede52bbae0fd70a4d787b06e5fc8b6d56cddfaf commit 4ede52bbae0fd70a4d787b06e5fc8b6d56cddfaf Author: Ningning Xia <nxia@chromium.org> Date: Fri Mar 31 19:59:15 2017 Add build_number to CIDBStatusInfo 1) In order to construct the luci-milo link for BuilderStatus, add build_number to CIDBStatusInfo. 2) Add CIDBStatusInfos class and helper methods to create CIDBStatusInfo for builds, this will reduce needed changes in unit tests if we change CIDBStatusInfo again in the future. BUG= chromium:694730 TEST=unit_tests Change-Id: I6e0b45c77ecc2651ec888ae0f41f1ad75656c842 Reviewed-on: https://chromium-review.googlesource.com/459126 Commit-Ready: Ningning Xia <nxia@chromium.org> Tested-by: Ningning Xia <nxia@chromium.org> Reviewed-by: Ningning Xia <nxia@chromium.org> [modify] https://crrev.com/4ede52bbae0fd70a4d787b06e5fc8b6d56cddfaf/cbuildbot/build_status_unittest.py [modify] https://crrev.com/4ede52bbae0fd70a4d787b06e5fc8b6d56cddfaf/cbuildbot/build_status.py [modify] https://crrev.com/4ede52bbae0fd70a4d787b06e5fc8b6d56cddfaf/cbuildbot/manifest_version_unittest.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/dd4dcf98ac5556a3a95f69e40b67c9ce5404ed74 commit dd4dcf98ac5556a3a95f69e40b67c9ce5404ed74 Author: Ningning Xia <nxia@chromium.org> Date: Fri Mar 31 19:59:15 2017 Move GetSlaveStatusInfo methods to builder_status_lib. To avoid circle dependency, move GetSlaveStatusInfo into builder_status_lib. BUG= chromium:694730 TEST=unit_tests Change-Id: I8aea9bdebd26690aded155f763ffe0cd1f72d035 Reviewed-on: https://chromium-review.googlesource.com/461326 Commit-Ready: Ningning Xia <nxia@chromium.org> Tested-by: Ningning Xia <nxia@chromium.org> Reviewed-by: Aviv Keshet <akeshet@chromium.org> [modify] https://crrev.com/dd4dcf98ac5556a3a95f69e40b67c9ce5404ed74/cbuildbot/relevant_changes.py [modify] https://crrev.com/dd4dcf98ac5556a3a95f69e40b67c9ce5404ed74/cbuildbot/manifest_version_unittest.py [modify] https://crrev.com/dd4dcf98ac5556a3a95f69e40b67c9ce5404ed74/cbuildbot/build_status_unittest.py [modify] https://crrev.com/dd4dcf98ac5556a3a95f69e40b67c9ce5404ed74/cbuildbot/build_status.py [modify] https://crrev.com/dd4dcf98ac5556a3a95f69e40b67c9ce5404ed74/lib/builder_status_lib.py [modify] https://crrev.com/dd4dcf98ac5556a3a95f69e40b67c9ce5404ed74/lib/builder_status_lib_unittest.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/fa3db55b863849afcdc86378bfe55cd30952a43a commit fa3db55b863849afcdc86378bfe55cd30952a43a Author: Ningning Xia <nxia@chromium.org> Date: Mon Apr 03 22:41:51 2017 CIDB returns Failures in the format of namedtuples. Change GetBuildsFailures and GetSlaveFailures to return namedtuples. This will make it easy for rebuilding failure messages from CIDB.failureTable. BUG= chromium:694730 TEST=unit_tests Change-Id: I6bdd93dc6df6833949ff3d1dea5978cf3b8e6f28 Reviewed-on: https://chromium-review.googlesource.com/465492 Commit-Ready: Ningning Xia <nxia@chromium.org> Tested-by: Ningning Xia <nxia@chromium.org> Reviewed-by: Ningning Xia <nxia@chromium.org> [modify] https://crrev.com/fa3db55b863849afcdc86378bfe55cd30952a43a/scripts/som_alerts_dispatcher.py [add] https://crrev.com/fa3db55b863849afcdc86378bfe55cd30952a43a/lib/failure_message_lib.py [modify] https://crrev.com/fa3db55b863849afcdc86378bfe55cd30952a43a/lib/cidb.py [modify] https://crrev.com/fa3db55b863849afcdc86378bfe55cd30952a43a/lib/cidb_integration_test.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/ff9fc0972301b885985a41a69c2db8ab1a0da05b commit ff9fc0972301b885985a41a69c2db8ab1a0da05b Author: Ningning Xia <nxia@chromium.org> Date: Tue Apr 04 22:23:35 2017 Revert "CIDB returns Failures in the format of namedtuples." This reverts commit fa3db55b863849afcdc86378bfe55cd30952a43a. Reason for revert: Please find details in chromium:708288 Original change's description: > CIDB returns Failures in the format of namedtuples. > > Change GetBuildsFailures and GetSlaveFailures to return namedtuples. > This will make it easy for rebuilding failure messages from > CIDB.failureTable. > > BUG= chromium:694730 > TEST=unit_tests > > Change-Id: I6bdd93dc6df6833949ff3d1dea5978cf3b8e6f28 > Reviewed-on: https://chromium-review.googlesource.com/465492 > Commit-Ready: Ningning Xia <nxia@chromium.org> > Tested-by: Ningning Xia <nxia@chromium.org> > Reviewed-by: Ningning Xia <nxia@chromium.org> > TBR=akeshet@chromium.org,nxia@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= chromium:694730 Change-Id: I9e2c13494e88d94bfcbd45db4fc8f256fe358f98 Reviewed-on: https://chromium-review.googlesource.com/467989 Trybot-Ready: Ningning Xia <nxia@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> Commit-Queue: Ningning Xia <nxia@chromium.org> Tested-by: Ningning Xia <nxia@chromium.org> [modify] https://crrev.com/ff9fc0972301b885985a41a69c2db8ab1a0da05b/scripts/som_alerts_dispatcher.py [delete] https://crrev.com/db7cb5e5c24ed2847d61a25d1fbc516620ac3a32/lib/failure_message_lib.py [modify] https://crrev.com/ff9fc0972301b885985a41a69c2db8ab1a0da05b/lib/cidb.py [modify] https://crrev.com/ff9fc0972301b885985a41a69c2db8ab1a0da05b/lib/cidb_integration_test.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/dfd9c234649b0109d94d137764f860430eaa8d58 commit dfd9c234649b0109d94d137764f860430eaa8d58 Author: Ningning Xia <nxia@chromium.org> Date: Fri Apr 07 21:15:34 2017 Add failure_message_lib module and StepFailureMessage classes. Failures stored in CIDB.failureTable will be fetched to construct StepFailureMessage instances. 1)Create corresponding StepFailureMessage classes 2)Create BuildFailureMessage which uses failure_messages. BUG= chromium:694730 TEST=unit_tests Change-Id: I29bd66520f2114231b44271917422e31c1f614ff Reviewed-on: https://chromium-review.googlesource.com/459096 Commit-Ready: Ningning Xia <nxia@chromium.org> Tested-by: Ningning Xia <nxia@chromium.org> Reviewed-by: Aviv Keshet <akeshet@chromium.org> [modify] https://crrev.com/dfd9c234649b0109d94d137764f860430eaa8d58/lib/failure_message_lib_unittest.py [modify] https://crrev.com/dfd9c234649b0109d94d137764f860430eaa8d58/lib/failures_lib.py [modify] https://crrev.com/dfd9c234649b0109d94d137764f860430eaa8d58/lib/failures_lib_unittest.py [modify] https://crrev.com/dfd9c234649b0109d94d137764f860430eaa8d58/lib/failure_message_lib.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/c9e95f42ae335f26e221ca70d30851096f474aaa commit c9e95f42ae335f26e221ca70d30851096f474aaa Author: Ningning Xia <nxia@chromium.org> Date: Fri Apr 07 21:15:35 2017 SlaveBuilderStatus: add method to get BuilderStatus for a build. Add GetBuilderStatusForBuild to get a BuilderStatus instance of a given build by fetching information from Buildbucket and CIDB. BUG= chromium:694730 TEST=unit_tests Change-Id: I3dc81d5ac4dcb76af7d62776e1545eb0a7ecd233 Reviewed-on: https://chromium-review.googlesource.com/462422 Commit-Ready: Ningning Xia <nxia@chromium.org> Tested-by: Ningning Xia <nxia@chromium.org> Reviewed-by: Ningning Xia <nxia@chromium.org> [modify] https://crrev.com/c9e95f42ae335f26e221ca70d30851096f474aaa/cbuildbot/build_status_unittest.py [modify] https://crrev.com/c9e95f42ae335f26e221ca70d30851096f474aaa/lib/builder_status_lib.py [modify] https://crrev.com/c9e95f42ae335f26e221ca70d30851096f474aaa/lib/builder_status_lib_unittest.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/51b3f87b64792aaab2707f6464cca380363ce9b5 commit 51b3f87b64792aaab2707f6464cca380363ce9b5 Author: Ningning Xia <nxia@chromium.org> Date: Fri Apr 07 21:15:34 2017 CIDB returns Failures in the format of StageFailure(namedtuples) 1) Create StageFailure class to present a failure entry fetched from CIDB failureView. 2) CIDB GetSlaveFailures and GetBuildFailure return StageFailure list instead of dict list. 3) Add GroupNamedtuplesByKey to cros_build_lib. BUG= chromium:694730 TEST=unit_tests Change-Id: Ia4fd50a5178e51c94ce244592a45d82684c7129c Reviewed-on: https://chromium-review.googlesource.com/468013 Commit-Ready: Ningning Xia <nxia@chromium.org> Tested-by: Ningning Xia <nxia@chromium.org> Reviewed-by: Aviv Keshet <akeshet@chromium.org> [add] https://crrev.com/51b3f87b64792aaab2707f6464cca380363ce9b5/lib/failure_message_lib.py [modify] https://crrev.com/51b3f87b64792aaab2707f6464cca380363ce9b5/cbuildbot/stages/report_stages_unittest.py [modify] https://crrev.com/51b3f87b64792aaab2707f6464cca380363ce9b5/lib/cidb.py [add] https://crrev.com/51b3f87b64792aaab2707f6464cca380363ce9b5/lib/failure_message_lib_unittest.py [modify] https://crrev.com/51b3f87b64792aaab2707f6464cca380363ce9b5/scripts/som_alerts_dispatcher.py [modify] https://crrev.com/51b3f87b64792aaab2707f6464cca380363ce9b5/lib/cros_build_lib.py [add] https://crrev.com/51b3f87b64792aaab2707f6464cca380363ce9b5/lib/failure_message_lib_unittest [modify] https://crrev.com/51b3f87b64792aaab2707f6464cca380363ce9b5/lib/cros_build_lib_unittest.py [modify] https://crrev.com/51b3f87b64792aaab2707f6464cca380363ce9b5/cbuildbot/stages/report_stages.py [modify] https://crrev.com/51b3f87b64792aaab2707f6464cca380363ce9b5/lib/cidb_integration_test.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/43e6a902edc17b90c27a63fabfe19f6892380a65 commit 43e6a902edc17b90c27a63fabfe19f6892380a65 Author: Ningning Xia <nxia@chromium.org> Date: Thu Apr 13 22:19:05 2017 Use builder_status_lib.SlaveBuilderStatus to create BuilderStatus GetBuilderStatus calls builder_status_lib.SlaveBuilderStatus to create BuilderStatus for each slave build. Print the information in the log. Need to test this on CQ before replacing the BuilderStatus pickle files. Will turn off the log and return slave_builder_statuses in the follow-up CLs. BUG= chromium:694730 TEST=unit_tests Change-Id: I27f73dd90f29c832833a35b6d4c617903bee8d69 Reviewed-on: https://chromium-review.googlesource.com/462429 Commit-Ready: Ningning Xia <nxia@chromium.org> Tested-by: Ningning Xia <nxia@chromium.org> Reviewed-by: Ningning Xia <nxia@chromium.org> [modify] https://crrev.com/43e6a902edc17b90c27a63fabfe19f6892380a65/cbuildbot/manifest_version.py [modify] https://crrev.com/43e6a902edc17b90c27a63fabfe19f6892380a65/cbuildbot/manifest_version_unittest.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/8fb316b113a264587319247fdc940ed4a0869f27 commit 8fb316b113a264587319247fdc940ed4a0869f27 Author: Ningning Xia <nxia@chromium.org> Date: Thu Apr 27 22:02:21 2017 Use BuilderStatus built from CIDB to replace the pickle files. 1) manifest_version uses SlaveBuilderStatus to create BuilderStatus for slaves. 2) TriageRelevantChanges uses SlaveBuilderStatus to calculate whehter failures are ignorable. BUG= chromium:694730 TEST=unit_tests Change-Id: I871389abf1a6e93c6767726abbbd72cede95ace3 Reviewed-on: https://chromium-review.googlesource.com/468646 Commit-Ready: Ningning Xia <nxia@chromium.org> Tested-by: Ningning Xia <nxia@chromium.org> Reviewed-by: Ningning Xia <nxia@chromium.org> [modify] https://crrev.com/8fb316b113a264587319247fdc940ed4a0869f27/lib/triage_lib_unittest.py [modify] https://crrev.com/8fb316b113a264587319247fdc940ed4a0869f27/cbuildbot/relevant_changes.py [modify] https://crrev.com/8fb316b113a264587319247fdc940ed4a0869f27/cbuildbot/manifest_version_unittest.py [modify] https://crrev.com/8fb316b113a264587319247fdc940ed4a0869f27/cbuildbot/relevant_changes_unittest.py [modify] https://crrev.com/8fb316b113a264587319247fdc940ed4a0869f27/cbuildbot/manifest_version.py [modify] https://crrev.com/8fb316b113a264587319247fdc940ed4a0869f27/cbuildbot/build_status.py [modify] https://crrev.com/8fb316b113a264587319247fdc940ed4a0869f27/lib/builder_status_lib.py [modify] https://crrev.com/8fb316b113a264587319247fdc940ed4a0869f27/lib/builder_status_lib_unittest.py [modify] https://crrev.com/8fb316b113a264587319247fdc940ed4a0869f27/lib/triage_lib.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/0afca62571658a35d081aa1c3f54961e37c3bed9 commit 0afca62571658a35d081aa1c3f54961e37c3bed9 Author: Ningning Xia <nxia@chromium.org> Date: Wed May 03 20:15:45 2017 Support GetBuildHistory on platform_version. To remove the dependency on BuilderStatus pickle files from GS bucket, support searching build history with platform_version, so the system can search CIDB instead of GS buckets for build statuses. BUG= chromium:694730 TEST=cidb_integration_test Change-Id: I872d1d512759a3da63abbb8967d39c0a182537fc Reviewed-on: https://chromium-review.googlesource.com/492371 Commit-Ready: Ningning Xia <nxia@chromium.org> Tested-by: Ningning Xia <nxia@chromium.org> Reviewed-by: Aviv Keshet <akeshet@chromium.org> [modify] https://crrev.com/0afca62571658a35d081aa1c3f54961e37c3bed9/lib/cidb.py [modify] https://crrev.com/0afca62571658a35d081aa1c3f54961e37c3bed9/lib/cidb_integration_test.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/c5f53f07a4b12434fdbc5bce57d55fc16dc21dad commit c5f53f07a4b12434fdbc5bce57d55fc16dc21dad Author: Ningning Xia <nxia@chromium.org> Date: Fri May 05 21:42:49 2017 Get the lastest build version from CIDB instead of BuilderStatus bucket. To eliminate the current dependency on BuilderStatus pickle files, query CIDB to get the latest build version. BUG= chromium:694730 TEST=unit_tests Change-Id: Ice5dd3a78df61d9bfb8439357b846672512bec3d Reviewed-on: https://chromium-review.googlesource.com/493795 Commit-Ready: Ningning Xia <nxia@chromium.org> Tested-by: Ningning Xia <nxia@chromium.org> Reviewed-by: Aviv Keshet <akeshet@chromium.org> [modify] https://crrev.com/c5f53f07a4b12434fdbc5bce57d55fc16dc21dad/cbuildbot/stages/chrome_stages.py [modify] https://crrev.com/c5f53f07a4b12434fdbc5bce57d55fc16dc21dad/cbuildbot/manifest_version.py [modify] https://crrev.com/c5f53f07a4b12434fdbc5bce57d55fc16dc21dad/cbuildbot/stages/sync_stages.py [modify] https://crrev.com/c5f53f07a4b12434fdbc5bce57d55fc16dc21dad/cbuildbot/manifest_version_unittest.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/7607bbe295f6d2bb1481445b3b6aa1f87d6e725b commit 7607bbe295f6d2bb1481445b3b6aa1f87d6e725b Author: Ningning Xia <nxia@chromium.org> Date: Thu Jun 22 01:48:03 2017 Move BuildFailureMessage to build_failure_message Create a separate module to place BuildFailureMessage to avoid circular dependency among failure_message_lib, failures_lib and portage_util. BUG= chromium:694730 TEST=unit_tests Change-Id: I201af66a1d8dd250b05f4f872ea133ada5922475 Reviewed-on: https://chromium-review.googlesource.com/540676 Commit-Ready: Ningning Xia <nxia@chromium.org> Tested-by: Ningning Xia <nxia@chromium.org> Reviewed-by: Aviv Keshet <akeshet@chromium.org> [add] https://crrev.com/7607bbe295f6d2bb1481445b3b6aa1f87d6e725b/lib/build_failure_message_unittest.py [modify] https://crrev.com/7607bbe295f6d2bb1481445b3b6aa1f87d6e725b/cbuildbot/manifest_version_unittest.py [modify] https://crrev.com/7607bbe295f6d2bb1481445b3b6aa1f87d6e725b/cbuildbot/relevant_changes_unittest.py [modify] https://crrev.com/7607bbe295f6d2bb1481445b3b6aa1f87d6e725b/lib/failure_message_lib_unittest.py [add] https://crrev.com/7607bbe295f6d2bb1481445b3b6aa1f87d6e725b/lib/build_failure_message.py [modify] https://crrev.com/7607bbe295f6d2bb1481445b3b6aa1f87d6e725b/lib/triage_lib_unittest.py [add] https://crrev.com/7607bbe295f6d2bb1481445b3b6aa1f87d6e725b/lib/build_failure_message_unittest [modify] https://crrev.com/7607bbe295f6d2bb1481445b3b6aa1f87d6e725b/lib/builder_status_lib_unittest.py [modify] https://crrev.com/7607bbe295f6d2bb1481445b3b6aa1f87d6e725b/lib/builder_status_lib.py [modify] https://crrev.com/7607bbe295f6d2bb1481445b3b6aa1f87d6e725b/lib/triage_lib.py [modify] https://crrev.com/7607bbe295f6d2bb1481445b3b6aa1f87d6e725b/lib/failure_message_lib.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/bdc9ee95a12f583f50f33c98e931866f9ce680e8 commit bdc9ee95a12f583f50f33c98e931866f9ce680e8 Author: Ningning Xia <nxia@chromium.org> Date: Fri Jun 23 00:03:56 2017 Convert stage exception to stage failure message and record it. Local Cbuilbot runs don't have CIDB instance created, so for all the exceptions threw by the failed stages, convert them to stage failure messages and record them in results_lib.Result, which can be extracted locally to create BuildFailureMessage. BUG= chromium:694730 , chromium:728357 TEST=unit_tests Change-Id: I5ff885981d7ea5d62c1ee823fbbe93c71eef612b Reviewed-on: https://chromium-review.googlesource.com/541925 Commit-Ready: Ningning Xia <nxia@chromium.org> Tested-by: Ningning Xia <nxia@chromium.org> Reviewed-by: Aviv Keshet <akeshet@chromium.org> [modify] https://crrev.com/bdc9ee95a12f583f50f33c98e931866f9ce680e8/lib/failures_lib_unittest.py [modify] https://crrev.com/bdc9ee95a12f583f50f33c98e931866f9ce680e8/cbuildbot/stages/completion_stages.py [modify] https://crrev.com/bdc9ee95a12f583f50f33c98e931866f9ce680e8/lib/build_failure_message.py [modify] https://crrev.com/bdc9ee95a12f583f50f33c98e931866f9ce680e8/cbuildbot/stages/generic_stages.py [modify] https://crrev.com/bdc9ee95a12f583f50f33c98e931866f9ce680e8/cbuildbot/stages/completion_stages_unittest.py [modify] https://crrev.com/bdc9ee95a12f583f50f33c98e931866f9ce680e8/lib/results_lib.py [modify] https://crrev.com/bdc9ee95a12f583f50f33c98e931866f9ce680e8/lib/failure_message_lib.py [modify] https://crrev.com/bdc9ee95a12f583f50f33c98e931866f9ce680e8/lib/failures_lib.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/090ba6858701b66c01253b869024cde58cda03c9 commit 090ba6858701b66c01253b869024cde58cda03c9 Author: Ningning Xia <nxia@chromium.org> Date: Wed Jun 28 19:36:02 2017 Support getting platform_version for a build_config. Previously, cros_best_revision listed all platform_versions under bucket gs://chromeos-manifest-versions/builder-status to get the canary versions it needed. In order to speed up the listing operation and eliminate the dependency on builder-status pickle files, add GetPlatformVersions opertion in CIDB. BUG= chromium:694730 TEST=cidb_integration_test Change-Id: I91aa57960e4df3c5f6a23bc8bc545c56f7fad2e9 Reviewed-on: https://chromium-review.googlesource.com/549660 Commit-Ready: Ningning Xia <nxia@chromium.org> Tested-by: Ningning Xia <nxia@chromium.org> Reviewed-by: Don Garrett <dgarrett@chromium.org> [modify] https://crrev.com/090ba6858701b66c01253b869024cde58cda03c9/lib/cidb.py [modify] https://crrev.com/090ba6858701b66c01253b869024cde58cda03c9/lib/cidb_integration_test.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/ff0858f34fe64fca09c601bc14ba068725b4e81c commit ff0858f34fe64fca09c601bc14ba068725b4e81c Author: Ningning Xia <nxia@chromium.org> Date: Wed Jun 28 21:45:11 2017 Remove dependency on BuilderStatus pickles for cros_best_revision Instead of getting BuilderStatus of canary builds from GS pickle files, construct the BuilderStatus from CIDB tables. BUG= chromium:694730 TEST=unit_test; run bin/cros_best_revision Change-Id: If8f4d47eb3a8c1a26050ba7c766c579d7f06bb05 Reviewed-on: https://chromium-review.googlesource.com/550862 Commit-Ready: Ningning Xia <nxia@chromium.org> Tested-by: Ningning Xia <nxia@chromium.org> Reviewed-by: Aviv Keshet <akeshet@chromium.org> [modify] https://crrev.com/ff0858f34fe64fca09c601bc14ba068725b4e81c/scripts/cros_best_revision_unittest.py [modify] https://crrev.com/ff0858f34fe64fca09c601bc14ba068725b4e81c/scripts/summarize_build_stats_unittest.py [modify] https://crrev.com/ff0858f34fe64fca09c601bc14ba068725b4e81c/cbuildbot/stages/completion_stages.py [modify] https://crrev.com/ff0858f34fe64fca09c601bc14ba068725b4e81c/lib/fake_cidb.py [modify] https://crrev.com/ff0858f34fe64fca09c601bc14ba068725b4e81c/lib/builder_status_lib_unittest.py [modify] https://crrev.com/ff0858f34fe64fca09c601bc14ba068725b4e81c/lib/builder_status_lib.py [modify] https://crrev.com/ff0858f34fe64fca09c601bc14ba068725b4e81c/scripts/cros_best_revision.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/b7fd66c2523a60f4f370d9c3bf72aa51085796ff commit b7fd66c2523a60f4f370d9c3bf72aa51085796ff Author: Ningning Xia <nxia@chromium.org> Date: Fri Jun 30 19:51:25 2017 Move GetBuildFailureMessage to generic_stages. Move GetBuildFailureMessage to generic_stages so that ManifestVersionedSyncCompletionStage, PreCQCompletionStage and ReportStage can call this method directly to get BuildFailureMessage of the build. Remove completion_stages.CreateBuildFailureMessage. BUG= chromium:694730 TEST=unit_tests Change-Id: Ic757652852b3e0bd53c505459786911f8b1670de Reviewed-on: https://chromium-review.googlesource.com/553526 Commit-Ready: Ningning Xia <nxia@chromium.org> Tested-by: Ningning Xia <nxia@chromium.org> Reviewed-by: Don Garrett <dgarrett@chromium.org> [modify] https://crrev.com/b7fd66c2523a60f4f370d9c3bf72aa51085796ff/cbuildbot/stages/generic_stages.py [modify] https://crrev.com/b7fd66c2523a60f4f370d9c3bf72aa51085796ff/cbuildbot/stages/completion_stages_unittest.py [modify] https://crrev.com/b7fd66c2523a60f4f370d9c3bf72aa51085796ff/cbuildbot/stages/completion_stages.py [modify] https://crrev.com/b7fd66c2523a60f4f370d9c3bf72aa51085796ff/cbuildbot/stages/generic_stages_unittest.py [modify] https://crrev.com/b7fd66c2523a60f4f370d9c3bf72aa51085796ff/cbuildbot/stages/report_stages.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/9a430d6c7bb7883899ba4a7a45e4a85ffc894387 commit 9a430d6c7bb7883899ba4a7a45e4a85ffc894387 Author: Ningning Xia <nxia@chromium.org> Date: Fri Jun 30 23:02:46 2017 Do not upload BuilderStatus pickle files for builds. The dependency on the BuilderStatus pickle files in GS has been removed, remove the logic of uploading BuilderStatus files to GS in this CL. BUG= chromium:694730 TEST=unit_tests Change-Id: I3cb6f5324d62ee3b3d7645374bf41011cf13765c Reviewed-on: https://chromium-review.googlesource.com/556154 Commit-Ready: Ningning Xia <nxia@chromium.org> Tested-by: Ningning Xia <nxia@chromium.org> Reviewed-by: Aviv Keshet <akeshet@chromium.org> [modify] https://crrev.com/9a430d6c7bb7883899ba4a7a45e4a85ffc894387/cbuildbot/validation_pool.py [modify] https://crrev.com/9a430d6c7bb7883899ba4a7a45e4a85ffc894387/cbuildbot/manifest_version_unittest.py [modify] https://crrev.com/9a430d6c7bb7883899ba4a7a45e4a85ffc894387/cbuildbot/stages/completion_stages.py [modify] https://crrev.com/9a430d6c7bb7883899ba4a7a45e4a85ffc894387/cbuildbot/manifest_version.py [modify] https://crrev.com/9a430d6c7bb7883899ba4a7a45e4a85ffc894387/cbuildbot/stages/sync_stages_unittest.py [modify] https://crrev.com/9a430d6c7bb7883899ba4a7a45e4a85ffc894387/cbuildbot/stages/completion_stages_unittest.py [modify] https://crrev.com/9a430d6c7bb7883899ba4a7a45e4a85ffc894387/lib/triage_lib_unittest.py [modify] https://crrev.com/9a430d6c7bb7883899ba4a7a45e4a85ffc894387/lib/builder_status_lib_unittest.py [modify] https://crrev.com/9a430d6c7bb7883899ba4a7a45e4a85ffc894387/cbuildbot/stages/sync_stages.py [modify] https://crrev.com/9a430d6c7bb7883899ba4a7a45e4a85ffc894387/lib/builder_status_lib.py [modify] https://crrev.com/9a430d6c7bb7883899ba4a7a45e4a85ffc894387/lib/triage_lib.py [modify] https://crrev.com/9a430d6c7bb7883899ba4a7a45e4a85ffc894387/lib/failures_lib.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/92841033326dd6d7bb5f62582e7817a48dcd39ea commit 92841033326dd6d7bb5f62582e7817a48dcd39ea Author: Ningning Xia <nxia@chromium.org> Date: Fri Jun 30 23:02:46 2017 Remove failure_type check for BuildFailureMessage. Now BuildFailureMessage contains StageFailureMessage instances which are constructed from CIDB failureTable. For all BuildFailureMessage instances, use exception_category check to replace failure_type check, as exception_category remains class inheritance information while failure_type doesn't. BUG= chromium:694730 TEST=unit_tests Change-Id: I6d777715946c3c60340a406acdddcef326497962 Reviewed-on: https://chromium-review.googlesource.com/557119 Commit-Ready: Ningning Xia <nxia@chromium.org> Tested-by: Ningning Xia <nxia@chromium.org> Reviewed-by: Aviv Keshet <akeshet@chromium.org> [modify] https://crrev.com/92841033326dd6d7bb5f62582e7817a48dcd39ea/lib/build_failure_message_unittest.py [modify] https://crrev.com/92841033326dd6d7bb5f62582e7817a48dcd39ea/lib/failure_message_lib_unittest.py [modify] https://crrev.com/92841033326dd6d7bb5f62582e7817a48dcd39ea/lib/build_failure_message.py [modify] https://crrev.com/92841033326dd6d7bb5f62582e7817a48dcd39ea/cbuildbot/stages/completion_stages.py [modify] https://crrev.com/92841033326dd6d7bb5f62582e7817a48dcd39ea/lib/triage_lib_unittest.py [modify] https://crrev.com/92841033326dd6d7bb5f62582e7817a48dcd39ea/cbuildbot/stages/generic_stages_unittest.py [modify] https://crrev.com/92841033326dd6d7bb5f62582e7817a48dcd39ea/lib/triage_lib.py [modify] https://crrev.com/92841033326dd6d7bb5f62582e7817a48dcd39ea/cbuildbot/stages/report_stages.py [modify] https://crrev.com/92841033326dd6d7bb5f62582e7817a48dcd39ea/lib/failure_message_lib.py
Comment 1 by nxia@chromium.org
, Feb 21 2017