Create unit tests for ScriptLoader and other script-related classes |
||||
Issue descriptionMany important classes such as: - ScriptLoader - PendingScript - ScriptSourceCode - HTMLParserScriptRunner lack their unit tests. ScriptRunner has unit tests.
,
Apr 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/76259cd66b9138f4fc474b955ed035d0f27e7dd4 commit 76259cd66b9138f4fc474b955ed035d0f27e7dd4 Author: hiroshige <hiroshige@chromium.org> Date: Wed Apr 19 01:08:46 2017 Move MockScriptElementBase to a separate header file https://codereview.chromium.org/2653923008/ will add a new file that uses MockScriptElementBase. BUG=694702 Review-Url: https://codereview.chromium.org/2821243003 Cr-Commit-Position: refs/heads/master@{#465452} [modify] https://crrev.com/76259cd66b9138f4fc474b955ed035d0f27e7dd4/third_party/WebKit/Source/core/BUILD.gn [add] https://crrev.com/76259cd66b9138f4fc474b955ed035d0f27e7dd4/third_party/WebKit/Source/core/dom/MockScriptElementBase.h [modify] https://crrev.com/76259cd66b9138f4fc474b955ed035d0f27e7dd4/third_party/WebKit/Source/core/dom/ScriptRunnerTest.cpp
,
Apr 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1bae530acabe60fccb84e27d2a3f1c34a692be57 commit 1bae530acabe60fccb84e27d2a3f1c34a692be57 Author: hiroshige <hiroshige@chromium.org> Date: Wed Apr 19 06:43:19 2017 Remove unused methods from ScriptStreamer Preparation for https://codereview.chromium.org/2830533002. BUG=694702 Review-Url: https://codereview.chromium.org/2829453003 Cr-Commit-Position: refs/heads/master@{#465512} [modify] https://crrev.com/1bae530acabe60fccb84e27d2a3f1c34a692be57/third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.h
,
Apr 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3d792ae95a9b9e1efa7dfe380278182f94ac8755 commit 3d792ae95a9b9e1efa7dfe380278182f94ac8755 Author: hiroshige <hiroshige@chromium.org> Date: Tue Apr 25 06:38:37 2017 Remove ClassicPendingScript::CreateForTesting() This CL uses MockScriptElementBase instead of nullptr to create ClassicPendingScript, in order to remove ClassicPendingScript::CreateForTesting() and make |PendingScript::element_| always non-null when used. BUG=686281, 694702 Review-Url: https://codereview.chromium.org/2827163003 Cr-Commit-Position: refs/heads/master@{#466902} [modify] https://crrev.com/3d792ae95a9b9e1efa7dfe380278182f94ac8755/third_party/WebKit/Source/bindings/core/v8/ScriptStreamerTest.cpp [modify] https://crrev.com/3d792ae95a9b9e1efa7dfe380278182f94ac8755/third_party/WebKit/Source/core/dom/ClassicPendingScript.cpp [modify] https://crrev.com/3d792ae95a9b9e1efa7dfe380278182f94ac8755/third_party/WebKit/Source/core/dom/ClassicPendingScript.h
,
Apr 29 2017
Start drafting unit tests for ScriptLoader: https://codereview.chromium.org/2847363002/
,
Apr 29 2017
Also drafting unit tests for ClassicPendingScript: https://codereview.chromium.org/2846673008/
,
May 11 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 21 2018
Assign this to hiroshige@ because he worked on this. |
||||
►
Sign in to add a comment |
||||
Comment 1 by hirosh...@chromium.org
, Feb 21 2017