After landing https://codereview.chromium.org/2705483002/, defining the task description by task.describe() should be deprecated.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6ae3ac58c9bc4d6c20a3ec2dab0b08dd62acb1dc commit 6ae3ac58c9bc4d6c20a3ec2dab0b08dd62acb1dc Author: rtoy <rtoy@chromium.org> Date: Wed Mar 01 00:28:26 2017 Move task.describe descriptiosn to audit.define Move the description of the task into the first argument audit.define. This is the first step at removing support for task.describe. The conversion was done using the gawk script: /^ *audit.define\(/ { audit = $0 next } /^ *task.describe\(.*\);/ { desc_match = match($0, /^( *)task.describe\((.*)\)/, desc_pat); label_match = match(audit, /^( *)audit.define\((['"].*['"]),(.*)/, label_pat) printf "%saudit.define({\n", label_pat[1] printf "%s label: %s,\n", label_pat[1], label_pat[2] printf "%s description: %s\n", label_pat[1], desc_pat[2] printf "%s},%s", label_pat[1], label_pat[3] next } { print } This script tries to indent things reasonably nicely, but doesn't handle the case where the description is very long or where the indentation is different. Also, not all files could be converted automatically because the script is not smart enough. These will be handled separately. BUG= 694659 TEST=none Review-Url: https://codereview.chromium.org/2708953003 Cr-Commit-Position: refs/heads/master@{#453770} [modify] https://crrev.com/6ae3ac58c9bc4d6c20a3ec2dab0b08dd62acb1dc/third_party/WebKit/LayoutTests/webaudio/Analyser/handle-silent-inputs.html [modify] https://crrev.com/6ae3ac58c9bc4d6c20a3ec2dab0b08dd62acb1dc/third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-fft-scaling.html [modify] https://crrev.com/6ae3ac58c9bc4d6c20a3ec2dab0b08dd62acb1dc/third_party/WebKit/LayoutTests/webaudio/Analyser/realtimeanalyser-fft-sizing.html [modify] https://crrev.com/6ae3ac58c9bc4d6c20a3ec2dab0b08dd62acb1dc/third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/note-grain-on-play.html [modify] https://crrev.com/6ae3ac58c9bc4d6c20a3ec2dab0b08dd62acb1dc/third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/sample-accurate-scheduling.html [modify] https://crrev.com/6ae3ac58c9bc4d6c20a3ec2dab0b08dd62acb1dc/third_party/WebKit/LayoutTests/webaudio/AudioContext/audiocontext-close-basic.html [modify] https://crrev.com/6ae3ac58c9bc4d6c20a3ec2dab0b08dd62acb1dc/third_party/WebKit/LayoutTests/webaudio/AudioContext/audiocontext-close.html [modify] https://crrev.com/6ae3ac58c9bc4d6c20a3ec2dab0b08dd62acb1dc/third_party/WebKit/LayoutTests/webaudio/AudioContext/audiocontext-suspend-resume.html [modify] https://crrev.com/6ae3ac58c9bc4d6c20a3ec2dab0b08dd62acb1dc/third_party/WebKit/LayoutTests/webaudio/AudioNode/audionode-channel-rules.html [modify] https://crrev.com/6ae3ac58c9bc4d6c20a3ec2dab0b08dd62acb1dc/third_party/WebKit/LayoutTests/webaudio/AudioNode/audionode-connect-order.html [modify] https://crrev.com/6ae3ac58c9bc4d6c20a3ec2dab0b08dd62acb1dc/third_party/WebKit/LayoutTests/webaudio/AudioNode/audionode.html [modify] https://crrev.com/6ae3ac58c9bc4d6c20a3ec2dab0b08dd62acb1dc/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-linearRampToValueAtTime.html [modify] https://crrev.com/6ae3ac58c9bc4d6c20a3ec2dab0b08dd62acb1dc/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setTargetAtTime.html [modify] https://crrev.com/6ae3ac58c9bc4d6c20a3ec2dab0b08dd62acb1dc/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setValueAtTime.html [modify] https://crrev.com/6ae3ac58c9bc4d6c20a3ec2dab0b08dd62acb1dc/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-setValueCurveAtTime.html [modify] https://crrev.com/6ae3ac58c9bc4d6c20a3ec2dab0b08dd62acb1dc/third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquad-allpass.html [modify] https://crrev.com/6ae3ac58c9bc4d6c20a3ec2dab0b08dd62acb1dc/third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquad-bandpass.html [modify] https://crrev.com/6ae3ac58c9bc4d6c20a3ec2dab0b08dd62acb1dc/third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquad-getFrequencyResponse.html [modify] https://crrev.com/6ae3ac58c9bc4d6c20a3ec2dab0b08dd62acb1dc/third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquad-highpass.html [modify] https://crrev.com/6ae3ac58c9bc4d6c20a3ec2dab0b08dd62acb1dc/third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquad-highshelf.html [modify] https://crrev.com/6ae3ac58c9bc4d6c20a3ec2dab0b08dd62acb1dc/third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquad-lowpass.html [modify] https://crrev.com/6ae3ac58c9bc4d6c20a3ec2dab0b08dd62acb1dc/third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquad-lowshelf.html [modify] https://crrev.com/6ae3ac58c9bc4d6c20a3ec2dab0b08dd62acb1dc/third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquad-notch.html [modify] https://crrev.com/6ae3ac58c9bc4d6c20a3ec2dab0b08dd62acb1dc/third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquad-peaking.html [modify] https://crrev.com/6ae3ac58c9bc4d6c20a3ec2dab0b08dd62acb1dc/third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquad-tail.html [modify] https://crrev.com/6ae3ac58c9bc4d6c20a3ec2dab0b08dd62acb1dc/third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquadfilternode-basic-expected.txt [modify] https://crrev.com/6ae3ac58c9bc4d6c20a3ec2dab0b08dd62acb1dc/third_party/WebKit/LayoutTests/webaudio/BiquadFilter/biquadfilternode-basic.html [modify] https://crrev.com/6ae3ac58c9bc4d6c20a3ec2dab0b08dd62acb1dc/third_party/WebKit/LayoutTests/webaudio/ChannelSplitter/audiochannelsplitter.html [modify] https://crrev.com/6ae3ac58c9bc4d6c20a3ec2dab0b08dd62acb1dc/third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-max-default-delay.html [modify] https://crrev.com/6ae3ac58c9bc4d6c20a3ec2dab0b08dd62acb1dc/third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-max-nondefault-delay.html [modify] https://crrev.com/6ae3ac58c9bc4d6c20a3ec2dab0b08dd62acb1dc/third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-maxdelaylimit.html [modify] https://crrev.com/6ae3ac58c9bc4d6c20a3ec2dab0b08dd62acb1dc/third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-scheduling.html [modify] https://crrev.com/6ae3ac58c9bc4d6c20a3ec2dab0b08dd62acb1dc/third_party/WebKit/LayoutTests/webaudio/Delay/delaynode.html [modify] https://crrev.com/6ae3ac58c9bc4d6c20a3ec2dab0b08dd62acb1dc/third_party/WebKit/LayoutTests/webaudio/DynamicsCompressor/dynamicscompressor-basic.html [modify] https://crrev.com/6ae3ac58c9bc4d6c20a3ec2dab0b08dd62acb1dc/third_party/WebKit/LayoutTests/webaudio/DynamicsCompressor/dynamicscompressor-simple.html [modify] https://crrev.com/6ae3ac58c9bc4d6c20a3ec2dab0b08dd62acb1dc/third_party/WebKit/LayoutTests/webaudio/Gain/gain.html [modify] https://crrev.com/6ae3ac58c9bc4d6c20a3ec2dab0b08dd62acb1dc/third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-constructor.html [modify] https://crrev.com/6ae3ac58c9bc4d6c20a3ec2dab0b08dd62acb1dc/third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-suspend-resume-eventhandler.html [modify] https://crrev.com/6ae3ac58c9bc4d6c20a3ec2dab0b08dd62acb1dc/third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-suspend-resume-graph-manipulation.html [modify] https://crrev.com/6ae3ac58c9bc4d6c20a3ec2dab0b08dd62acb1dc/third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-suspend-resume-promise.html [modify] https://crrev.com/6ae3ac58c9bc4d6c20a3ec2dab0b08dd62acb1dc/third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-suspend-resume-sequence.html [modify] https://crrev.com/6ae3ac58c9bc4d6c20a3ec2dab0b08dd62acb1dc/third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/onstatechange.html [modify] https://crrev.com/6ae3ac58c9bc4d6c20a3ec2dab0b08dd62acb1dc/third_party/WebKit/LayoutTests/webaudio/Panner/hrtf-database.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2f8decb30a8027145aa003cc7cf7ae5d094e9695 commit 2f8decb30a8027145aa003cc7cf7ae5d094e9695 Author: rtoy <rtoy@chromium.org> Date: Fri Mar 17 21:42:10 2017 Move task.describe to audit.define arg Manually changed all calls to task.describe to move the description to audit.define. Also used clang-format to reformat code due to adding the dictionary arg for audit.define. For a few tests, the description was slightyl modified to be more concise. For dom-execptions, some task.describe strings were removed since they were redundant, being the same as the test label. BUG= 694659 TEST=no change in expected results; just changes in messages Review-Url: https://codereview.chromium.org/2727663003 Cr-Commit-Position: refs/heads/master@{#457890} [modify] https://crrev.com/2f8decb30a8027145aa003cc7cf7ae5d094e9695/third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-channels.html [modify] https://crrev.com/2f8decb30a8027145aa003cc7cf7ae5d094e9695/third_party/WebKit/LayoutTests/webaudio/AudioContext/audiocontext-max-contexts.html [modify] https://crrev.com/2f8decb30a8027145aa003cc7cf7ae5d094e9695/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-cancel-and-hold.html [modify] https://crrev.com/2f8decb30a8027145aa003cc7cf7ae5d094e9695/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-exceptional-values.html [modify] https://crrev.com/2f8decb30a8027145aa003cc7cf7ae5d094e9695/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-exponentialRampToValueAtTime.html [modify] https://crrev.com/2f8decb30a8027145aa003cc7cf7ae5d094e9695/third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-k-rate.html [modify] https://crrev.com/2f8decb30a8027145aa003cc7cf7ae5d094e9695/third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-maxdelay.html [modify] https://crrev.com/2f8decb30a8027145aa003cc7cf7ae5d094e9695/third_party/WebKit/LayoutTests/webaudio/DynamicsCompressor/dynamicscompressor-clear-internal-state.html [modify] https://crrev.com/2f8decb30a8027145aa003cc7cf7ae5d094e9695/third_party/WebKit/LayoutTests/webaudio/OfflineAudioContext/offlineaudiocontext-promise.html [modify] https://crrev.com/2f8decb30a8027145aa003cc7cf7ae5d094e9695/third_party/WebKit/LayoutTests/webaudio/Oscillator/start-sampling.html [modify] https://crrev.com/2f8decb30a8027145aa003cc7cf7ae5d094e9695/third_party/WebKit/LayoutTests/webaudio/Panner/distance-exponential.html [modify] https://crrev.com/2f8decb30a8027145aa003cc7cf7ae5d094e9695/third_party/WebKit/LayoutTests/webaudio/Panner/distance-linear.html [modify] https://crrev.com/2f8decb30a8027145aa003cc7cf7ae5d094e9695/third_party/WebKit/LayoutTests/webaudio/StereoPanner/stereopannernode-basic.html [modify] https://crrev.com/2f8decb30a8027145aa003cc7cf7ae5d094e9695/third_party/WebKit/LayoutTests/webaudio/WaveShaper/waveshaper-limits.html [modify] https://crrev.com/2f8decb30a8027145aa003cc7cf7ae5d094e9695/third_party/WebKit/LayoutTests/webaudio/audio-scheduled-source-basic.html [modify] https://crrev.com/2f8decb30a8027145aa003cc7cf7ae5d094e9695/third_party/WebKit/LayoutTests/webaudio/codec-tests/webm/webm-decode.html [modify] https://crrev.com/2f8decb30a8027145aa003cc7cf7ae5d094e9695/third_party/WebKit/LayoutTests/webaudio/dom-exceptions-expected.txt [modify] https://crrev.com/2f8decb30a8027145aa003cc7cf7ae5d094e9695/third_party/WebKit/LayoutTests/webaudio/dom-exceptions.html [modify] https://crrev.com/2f8decb30a8027145aa003cc7cf7ae5d094e9695/third_party/WebKit/LayoutTests/webaudio/resources/audit.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ea7d86e1350c0e1d8c8f9c4ef6185c1a97fd1317 commit ea7d86e1350c0e1d8c8f9c4ef6185c1a97fd1317 Author: rtoy <rtoy@chromium.org> Date: Wed Mar 22 18:57:40 2017 Remove one more task.describe call Missed this in the previous CL removing task.describe. BUG= 694659 TEST=waveshaper-oversample-{2x,4x} tests now pass instead of harness error Review-Url: https://codereview.chromium.org/2766253002 Cr-Commit-Position: refs/heads/master@{#458823} [modify] https://crrev.com/ea7d86e1350c0e1d8c8f9c4ef6185c1a97fd1317/third_party/WebKit/LayoutTests/webaudio/resources/audit.js [modify] https://crrev.com/ea7d86e1350c0e1d8c8f9c4ef6185c1a97fd1317/third_party/WebKit/LayoutTests/webaudio/resources/waveshaper-testing.js
Comment 1 by hongchan@chromium.org
, Feb 22 2017Status: Started (was: Available)