Remove support for experimental WebAssembly version 0xD |
|||||||||
Issue descriptionAs per title For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Feb 21 2017
Could you please add bug description and link to CL here?
,
Feb 21 2017
Also pls apply appropriate OS labels. Thank you.
,
Feb 22 2017
In Chrome 57 and 58, V8 currently accepts both version 0xD (experimental) and 0x1 (official) binary formats for WebAssembly. The following CL removes the 0xD support: CL is here: https://codereview.chromium.org/2709753003/
,
Feb 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/c8329253ea345e06a923f7800f96f4ef59262997 commit c8329253ea345e06a923f7800f96f4ef59262997 Author: titzer <titzer@chromium.org> Date: Wed Feb 22 12:06:09 2017 [wasm] Remove support for experimental version 0xD. R=mtrofin@chromium.org BUG=chromium:575167, chromium:694657 Review-Url: https://codereview.chromium.org/2709753003 Cr-Commit-Position: refs/heads/master@{#43368} [modify] https://crrev.com/c8329253ea345e06a923f7800f96f4ef59262997/src/wasm/module-decoder.cc [modify] https://crrev.com/c8329253ea345e06a923f7800f96f4ef59262997/src/wasm/module-decoder.h [modify] https://crrev.com/c8329253ea345e06a923f7800f96f4ef59262997/test/mjsunit/wasm/jsapi-harness.js
,
Feb 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/5004748868a15be9ba47727ab15c278fcca4f2b1 commit 5004748868a15be9ba47727ab15c278fcca4f2b1 Author: machenbach <machenbach@chromium.org> Date: Wed Feb 22 13:59:23 2017 Revert of [wasm] Remove support for experimental version 0xD. (patchset #3 id:40001 of https://codereview.chromium.org/2709753003/ ) Reason for revert: Breaks layout tests: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/13730 Original issue's description: > [wasm] Remove support for experimental version 0xD. > > R=mtrofin@chromium.org > BUG=chromium:575167, chromium:694657 > > Review-Url: https://codereview.chromium.org/2709753003 > Cr-Commit-Position: refs/heads/master@{#43368} > Committed: https://chromium.googlesource.com/v8/v8/+/c8329253ea345e06a923f7800f96f4ef59262997 TBR=ahaas@chromium.org,mtrofin@chromium.org,titzer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:575167, chromium:694657 Review-Url: https://codereview.chromium.org/2706303004 Cr-Commit-Position: refs/heads/master@{#43373} [modify] https://crrev.com/5004748868a15be9ba47727ab15c278fcca4f2b1/src/wasm/module-decoder.cc [modify] https://crrev.com/5004748868a15be9ba47727ab15c278fcca4f2b1/src/wasm/module-decoder.h [modify] https://crrev.com/5004748868a15be9ba47727ab15c278fcca4f2b1/test/mjsunit/wasm/jsapi-harness.js
,
Feb 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/85df088e0310cbb08280e453afc371faa01d0042 commit 85df088e0310cbb08280e453afc371faa01d0042 Author: mtrofin <mtrofin@chromium.org> Date: Wed Feb 22 19:44:19 2017 [wasm] bump version of binary incrementer.wasm to 0x1 This is in preparation of v8 supporting that version only. It currently supports both 0x1 and 0xD. BUG=chromium:575167 BUG= chromium:694657 Review-Url: https://codereview.chromium.org/2710033002 Cr-Commit-Position: refs/heads/master@{#452165} [modify] https://crrev.com/85df088e0310cbb08280e453afc371faa01d0042/third_party/WebKit/LayoutTests/http/tests/wasm/incrementer.wasm
,
Feb 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/6a09a41622d65d07fcb4436ddfaaaa6a9cad2467 commit 6a09a41622d65d07fcb4436ddfaaaa6a9cad2467 Author: titzer <titzer@chromium.org> Date: Wed Feb 22 21:02:39 2017 [wasm] Remove support for experimental version 0xD. R=mtrofin@chromium.org BUG=chromium:575167, chromium:694657 Review-Url: https://codereview.chromium.org/2709753003 Cr-Original-Commit-Position: refs/heads/master@{#43368} Committed: https://chromium.googlesource.com/v8/v8/+/c8329253ea345e06a923f7800f96f4ef59262997 Review-Url: https://codereview.chromium.org/2709753003 Cr-Commit-Position: refs/heads/master@{#43383} [modify] https://crrev.com/6a09a41622d65d07fcb4436ddfaaaa6a9cad2467/src/wasm/module-decoder.cc [modify] https://crrev.com/6a09a41622d65d07fcb4436ddfaaaa6a9cad2467/src/wasm/module-decoder.h [modify] https://crrev.com/6a09a41622d65d07fcb4436ddfaaaa6a9cad2467/test/mjsunit/wasm/jsapi-harness.js
,
Feb 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/e22438bbc6935b0d11cccf6193344c1000b4d6a2 commit e22438bbc6935b0d11cccf6193344c1000b4d6a2 Author: Brad Nelson <bradnelson@chromium.org> Date: Wed Feb 22 21:24:07 2017 Merged: [wasm] Remove support for experimental version 0xD. Revision: 6a09a41622d65d07fcb4436ddfaaaa6a9cad2467 BUG=chromium:575167, chromium:694657 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=mtrofin@chromium.org Review-Url: https://codereview.chromium.org/2708373004 . Cr-Commit-Position: refs/branch-heads/5.7@{#128} Cr-Branched-From: 975e9a320b6eaf9f12280c35df98e013beb8f041-refs/heads/5.7.492@{#1} Cr-Branched-From: 8d76f0e3465a84bbf0bceab114900fbe75844e1f-refs/heads/master@{#42426} [modify] https://crrev.com/e22438bbc6935b0d11cccf6193344c1000b4d6a2/src/wasm/module-decoder.cc [modify] https://crrev.com/e22438bbc6935b0d11cccf6193344c1000b4d6a2/src/wasm/wasm-module.h
,
Feb 22 2017
Cl listed at #9 got merged to M57 without approval. Also this is reported as P3, can't this wait until M58?
,
Feb 22 2017
This merge is ok because it is only affecting WASM. The prio should be 1, because it is a planned prerequisite for the coordinated launch. I am wondering too why it was facilitated like that though. I suppose you also might want to merge https://chromium.googlesource.com/chromium/src.git/+/85df088e0310cbb08280e453afc371faa01d0042? Is this bug fixed btw?
,
Feb 22 2017
Actually, you're right we need that one too, ok to merge?
,
Feb 22 2017
,
Feb 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9413c369cb4d9457015b9fe0401630eef3b0bad6 commit 9413c369cb4d9457015b9fe0401630eef3b0bad6 Author: Brad Nelson <bradnelson@chromium.org> Date: Wed Feb 22 23:19:38 2017 [wasm] bump version of binary incrementer.wasm to 0x1 This is in preparation of v8 supporting that version only. It currently supports both 0x1 and 0xD. BUG=chromium:575167 BUG= chromium:694657 Review-Url: https://codereview.chromium.org/2710033002 Cr-Commit-Position: refs/heads/master@{#452165} (cherry picked from commit 85df088e0310cbb08280e453afc371faa01d0042) Review-Url: https://codereview.chromium.org/2707263007 . Cr-Commit-Position: refs/branch-heads/2987@{#648} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} [modify] https://crrev.com/9413c369cb4d9457015b9fe0401630eef3b0bad6/third_party/WebKit/LayoutTests/http/tests/wasm/incrementer.wasm
,
Feb 23 2017
This bug requires manual review: Reverts referenced in bugdroid comments after merge request. Please contact the milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 23 2017
Per comment #9 and #14, changes are already merged to M57. If nothing is pending for M57, hablich@, could you please remove "Merge-Review-57" label. Thank you.
,
Feb 24 2017
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by titzer@chromium.org
, Feb 21 2017