CheckCausesDistinctBreakpoints failing test on ios tree |
||
Issue descriptionIt seems that landing https://codereview.chromium.org/2705053002/ broke ios internal tree. The error log: [25082:2567:0221/100328.139124:66109627197722:FATAL:logging_unittest.cc(199)] Check failed: !mock_log_source.Log(). check message: Operation not permitted [25082:2567:0221/100328.139158:66109627198520:FATAL:logging_unittest.cc(202)] Check failed: mock_log_source.Log() != mock_log_source.Log() (check message vs. check message)check message [ OK ] LoggingTest.CheckStreamsAreLazy (0 ms) [ RUN ] LoggingTest.CheckCausesDistinctBreakpoints ../../base/logging_unittest.cc:323: Failure Expected: (pid) >= (0), actual: -1 vs 0 ../../base/logging_unittest.cc:323: Failure Expected: (pid) >= (0), actual: -1 vs 0 ../../base/logging_unittest.cc:323: Failure Expected: (pid) >= (0), actual: -1 vs 0 ../../base/logging_unittest.cc:347: Failure Expected: (0u) != (child_crash_addr_1), actual: 0 vs 0 [ FAILED ] LoggingTest.CheckCausesDistinctBreakpoints (0 ms)
,
Feb 21 2017
,
Feb 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b4da3caa626c8a43cfe73a1f415d1edf58ebb35b commit b4da3caa626c8a43cfe73a1f415d1edf58ebb35b Author: primiano <primiano@chromium.org> Date: Tue Feb 21 21:50:27 2017 test: disable LoggingTest.CheckCausesDistinctBreakpoints on iOS Follow up to crrev.com/2705053002 . The test seems to break iOS. Disabling the test, given that the actual change to logging.h does not affect iOS. BUG= 694655 Review-Url: https://codereview.chromium.org/2707123002 Cr-Commit-Position: refs/heads/master@{#451840} [modify] https://crrev.com/b4da3caa626c8a43cfe73a1f415d1edf58ebb35b/base/logging_unittest.cc
,
Feb 22 2017
A link to the original bot step that failed would really helped. I have no idea how to check if this is fixed, given that I don't have a link to what I broke (other than the msg in #0) :)
,
Jul 7 2017
As per previous comment, not sure what to do more than #3. |
||
►
Sign in to add a comment |
||
Comment 1 by mrefaat@chromium.org
, Feb 21 2017