Unit test failures in security_SandboxLinuxUnittests |
|||||||
Issue descriptionSeveral BrokerFilePermission tests in security_SandboxLinuxUnittests are failing on the informational PFQ builders: https://uberchromegw.corp.google.com/i/chromeos.chrome/builders/peach_pit-tot-chrome-pfq-informational/builds/4909 ... [226/229] BrokerFilePermission.CreateGood (2 ms) [227/229] BrokerFilePermission.CreateGoodRecursive (2 ms) [ RUN ] BrokerFilePermission.CreateBad ../../../../../../../home/chrome-bot/chrome_root/src/sandbox/linux/tests/unit_tests.cc:283: Failure Value of: subprocess_terminated_normally Actual: false Expected: true Exit status: 133 [ FAILED ] BrokerFilePermission.CreateBad (144 ms) [228/229] BrokerFilePermission.CreateBad (144 ms) [ RUN ] BrokerFilePermission.CreateBadRecursive ../../../../../../../home/chrome-bot/chrome_root/src/sandbox/linux/tests/unit_tests.cc:283: Failure Value of: subprocess_terminated_normally Actual: false Expected: true Exit status: 133 [ FAILED ] BrokerFilePermission.CreateBadRecursive (148 ms) [229/229] BrokerFilePermission.CreateBadRecursive (148 ms) Retrying 4 tests (retry #1) [ RUN ] BrokerFilePermission.CreateBadRecursive ../../../../../../../home/chrome-bot/chrome_root/src/sandbox/linux/tests/unit_tests.cc:283: Failure Value of: subprocess_terminated_normally Actual: false Expected: true Exit status: 133 [ FAILED ] BrokerFilePermission.CreateBadRecursive (89 ms) [230/233] BrokerFilePermission.CreateBadRecursive (89 ms) [ RUN ] BrokerFilePermission.CreateBadNotAbs ../../../../../../../home/chrome-bot/chrome_root/src/sandbox/linux/tests/unit_tests.cc:283: Failure Value of: subprocess_terminated_normally Actual: false Expected: true Exit status: 133 [ FAILED ] BrokerFilePermission.CreateBadNotAbs (71 ms) [231/233] BrokerFilePermission.CreateBadNotAbs (71 ms) [ RUN ] BrokerFilePermission.CreateBadEmpty ../../../../../../../home/chrome-bot/chrome_root/src/sandbox/linux/tests/unit_tests.cc:283: Failure Value of: subprocess_terminated_normally Actual: false Expected: true Exit status: 133 [ FAILED ] BrokerFilePermission.CreateBadEmpty (70 ms) [232/233] BrokerFilePermission.CreateBadEmpty (70 ms) [ RUN ] BrokerFilePermission.CreateBad ../../../../../../../home/chrome-bot/chrome_root/src/sandbox/linux/tests/unit_tests.cc:283: Failure Value of: subprocess_terminated_normally Actual: false Expected: true Exit status: 133 [ FAILED ] BrokerFilePermission.CreateBad (84 ms) [233/233] BrokerFilePermission.CreateBad (84 ms) Retrying 4 tests (retry #2) [ RUN ] BrokerFilePermission.CreateBadRecursive ../../../../../../../home/chrome-bot/chrome_root/src/sandbox/linux/tests/unit_tests.cc:283: Failure Value of: subprocess_terminated_normally Actual: false Expected: true Exit status: 133 [ FAILED ] BrokerFilePermission.CreateBadRecursive (69 ms) [234/237] BrokerFilePermission.CreateBadRecursive (69 ms) [ RUN ] BrokerFilePermission.CreateBadNotAbs ../../../../../../../home/chrome-bot/chrome_root/src/sandbox/linux/tests/unit_tests.cc:283: Failure Value of: subprocess_terminated_normally Actual: false Expected: true Exit status: 133 [ FAILED ] BrokerFilePermission.CreateBadNotAbs (83 ms) [235/237] BrokerFilePermission.CreateBadNotAbs (83 ms) [ RUN ] BrokerFilePermission.CreateBadEmpty ../../../../../../../home/chrome-bot/chrome_root/src/sandbox/linux/tests/unit_tests.cc:283: Failure Value of: subprocess_terminated_normally Actual: false Expected: true Exit status: 133 [ FAILED ] BrokerFilePermission.CreateBadEmpty (74 ms) [236/237] BrokerFilePermission.CreateBadEmpty (74 ms) [ RUN ] BrokerFilePermission.CreateBad ../../../../../../../home/chrome-bot/chrome_root/src/sandbox/linux/tests/unit_tests.cc:283: Failure Value of: subprocess_terminated_normally Actual: false Expected: true Exit status: 133 [ FAILED ] BrokerFilePermission.CreateBad (117 ms) [237/237] BrokerFilePermission.CreateBad (117 ms) Retrying 4 tests (retry #3) [ RUN ] BrokerFilePermission.CreateBadRecursive ../../../../../../../home/chrome-bot/chrome_root/src/sandbox/linux/tests/unit_tests.cc:283: Failure Value of: subprocess_terminated_normally Actual: false Expected: true Exit status: 133 [ FAILED ] BrokerFilePermission.CreateBadRecursive (80 ms) [238/241] BrokerFilePermission.CreateBadRecursive (80 ms) [ RUN ] BrokerFilePermission.CreateBadNotAbs ../../../../../../../home/chrome-bot/chrome_root/src/sandbox/linux/tests/unit_tests.cc:283: Failure Value of: subprocess_terminated_normally Actual: false Expected: true Exit status: 133 [ FAILED ] BrokerFilePermission.CreateBadNotAbs (81 ms) [239/241] BrokerFilePermission.CreateBadNotAbs (81 ms) [ RUN ] BrokerFilePermission.CreateBadEmpty ../../../../../../../home/chrome-bot/chrome_root/src/sandbox/linux/tests/unit_tests.cc:283: Failure Value of: subprocess_terminated_normally Actual: false Expected: true Exit status: 133 [ FAILED ] BrokerFilePermission.CreateBadEmpty (545 ms) [240/241] BrokerFilePermission.CreateBadEmpty (545 ms) [ RUN ] BrokerFilePermission.CreateBad ../../../../../../../home/chrome-bot/chrome_root/src/sandbox/linux/tests/unit_tests.cc:283: Failure Value of: subprocess_terminated_normally Actual: false Expected: true Exit status: 133 [ FAILED ] BrokerFilePermission.CreateBad (79 ms) [241/241] BrokerFilePermission.CreateBad (79 ms) 4 tests failed: BrokerFilePermission.CreateBad (../../../../../../../home/chrome-bot/chrome_root/src/sandbox/linux/syscall_broker/broker_file_permission_unittest.cc:59) BrokerFilePermission.CreateBadEmpty (../../../../../../../home/chrome-bot/chrome_root/src/sandbox/linux/syscall_broker/broker_file_permission_unittest.cc:86) BrokerFilePermission.CreateBadNotAbs (../../../../../../../home/chrome-bot/chrome_root/src/sandbox/linux/syscall_broker/broker_file_permission_unittest.cc:77) BrokerFilePermission.CreateBadRecursive (../../../../../../../home/chrome-bot/chrome_root/src/sandbox/linux/syscall_broker/broker_file_permission_unittest.cc:68)
,
Feb 21 2017
primiano: could you please take a look?
,
Feb 21 2017
RE: #1, yes that is definitely intended. Just sad that all these tests keep falling apart after the CL has landed. +rsesek@ I guess broker_file_permission_unittest.cc was just matching whatever was the default behavior back then. ANy objection if I change the expectation to be SIGTRAP instead of SIGILL?
,
Feb 21 2017
,
Feb 21 2017
Yes that sounds fine.
,
Feb 22 2017
https://codereview.chromium.org/2709203002 on its way
,
Feb 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5d04cccc168b54e6d05f7e9efbb180d87583b30b commit 5d04cccc168b54e6d05f7e9efbb180d87583b30b Author: primiano <primiano@chromium.org> Date: Wed Feb 22 18:06:41 2017 sandbox tests: Adapt test expectations to new CHECK() behavior Adapt the test expectations to the changes to official CHECK() introduced by https://crrev.com/2705053002. After that CL, CHECK() almost always causes a SIGTRAP with the exception of armv7 code running on a 32-bit arm kernel, where it causes a SIGBUS. However, the latter case is not interesting for the sandbox as it is not enabled on 32-bit arm kernels due to the lack of tsync. BUG= 694652 TEST=Build with is_official_build=true, run out/X/sandbox_linux_unittests Review-Url: https://codereview.chromium.org/2709203002 Cr-Commit-Position: refs/heads/master@{#452125} [modify] https://crrev.com/5d04cccc168b54e6d05f7e9efbb180d87583b30b/sandbox/linux/syscall_broker/broker_file_permission_unittest.cc [modify] https://crrev.com/5d04cccc168b54e6d05f7e9efbb180d87583b30b/sandbox/linux/tests/unit_tests.cc
,
Feb 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/83662024bf52a68136f147e498d861b23e3c9203 commit 83662024bf52a68136f147e498d861b23e3c9203 Author: Alexander Alekseev <alemate@chromium.org> Date: Wed Feb 22 19:34:52 2017 sandbox tests: Adapt test expectations to new CHECK() behavior Adapt the test expectations to the changes to official CHECK() introduced by https://crrev.com/2705053002. After that CL, CHECK() almost always causes a SIGTRAP with the exception of armv7 code running on a 32-bit arm kernel, where it causes a SIGBUS. However, the latter case is not interesting for the sandbox as it is not enabled on 32-bit arm kernels due to the lack of tsync. BUG= 694652 TEST=Build with is_official_build=true, run out/X/sandbox_linux_unittests Review-Url: https://codereview.chromium.org/2709203002 Cr-Commit-Position: refs/heads/master@{#452125} (cherry picked from commit 5d04cccc168b54e6d05f7e9efbb180d87583b30b) Review-Url: https://codereview.chromium.org/2710683006 . Cr-Commit-Position: refs/branch-heads/3020@{#3} Cr-Branched-From: 22a030be0c75c7a39b938d51d04bcc259bf9fe17-refs/heads/master@{#451874} [modify] https://crrev.com/83662024bf52a68136f147e498d861b23e3c9203/sandbox/linux/syscall_broker/broker_file_permission_unittest.cc [modify] https://crrev.com/83662024bf52a68136f147e498d861b23e3c9203/sandbox/linux/tests/unit_tests.cc
,
Apr 27 2017
Seems fixed?
,
Apr 28 2017
oh yeah sorry, forgot to update the bug. Yup, fixed. thanks for triaging.
,
Aug 3 2017
Closing. Please reopen it if its not fixed. Thanks! |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by domlasko...@chromium.org
, Feb 21 2017Status: Available (was: Untriaged)