New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 694650 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2017
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Merge fix for chromedriver automation extension to m57 branch

Project Member Reported by samu...@chromium.org, Feb 21 2017

Issue description

More context is available in  issue chromedriver:1625 .

We need to merge crrev.com/450257 and crrev.com/450581 into the M57 branch. Without these CLs, a number of WebDriver commands are broken in Chrome 57.

The patches have been in canary for a week now and haven't caused problems. I've verified that they fix the issue we were seeing.
 
Labels: -Pri-3 Merge-Request-57 Pri-1
Labels: OS-Mac OS-Windows

Comment 3 by gov...@chromium.org, Feb 21 2017

Labels: -Merge-Request-57 Merge-Approved-57
Approving merge to M57 branch 2987 based on samuong@ update in original bug description. Please merge ASAP (If merge happens today before 5:00 PM PT, then we can pick it up for tomorrow's M57 Beta release) Thank you.
Labels: -Merge-Approved-57 Merge-Merged
Owner: samu...@chromium.org
Status: Fixed (was: Unconfirmed)
Thanks! This is now merged:

https://chromium.googlesource.com/chromium/src/+/795fb79651648d3da7c538aafc2b548e25299912
https://chromium.googlesource.com/chromium/src/+/130867c44e3c11a69fff053dff567186b6b3859f
Labels: -Merge-Merged Merge-Request-57
Status: Started (was: Fixed)
Reopening because we need to merge in one more CL: https://chromium.googlesource.com/chromium/src/+/20e8838145837ef381ebe3116c4af6bb1734b116

This has been in Canary for about two days now. It fixes some flakiness issues on pages where infobars appear, and hasn't caused any regressions for us.
Project Member

Comment 6 by sheriffbot@chromium.org, Feb 28 2017

Labels: -Merge-Request-57 Hotlist-Merge-Review Merge-Review-57
This bug requires manual review: We are only 13 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 by gov...@chromium.org, Feb 28 2017

Approving merge to M57 branch 2987 based on comment #5. Please merge ASAP. Thank you.
Labels: -Merge-Review-57 Merge-Merged
Status: Fixed (was: Started)
Labels: -Merge-Merged merge-merged-2987 Merge-Approved-57
Labels: -Merge-Approved-57

Sign in to add a comment