New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 694627 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Sep 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

31.5% regression in smoothness.tough_filters_cases at 450552:450599

Project Member Reported by rsch...@chromium.org, Feb 21 2017

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=694627

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg-IG2pwoM


Bot(s) for this bug's original alert(s):

android-one
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Feb 21 2017


=== BISECT JOB RESULTS ===
NO Perf regression found

Bisect Details
  Configuration: android_one_perf_bisect
  Benchmark    : smoothness.tough_filters_cases
  Metric       : frame_times/http___static.bobdo.net_Analog_Clock.svg

Revision             Result                  N
chromium@450551      63.5359 +- 26.2246      21      good
chromium@450599      66.6687 +- 25.5643      21      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=http...static.bobdo.net.Analog.Clock.svg smoothness.tough_filters_cases

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8987028956502343344

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5257393216159744


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Feb 21 2017


=== BISECT JOB RESULTS ===
NO Perf regression found

Bisect Details
  Configuration: android_one_perf_bisect
  Benchmark    : smoothness.tough_filters_cases
  Metric       : frame_times/http___static.bobdo.net_Analog_Clock.svg

Revision             Result                  N
chromium@450551      64.4561 +- 27.5289      21      good
chromium@450599      64.5859 +- 32.1562      21      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=http...static.bobdo.net.Analog.Clock.svg smoothness.tough_filters_cases

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8987018405357062736

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=6397355382800384


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Project Member

Comment 7 by 42576172...@developer.gserviceaccount.com, Feb 27 2017

Cc: dgozman@chromium.org
Owner: dgozman@chromium.org

=== Auto-CCing suspected CL author dgozman@chromium.org ===

Hi dgozman@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : dgozman
  Commit : 733d09b5b7c0edd6e59d10e9e9d7a7fd81ab3509
  Date   : Tue Feb 14 21:24:06 2017
  Subject: [DevTools] Always issue resize on viewport in FilteredListWidget.

Bisect Details
  Configuration: android_one_perf_bisect
  Benchmark    : smoothness.tough_filters_cases
  Metric       : frame_times/http___static.bobdo.net_Analog_Clock.svg
  Change       : 21.22% | 50.2771441507 -> 60.9465964525

Revision             Result                  N
chromium@450439      50.2771 +- 17.5939      14      good
chromium@450459      55.3216 +- 1.78048      6       good
chromium@450469      52.8305 +- 12.0909      6       good
chromium@450474      61.8068 +- 18.8769      6       good
chromium@450477      60.3498 +- 16.1198      6       good
chromium@450478      61.4069 +- 17.7666      6       good
chromium@450479      69.969 +- 1.11866       6       bad       <--
chromium@450519      63.3802 +- 12.7226      6       bad
chromium@450599      60.9466 +- 26.9484      14      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=http...static.bobdo.net.Analog.Clock.svg smoothness.tough_filters_cases

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8986484153540371056

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=4721968793780224


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Owner: rsch...@chromium.org
The patch in question is DevTools front end patch, which cannot affect any telemetry benchmark - the code is not run. Please run bisect again.
Labels: Performance-Responsiveness
Status: Assigned (was: Untriaged)
Explictly assigning. A CL you landed tripped one of the speed metrics we measure in the lab. If this is the first time this has happened to one of your CLs, or if it's been a while, please read: https://chromium.googlesource.com/chromium/src/+/master/docs/speed/addressing_performance_regressions.md

We're looking for one of the following:
1. Justification via explanation
2. Plan to revert or fix
3. Angry rage throwing of equipment at my head

Just be aware that I'm trained in trumpet playing and First Aid and am not afraid to use it.

Note: This was a bulk edit message and not very personal.
Status: WontFix (was: Assigned)
Bisect didn't come back.

This regression was only on one device, with no ref build, two bisects couldn't repro, one gave suspicious results. 7 months later, it's really unlikely we'll fix this.

Sign in to add a comment