Make phone number optional in PR billing addresses |
|||
Issue descriptionWith the recent change of converting the Wallet Addresses to local Autofill profiles, one of the most important impact was that the Wallet cards would automatically be associated with the new converted address (before they were linked to nothing). The problem is that these addresses usually don't have a phone number, which makes the PR dialog make the user edit that address. By making the phone number optional, the users will have a billing address ready, will not need to change it and thus this increases the chance of them completing the flow, as proved by our metrics. This change should not affect shipping addresses. Also if a user decides to edit a billing address, they should still have to enter a phone number.
,
Feb 22 2017
Picture might be more clear. 1) See that the user can click pay, even if the billing address has no phone. 2) See that that address can't be picked as a shipping without adding a phone. 3) See that editing the card does not require to change or update the billing address. 3) See that the billing address without phone was sent to the merchant.
,
Feb 22 2017
What happens when user taps on billing address dropdown in Step3.jpg?
,
Feb 22 2017
The dropdown opens up and you can chose another address or keep that one. Addresses without phones can be selected too, but complete addresses will be suggested first.
,
Feb 22 2017
Looks good. Ship it!
,
Feb 22 2017
LGTM
,
Feb 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fa14f647f440cd6b669d3d6fab4792d12ec0a034 commit fa14f647f440cd6b669d3d6fab4792d12ec0a034 Author: sebsg <sebsg@chromium.org> Date: Mon Feb 27 23:24:06 2017 [Payments] Make phone number optional for billing addresses. Makes the phone number optional for already existing billing addresses. When editing or adding a new address, the phone number is still mandatory. BUG= 694598 Review-Url: https://codereview.chromium.org/2715783004 Cr-Commit-Position: refs/heads/master@{#453385} [modify] https://crrev.com/fa14f647f440cd6b669d3d6fab4792d12ec0a034/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillAddress.java [modify] https://crrev.com/fa14f647f440cd6b669d3d6fab4792d12ec0a034/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentApp.java [modify] https://crrev.com/fa14f647f440cd6b669d3d6fab4792d12ec0a034/chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java [modify] https://crrev.com/fa14f647f440cd6b669d3d6fab4792d12ec0a034/chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java [modify] https://crrev.com/fa14f647f440cd6b669d3d6fab4792d12ec0a034/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestSection.java [modify] https://crrev.com/fa14f647f440cd6b669d3d6fab4792d12ec0a034/chrome/android/java_sources.gni [modify] https://crrev.com/fa14f647f440cd6b669d3d6fab4792d12ec0a034/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestBillingAddressTest.java [add] https://crrev.com/fa14f647f440cd6b669d3d6fab4792d12ec0a034/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestBillingAddressWithoutPhoneTest.java [modify] https://crrev.com/fa14f647f440cd6b669d3d6fab4792d12ec0a034/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java
,
Feb 28 2017
,
Jun 27 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by se...@chromium.org
, Feb 22 20174.6 MB
4.6 MB View Download