New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 694597 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

USB-C: DFP_D should prefer pin assignments C&D over E&F for USB-C to USB-C connection

Project Member Reported by tbroch@chromium.org, Feb 21 2017

Issue description

USB-C DFP_D should prefer pin assignments C&D over E&F for USB-C to USB-C connection

While a UFP_D may advertise pin assignments C/D/E/F the DFP_D should always prefer C&D over E&F.


 
Also, DP adapters (dingdong) should only ever pick E, in both normal C-to-legacy and in reversed legacy-to-C modes.
Is there an update here?
https://chromium-review.googlesource.com/c/465379

Haven't had a chance to test.  As for dingdong it already picks 'E'
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/ec/+/a8e6b070cbd107d8c2f44f44ae8231a4f4efea90

commit a8e6b070cbd107d8c2f44f44ae8231a4f4efea90
Author: Todd Broch <tbroch@chromium.org>
Date: Fri Apr 07 03:05:08 2017

pd: prefer CD pin assignments over EF for USBC->USBC case.

BRANCH=samus,glados,oak,gru,reef
BUG= chromium:694597 
TEST=manual, connect samus to USB-C monitor via cable and see it
select pin assigmnent 'C'

Change-Id: Iddad5b654715bd30ba081c62f8fb53e07816498c
Reviewed-on: https://chromium-review.googlesource.com/465379
Commit-Ready: Todd Broch <tbroch@chromium.org>
Tested-by: Todd Broch <tbroch@chromium.org>
Reviewed-by: Vincent Palatin <vpalatin@chromium.org>

[modify] https://crrev.com/a8e6b070cbd107d8c2f44f44ae8231a4f4efea90/common/usb_pd_policy.c

Project Member

Comment 5 by bugdroid1@chromium.org, May 8 2017

Labels: merge-merged-firmware-gru-8785.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/ec/+/473a8ed673bcd33d78d2a86db0518be445c3b61d

commit 473a8ed673bcd33d78d2a86db0518be445c3b61d
Author: Todd Broch <tbroch@chromium.org>
Date: Mon May 08 21:39:37 2017

pd: prefer CD pin assignments over EF for USBC->USBC case.

Signed-off-by: Todd Broch <tbroch@chromium.org>

BRANCH=samus,glados,oak,gru,reef
BUG= chromium:694597 
TEST=manual, connect samus to USB-C monitor via cable and see it
select pin assigmnent 'C'

Original-Change-Id: Iddad5b654715bd30ba081c62f8fb53e07816498c
Originally-Reviewed-on: https://chromium-review.googlesource.com/465379
Commit-Ready: Todd Broch <tbroch@chromium.org>
Tested-by: Todd Broch <tbroch@chromium.org>
Reviewed-by: Vincent Palatin <vpalatin@chromium.org>
(cherry picked from commit a8e6b070cbd107d8c2f44f44ae8231a4f4efea90)

Change-Id: I70ed304b7941f9a49582e8f82122b9f15f396ef6
Reviewed-on: https://chromium-review.googlesource.com/494074
Tested-by: Todd Broch <tbroch@chromium.org>
Trybot-Ready: Todd Broch <tbroch@chromium.org>
Commit-Queue: Todd Broch <tbroch@chromium.org>
Reviewed-by: Vincent Palatin <vpalatin@chromium.org>

[modify] https://crrev.com/473a8ed673bcd33d78d2a86db0518be445c3b61d/common/usb_pd_policy.c

Project Member

Comment 6 by bugdroid1@chromium.org, May 18 2017

Labels: merge-merged-firmware-glados-7820.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/ec/+/13d3bfda870cfaf0debc7c676c91c10d5a990af0

commit 13d3bfda870cfaf0debc7c676c91c10d5a990af0
Author: Todd Broch <tbroch@chromium.org>
Date: Thu May 18 17:05:16 2017

pd: prefer CD pin assignments over EF for USBC->USBC case.

Signed-off-by: Todd Broch <tbroch@chromium.org>

BRANCH=samus,glados,oak,gru,reef
BUG= chromium:694597 
TEST=manual, connect samus to USB-C monitor via cable and see it
select pin assigmnent 'C'

Original-Change-Id: Iddad5b654715bd30ba081c62f8fb53e07816498c
Originally-Reviewed-on: https://chromium-review.googlesource.com/465379
Commit-Ready: Todd Broch <tbroch@chromium.org>
Tested-by: Todd Broch <tbroch@chromium.org>
Reviewed-by: Vincent Palatin <vpalatin@chromium.org>
(cherry picked from commit a8e6b070cbd107d8c2f44f44ae8231a4f4efea90)

Change-Id: Ica21c46619023468d93ab7faca6284680c858005
Reviewed-on: https://chromium-review.googlesource.com/506662
Tested-by: Todd Broch <tbroch@chromium.org>
Reviewed-by: Benson Leung <bleung@chromium.org>
Reviewed-by: Vincent Palatin <vpalatin@chromium.org>
Commit-Queue: Todd Broch <tbroch@chromium.org>

[modify] https://crrev.com/13d3bfda870cfaf0debc7c676c91c10d5a990af0/common/usb_pd_policy.c

Project Member

Comment 7 by bugdroid1@chromium.org, Nov 14 2017

Labels: merge-merged-firmware-samus-6300.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/ec/+/59c30ed21687ca51bdc0a02be8367efc9647cfd9

commit 59c30ed21687ca51bdc0a02be8367efc9647cfd9
Author: Todd Broch <tbroch@chromium.org>
Date: Tue Nov 14 20:17:05 2017

pd: prefer CD pin assignments over EF for USBC->USBC case.

BRANCH=samus,glados,oak,gru,reef
BUG= chromium:694597 
TEST=manual, connect samus to USB-C monitor via cable and see it
select pin assigmnent 'C'

Signed-off-by: Todd Broch <tbroch@chromium.org>
Original-Change-Id: Iddad5b654715bd30ba081c62f8fb53e07816498c
Originally-Reviewed-on: https://chromium-review.googlesource.com/465379
Commit-Ready: Todd Broch <tbroch@chromium.org>
Tested-by: Todd Broch <tbroch@chromium.org>
Reviewed-by: Vincent Palatin <vpalatin@chromium.org>
(cherry picked from commit a8e6b070cbd107d8c2f44f44ae8231a4f4efea90)

Change-Id: I1730cb724b0c6b9537a215afcdfa1c047c98149f
Reviewed-on: https://chromium-review.googlesource.com/758180
Reviewed-by: Vincent Palatin <vpalatin@chromium.org>
Tested-by: Todd Broch <tbroch@chromium.org>
Commit-Queue: Todd Broch <tbroch@chromium.org>

[modify] https://crrev.com/59c30ed21687ca51bdc0a02be8367efc9647cfd9/common/usb_pd_policy.c

Project Member

Comment 8 by bugdroid1@chromium.org, Nov 30 2017

Labels: merge-merged-firmware-oak-8438.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/ec/+/6416ef7d8f28a6565f91ac373dc8aa5e5a1234f5

commit 6416ef7d8f28a6565f91ac373dc8aa5e5a1234f5
Author: Todd Broch <tbroch@chromium.org>
Date: Thu Nov 30 02:54:28 2017

pd: prefer CD pin assignments over EF for USBC->USBC case.

Signed-off-by: Todd Broch <tbroch@chromium.org>

BRANCH=samus,glados,oak,gru,reef
BUG= chromium:694597 
TEST=manual, connect samus to USB-C monitor via cable and see it
select pin assigmnent 'C'

Original-Change-Id: Iddad5b654715bd30ba081c62f8fb53e07816498c
Originally-Reviewed-on: https://chromium-review.googlesource.com/465379
Commit-Ready: Todd Broch <tbroch@chromium.org>
Tested-by: Todd Broch <tbroch@chromium.org>
Reviewed-by: Vincent Palatin <vpalatin@chromium.org>
(cherry picked from commit a8e6b070cbd107d8c2f44f44ae8231a4f4efea90)

Change-Id: Ibbe7a0368ad4e7dc44ef22d2bd546bf72c75b9b4
Reviewed-on: https://chromium-review.googlesource.com/506666
Reviewed-by: Benson Leung <bleung@chromium.org>
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>
Reviewed-by: Vincent Palatin <vpalatin@chromium.org>
Commit-Queue: Todd Broch <tbroch@chromium.org>
Tested-by: Todd Broch <tbroch@chromium.org>

[modify] https://crrev.com/6416ef7d8f28a6565f91ac373dc8aa5e5a1234f5/common/usb_pd_policy.c

Project Member

Comment 9 by bugdroid1@chromium.org, Dec 2 2017

Labels: merge-merged-firmware-reef-9042.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/ec/+/7988b8279a4b3a366191cc367266c278e4128936

commit 7988b8279a4b3a366191cc367266c278e4128936
Author: Todd Broch <tbroch@chromium.org>
Date: Sat Dec 02 17:21:05 2017

pd: prefer CD pin assignments over EF for USBC->USBC case.

BRANCH=samus,glados,oak,gru,reef
BUG= chromium:694597 
TEST=manual, connect samus to USB-C monitor via cable and see it
select pin assigmnent 'C'

Signed-off-by: Todd Broch <tbroch@chromium.org>

Original-Change-Id: Iddad5b654715bd30ba081c62f8fb53e07816498c
Originally-Reviewed-on: https://chromium-review.googlesource.com/465379
Commit-Ready: Todd Broch <tbroch@chromium.org>
Tested-by: Todd Broch <tbroch@chromium.org>
Reviewed-by: Vincent Palatin <vpalatin@chromium.org>
(cherry picked from commit a8e6b070cbd107d8c2f44f44ae8231a4f4efea90)

Change-Id: Ia200f52169c7e22f7ec46f053e5b1ef13f79618f
Reviewed-on: https://chromium-review.googlesource.com/804643
Commit-Queue: Todd Broch <tbroch@chromium.org>
Tested-by: Todd Broch <tbroch@chromium.org>
Reviewed-by: Benson Leung <bleung@chromium.org>

[modify] https://crrev.com/7988b8279a4b3a366191cc367266c278e4128936/common/usb_pd_policy.c

Status: Fixed (was: Started)
For samus this will land in R65 w/ this FW: 6300.276.0

Sign in to add a comment