v8 revision info not uploaded to perf waterfall |
|||||
Issue descriptionThe list of revisions gets set in our perf recipes here: https://cs.chromium.org/chromium/build/scripts/slave/slave_utils.py?type=cs&q=GetPerfDashboardRevisions&l=687 Example buildbot status page: https://build.chromium.org/p/chromium.perf/builders/Mac%20Retina%20Perf/builds/359 Ctrl+F 'got_v8_revision' --> c637865d5cb133882ef8c9b7eec4a6dca22dc4d5.. The revision shows up in the test logs correctly: https://luci-logdog.appspot.com/v/?s=chrome%2Fbb%2Fchromium.perf%2FMac_Retina_Perf%2F359%2F%2B%2Frecipes%2Fsteps%2Fv8.runtime_stats.top_25_on_Intel_GPU_on_Mac_on_Mac-10.11%2F0%2Fstdout But then something goes wrong with the dashboard upload: https://luci-logdog.appspot.com/v/?s=chrome%2Fbb%2Fchromium.perf%2FMac_Retina_Perf%2F359%2F%2B%2Frecipes%2Fsteps%2Fv8.runtime_stats.top_25_Dashboard_Upload%2F0%2Fstdout It only uploads webkit (we should remove that) and chromium git hash: "versions": {"webkit_rev": "451708", "chromium": "c49d32e2554c23beb02be20061c0b9784476fe98", "commit_pos": 451708}, martiniss: any ideas what's going wrong?
,
Mar 3 2017
Hey Stephen - any thoughts on what to do?
,
Mar 9 2017
,
Mar 10 2017
,
Mar 10 2017
I will take this bug.
,
Mar 13 2017
Thanks Ned!
,
Mar 13 2017
CL in https://chromium-review.googlesource.com/c/453740/. To have better unittest that would catch missing got_v8_revision field depends on issue 701055
,
Mar 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/04367e8e7f7186dd832b5c55e3ce36c995ddd41d commit 04367e8e7f7186dd832b5c55e3ce36c995ddd41d Author: Nghia Nguyen <nednguyen@google.com> Date: Tue Mar 14 10:29:09 2017 [SwarmingIsolatedScriptTest] Pull out v8 & webrtc revision from api.chromium.build_properties BUG= chromium:694537 Change-Id: I1799aa78aee2c6b840e7778d4993ca0e1237ac8f Reviewed-on: https://chromium-review.googlesource.com/453740 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by: Stephen Martinis <martiniss@chromium.org> [modify] https://crrev.com/04367e8e7f7186dd832b5c55e3ce36c995ddd41d/scripts/slave/recipes/chromium.py [modify] https://crrev.com/04367e8e7f7186dd832b5c55e3ce36c995ddd41d/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_passed_isolated_script_perf_test.json [modify] https://crrev.com/04367e8e7f7186dd832b5c55e3ce36c995ddd41d/scripts/slave/recipe_modules/chromium_tests/steps.py
,
Mar 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/04367e8e7f7186dd832b5c55e3ce36c995ddd41d commit 04367e8e7f7186dd832b5c55e3ce36c995ddd41d Author: Nghia Nguyen <nednguyen@google.com> Date: Tue Mar 14 10:29:09 2017 [SwarmingIsolatedScriptTest] Pull out v8 & webrtc revision from api.chromium.build_properties BUG= chromium:694537 Change-Id: I1799aa78aee2c6b840e7778d4993ca0e1237ac8f Reviewed-on: https://chromium-review.googlesource.com/453740 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by: Stephen Martinis <martiniss@chromium.org> [modify] https://crrev.com/04367e8e7f7186dd832b5c55e3ce36c995ddd41d/scripts/slave/recipes/chromium.py [modify] https://crrev.com/04367e8e7f7186dd832b5c55e3ce36c995ddd41d/scripts/slave/recipes/chromium.expected/dynamic_swarmed_sharded_passed_isolated_script_perf_test.json [modify] https://crrev.com/04367e8e7f7186dd832b5c55e3ce36c995ddd41d/scripts/slave/recipe_modules/chromium_tests/steps.py
,
Mar 14 2017
Thanks, this will only work for new data and not work retroactively, right?
,
Mar 14 2017
I believe so, unless we use some trick on the dashboard storage to backfill the old data.
,
Mar 14 2017
Log in https://luci-logdog.appspot.com/v/?s=chrome%2Fbb%2Fchromium.perf%2FMac_Retina_Perf%2F429%2F%2B%2Frecipes%2Fsteps%2Fblink_perf.css_Dashboard_Upload%2F0%2Fstdout shows that v8 & webrtc revisions are now uploaded to the perf dashboard.
,
Mar 15 2017
I just tried it out with https://chromeperf.appspot.com/report?sid=21d3e722b2f814cb1fc4e9cf30d98425f7631f283e65a3f13201379d6470b16f but it does not show up. What else is needed?
,
Mar 15 2017
Oops, was missing some config dashboard-side. I made the config fix, reloaded, and now I see the v8 revisions on the last data point.
,
Mar 15 2017
Thanks, awesome! This is going to save soooo much time. Found a bug btw. The attached screenshot shows a wrong V8 revision. This seems to be the first one with V8 revision shown and simply produces an incorrect link: https://chromium.googlesource.com/v8/v8/+log/0..49810c744f6f030780e07554b1fd830466a27353 That is a nit though because it does not impact the ranges produces from now on.
,
Mar 17 2017
Found another bug similar to #15: If one run has the same V8 range as the previous one the range link looks like: https://chromium.googlesource.com/v8/v8/+log/f7036b132f6bcce9312b52a9ba386ae487280713..f7036b132f6bcce9312b52a9ba386ae487280713 As a result no commits are shown. It should only use the link https://chromium.googlesource.com/v8/v8/+/f7036b132f6bcce9312b52a9ba386ae487280713 instead (+ instead of +log and only one commit).
,
Mar 17 2017
I filed https://github.com/catapult-project/catapult/issues/3408 for #16 |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by benhenry@chromium.org
, Feb 22 2017Status: Assigned (was: Untriaged)