New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 694508 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Favicon in tabs not shown when in Slide Over mode.

Project Member Reported by jif@chromium.org, Feb 21 2017

Issue description

The left side of the tab is pushed off the edge, so you can't see any status indication while the page is loading. You can manually scroll it back into view, but then the new tab button is obscured/faded by the tab switcher icon.
 

Comment 1 by jif@chromium.org, Feb 21 2017

The attachement is what PS1 of https://codereview.chromium.org/2706983002 looks like.
sc2.png
675 KB View Download
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/15bd5e8f3ea2b94b0d55d836e5449733e4d00e38

commit 15bd5e8f3ea2b94b0d55d836e5449733e4d00e38
Author: jif <jif@chromium.org>
Date: Tue Feb 21 14:56:06 2017

Make minimum width of tabs dynamic on iOS.

When in compact mode, reduce the maximum width of tabs in the tab strip.
Associated bug contains screenshot of what the new tabs look like.

BUG= 694508 

Review-Url: https://codereview.chromium.org/2706983002
Cr-Commit-Position: refs/heads/master@{#451760}

[modify] https://crrev.com/15bd5e8f3ea2b94b0d55d836e5449733e4d00e38/ios/chrome/browser/ui/tabs/tab_strip_controller.mm

Comment 3 by jif@chromium.org, Feb 21 2017

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified the issue on iPad Air 2 on iOS 10 tested on the build version 58.0.3026.0 canary.
Favicon for the tabs are shown in multitasking mode,looks good

Sign in to add a comment