build with gcc 6.1.0, it went rong.
Reported by
huguishe...@gmail.com,
Feb 21 2017
|
||
Issue description
UserAgent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:51.0) Gecko/20100101 Firefox/51.0
Steps to reproduce the problem:
1. I am tying to Build Chromium on unbuntu14.04.
2. Executing the command "ninja -C out/Default chrome".
What is the expected behavior?
What went wrong?
../../chrome/browser/ui/libgtkui/gtk_ui.cc:245:6: error: ‘void libgtkui::{anonymous}::PickButtonTintFromColors(SkColor, SkColor, SkColor, color_utils::HSL*)’ defined but not used [-Werror=unused-function]
void PickButtonTintFromColors(SkColor accent_color,
^~~~~~~~~~~~~~~~~~~~~~~~
Did this work before? N/A
Chrome version: <Copy from: 'about:version'> Channel: n/a
OS Version: ubuntu14.04
Flash Version:
,
Feb 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4710b6a7757ede0b8dd6850a09f96d876ab48236 commit 4710b6a7757ede0b8dd6850a09f96d876ab48236 Author: thomasanderson <thomasanderson@google.com> Date: Mon Feb 27 19:14:57 2017 Gtk: Fix GCC 6.1.0 build This CL removes PickButtonTintFromColors from gtk_ui.cc. This function was not used, and apparently only Gcc 6 caught this. BUG= 694497 R=erg@chromium.org Review-Url: https://codereview.chromium.org/2722463003 Cr-Commit-Position: refs/heads/master@{#453286} [modify] https://crrev.com/4710b6a7757ede0b8dd6850a09f96d876ab48236/chrome/browser/ui/libgtkui/gtk_ui.cc
,
Feb 27 2017
,
Feb 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4710b6a7757ede0b8dd6850a09f96d876ab48236 commit 4710b6a7757ede0b8dd6850a09f96d876ab48236 Author: thomasanderson <thomasanderson@google.com> Date: Mon Feb 27 19:14:57 2017 Gtk: Fix GCC 6.1.0 build This CL removes PickButtonTintFromColors from gtk_ui.cc. This function was not used, and apparently only Gcc 6 caught this. BUG= 694497 R=erg@chromium.org Review-Url: https://codereview.chromium.org/2722463003 Cr-Commit-Position: refs/heads/master@{#453286} [modify] https://crrev.com/4710b6a7757ede0b8dd6850a09f96d876ab48236/chrome/browser/ui/libgtkui/gtk_ui.cc |
||
►
Sign in to add a comment |
||
Comment 1 by thomasanderson@chromium.org
, Feb 27 2017Status: Started (was: Unconfirmed)