New issue
Advanced search Search tips

Issue 694465 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

CL reverted after passing CQ due to lack of is_official_build=true CQ coverage

Project Member Reported by primiano@chromium.org, Feb 21 2017

Issue description

Original CL: https://codereview.chromium.org/2502953003
Passed the CQ, reverted soon after because it broke
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20ChromeOS/builds/29509

GN args of the failing bot:
Writing """\
goma_dir = "/b/c/cipd/goma"
is_chrome_branded = true
is_debug = false
is_official_build = true
target_os = "chromeos"
use_goma = true
""" to /b/c/b/Google_Chrome_ChromeOS/src/out/Release/args.gn.

Failure:
[1518/33483] CXX newlib_pnacl_nonsfi/obj/gpu/command_buffer/client/client_sources/fenced_allocator.o
FAILED: newlib_pnacl_nonsfi/obj/gpu/command_buffer/client/client_sources/fenced_allocator.o 
/b/c/cipd/goma/gomacc ../../native_client/toolchain/linux_x86/pnacl_newlib/bin/pnacl-clang++ -MMD -MF newlib_pnacl_nonsfi/obj/gpu/command_buffer/client/client_sources/fenced_allocator.o.d -DNACL_TC_REV=5dfe030a71ca66e72c5719ef5034c2ed24706c43 -DV8_DEPRECATION_WARNINGS -DUSE_OPENSSL_CERTS=1 -DNO_TCMALLOC -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DOFFICIAL_BUILD -DGOOGLE_CHROME_BUILD -DENABLE_MEDIA_ROUTER=1 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -DNDEBUG -DNVALGRIND -DGPU_IMPLEMENTATION -I../../native_client/src/public/linux_syscalls -I../.. -Inewlib_pnacl_nonsfi/gen -I../../third_party/khronos -I../../gpu -fno-strict-aliasing -fcolor-diagnostics --pnacl-allow-translate -arch x86-32-nonsfi --pnacl-bias=x86-32-nonsfi --target=i686-unknown-nacl -Wall -Werror -Wextra -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-deprecated-register -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -O2 -fno-ident -fdata-sections -ffunction-sections -g2 -fvisibility=hidden -fvisibility-inlines-hidden -std=gnu++11 -fno-rtti -fno-exceptions -c ../../gpu/command_buffer/client/fenced_allocator.cc -o newlib_pnacl_nonsfi/obj/gpu/command_buffer/client/client_sources/fenced_allocator.o
In file included from ../../gpu/command_buffer/client/fenced_allocator.cc:7:
In file included from ../../gpu/command_buffer/client/fenced_allocator.h:15:
In file included from ../../base/bind.h:8:
In file included from ../../base/bind_internal.h:13:
../../base/bind_helpers.h:274:5: error: GNU-style inline assembly is disabled
    CHECK(is_valid_);
    ^
../../base/logging.h:575:28: note: expanded from macro 'CHECK'
  UNLIKELY(!(condition)) ? IMMEDIATE_CRASH() : EAT_STREAM_PARAMETERS
                           ^
../../base/logging.h:549:5: note: expanded from macro 'IMMEDIATE_CRASH'
    TRAP_SEQUENCE();         \
    ^
../../base/logging.h:525:7: note: expanded from macro 'TRAP_SEQUENCE'
  asm volatile(         \
      ^
1 error generated.


I managed to reproduce the failure locally. target_os="chromeos" and branding seem irrelevant. The key for reproducing seems to be is_official=true .
Which suggests that none of the bots on the CQ build with is_official=true. I did a quick check and it seems to be the case
The original CL was definitely touching code behind #if defined(OFFICIAL_BUILD).

Not sure if anything can be done here, but filing this bug to be sure.
Is the lack of official coverage WAI or accidental? I suspect the former as linux official these days takes O(hours) to link due to LTO.
 

Comment 1 by s...@google.com, Feb 21 2017

Components: -Infra Infra>CQ
I think lack of official coverage is the norm, I can't think of any is_official bots on CQ, but I'll wait for Dirk to comment. Please WontFix if this is WAI.
Status: WontFix (was: Unconfirmed)
I think this is WAI, though we are evaluating coverage and might change things ...

Sign in to add a comment