Pls add appropriate OS labels. Thank you.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/314cce71dbd6d223bef618da475a81831840d74a

commit 314cce71dbd6d223bef618da475a81831840d74a
Author: pastarmovj <pastarmovj@chromium.org>
Date: Wed Feb 22 10:46:33 2017

[sync] Fix roaming profile path for local sync database file.

The file was missing the Google prefix to make it equal to the
local profile location.

This is only a temporary fix before the proper branded name can
be used to make Branded and non-branded Chromium builds name the
location properly.

BUG= 694464 
TEST=Manual check that the right path is used.

Review-Url: https://codereview.chromium.org/2709693002
Cr-Commit-Position: refs/heads/master@{#451984}

[modify] https://crrev.com/314cce71dbd6d223bef618da475a81831840d74a/components/sync/base/sync_prefs.cc

Requesting merge permission for https://codereview.chromium.org/2709693002.

Future-proof fix is in the making but due to larger change surface I prefer to land that for 58 without merging it back to 57. Cls for the proper fix are in review:

https://codereview.chromium.org/2709783002/
https://codereview.chromium.org/2710623003/

Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

If possible, could you please merge your change to M57 branch 2987 by 5:00 PM PT tomorrow, Friday (02/24) so we can pick it up for next week beta release.
Thank you.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9bc74468e882198bfa4f3537554d8ba715b52a8c

commit 9bc74468e882198bfa4f3537554d8ba715b52a8c
Author: Julian Pastarmov <pastarmovj@chromium.org>
Date: Fri Feb 24 10:17:42 2017

[sync] Fix roaming profile path for local sync database file.

The file was missing the Google prefix to make it equal to the
local profile location.

This is only a temporary fix before the proper branded name can
be used to make Branded and non-branded Chromium builds name the
location properly.

BUG= 694464 
TEST=Manual check that the right path is used.

Review-Url: https://codereview.chromium.org/2709693002
Cr-Commit-Position: refs/heads/master@{#451984}
(cherry picked from commit 314cce71dbd6d223bef618da475a81831840d74a)

Review-Url: https://codereview.chromium.org/2711323002 .
Cr-Commit-Position: refs/branch-heads/2987@{#676}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/9bc74468e882198bfa4f3537554d8ba715b52a8c/components/sync/base/sync_prefs.cc

Step 1 is secured. We are good to go for 57.

Step 2 is half way there with the first CL landed and the second in review. Still looking good for making the 58 branch point easily.

Could some one from MTV team please help me with this issue.
Thanks in Advance.

Hi, msrchandra, to test this simply start chrome with the command line flag --enable-local-sync-backend, run it for a couple of seconds (you can do whatever you want in it), then close it and check that a path "Google\Chrome\User Data" was created in "%USERPROFILE%\AppData\Roaming". If the bug is fixed it will exist. If not you will see directly "Chrome\User Data" in this path.

Ravi, please try to test using c#11 and let me know in case if you need any help.

Thank you!

Verified the issue on Win 10 using 57.0.2987.88 and its working fine.
Please find the screen cast for the same.

Deleted: 694464_Mar_1.mp4 1.4 MB

	694464_Mar_1.mp4 1.4 MB View Download

Verified the issue on Windows 10 using Dev # 58.0.3026.3 and its working fine here too.Added respective TE-verified labels.

pastarmovj@: Could you please update the status to Fixed if no further work to be done on it.

I need to land one more CL which is going to remove the temporary solution currently in place with a long term clean one. It will be beneficial to go over the verification one more time then. It is great though that now you verified that the fix that will go in 57 is good!

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b8b5e3692189301795e9fb21fec7f371f19b7f0

commit 8b8b5e3692189301795e9fb21fec7f371f19b7f0
Author: pastarmovj <pastarmovj@chromium.org>
Date: Wed Mar 01 14:45:31 2017

[sync] Clean up path generation for the local sync database.

A lot of the logic was built into Sync although it was inherent to Chrome
to pick and build the location for its profiles. With this CL the logic is
offloaded to the PathService and injected into Sync.

Also this CL cleans up a duplication of the logic for picking the path
between the SyncPrefs and SyncServiceBase classes.

BUG= 694464 
TEST=Manual verify the right location is used.

Review-Url: https://codereview.chromium.org/2710623003
Cr-Commit-Position: refs/heads/master@{#453932}

[modify] https://crrev.com/8b8b5e3692189301795e9fb21fec7f371f19b7f0/chrome/browser/sync/chrome_sync_client.cc
[modify] https://crrev.com/8b8b5e3692189301795e9fb21fec7f371f19b7f0/chrome/browser/sync/chrome_sync_client.h
[modify] https://crrev.com/8b8b5e3692189301795e9fb21fec7f371f19b7f0/chrome/browser/sync/profile_sync_service_factory.cc
[modify] https://crrev.com/8b8b5e3692189301795e9fb21fec7f371f19b7f0/components/browser_sync/profile_sync_service.cc
[modify] https://crrev.com/8b8b5e3692189301795e9fb21fec7f371f19b7f0/components/browser_sync/profile_sync_service.h
[modify] https://crrev.com/8b8b5e3692189301795e9fb21fec7f371f19b7f0/components/browser_sync/profile_sync_service_unittest.cc
[modify] https://crrev.com/8b8b5e3692189301795e9fb21fec7f371f19b7f0/components/sync/base/sync_prefs.cc
[modify] https://crrev.com/8b8b5e3692189301795e9fb21fec7f371f19b7f0/components/sync/driver/fake_sync_client.cc
[modify] https://crrev.com/8b8b5e3692189301795e9fb21fec7f371f19b7f0/components/sync/driver/fake_sync_client.h
[modify] https://crrev.com/8b8b5e3692189301795e9fb21fec7f371f19b7f0/components/sync/driver/sync_client.h
[modify] https://crrev.com/8b8b5e3692189301795e9fb21fec7f371f19b7f0/components/sync/driver/sync_service_base.cc
[modify] https://crrev.com/8b8b5e3692189301795e9fb21fec7f371f19b7f0/components/sync/driver/sync_service_base.h
[modify] https://crrev.com/8b8b5e3692189301795e9fb21fec7f371f19b7f0/ios/chrome/browser/sync/ios_chrome_sync_client.h
[modify] https://crrev.com/8b8b5e3692189301795e9fb21fec7f371f19b7f0/ios/chrome/browser/sync/ios_chrome_sync_client.mm