New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 694449 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 680531



Sign in to add a comment

XHR send(urlSearchParams) should work

Project Member Reported by zcorpan@gmail.com, Feb 21 2017

Issue description

See https://github.com/w3c/web-platform-tests/pull/4928

Run test at http://w3c-test.org/XMLHttpRequest/send-entity-body-basic.htm

Fail	XMLHttpRequest: send() - data argument (1=2&3=4)	assert_equals: expected "1=2&3=4" but got "1%2C2%2C3%2C4="...


Standard:
https://xhr.spec.whatwg.org/#dom-xmlhttprequest-send
https://fetch.spec.whatwg.org/#bodyinit
 
Status: Available (was: Untriaged)

Comment 2 by sigbjo...@opera.com, Feb 28 2017

The failing test exercises URLSearchParams constructor record<k,v> support,

  new URLSearchParams([[1, 2], [3, 4]])

so there's a separate&dependent issue here of handling that (along with the  sequence<sequence<USVString>> variant.)

Comment 3 by sigbjo...@opera.com, Feb 28 2017

eh, the test uses nested sequence<> not records, so not dependent on  issue 685754 .

Comment 4 by sigbjo...@opera.com, Feb 28 2017

Blockedon: 680531
Owner: sigbjo...@opera.com
Status: Assigned (was: Available)
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c738672e528bf6262182e9aebf7f3b1ad3dbcee0

commit c738672e528bf6262182e9aebf7f3b1ad3dbcee0
Author: sigbjornf <sigbjornf@opera.com>
Date: Fri Mar 03 13:31:45 2017

Support XMLHttpRequest.send(URLSearchParams)

Update send()'s overloaded set to also include URLSearchParams,
mirroring a recent BodyInit spec addition,

 https://fetch.spec.whatwg.org/#bodyinit

R=yhirano,tyoshino
BUG= 694449 

Review-Url: https://codereview.chromium.org/2723583005
Cr-Commit-Position: refs/heads/master@{#454571}

[add] https://crrev.com/c738672e528bf6262182e9aebf7f3b1ad3dbcee0/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/resources/echo-content.php
[add] https://crrev.com/c738672e528bf6262182e9aebf7f3b1ad3dbcee0/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/send-entity-body-basic.html
[add] https://crrev.com/c738672e528bf6262182e9aebf7f3b1ad3dbcee0/third_party/WebKit/LayoutTests/http/tests/xmlhttprequest/send-entity-body-charset.html
[modify] https://crrev.com/c738672e528bf6262182e9aebf7f3b1ad3dbcee0/third_party/WebKit/Source/bindings/core/v8/BUILD.gn
[modify] https://crrev.com/c738672e528bf6262182e9aebf7f3b1ad3dbcee0/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp
[modify] https://crrev.com/c738672e528bf6262182e9aebf7f3b1ad3dbcee0/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.h
[modify] https://crrev.com/c738672e528bf6262182e9aebf7f3b1ad3dbcee0/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.idl

Status: Fixed (was: Assigned)

Sign in to add a comment