New issue
Advanced search Search tips

Issue 694446 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

layout test controllers run script in the context of popup pages (ie. select elements)

Project Member Reported by jochen@chromium.org, Feb 21 2017

Issue description

e.g. in fast/forms/calendar-picker/date-picker-ax.html the accessibility events are dispatched from the webframe that powers the select element, but the accessibility controller then invokes the notification callback in the context of the <select> popup (instead of the main page)
 

Comment 1 by jochen@chromium.org, Feb 21 2017

after some more digging, it turns out that window.internals.pagePopupWindow exposes access to the popup window context to layout tests :/

Comment 3 by jochen@chromium.org, Feb 22 2017

Owner: jochen@chromium.org
Status: Fixed (was: Unconfirmed)
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a1bc1be11daef8aa12a72251bb7c9f9ca75cc36

commit 9a1bc1be11daef8aa12a72251bb7c9f9ca75cc36
Author: wfh <wfh@chromium.org>
Date: Thu Feb 23 20:40:05 2017

Change security checks on scheduled actions to DCHECKs.

BUG=693695,  694446 ,  695336 

Review-Url: https://codereview.chromium.org/2709383003
Cr-Commit-Position: refs/heads/master@{#452611}

[modify] https://crrev.com/9a1bc1be11daef8aa12a72251bb7c9f9ca75cc36/third_party/WebKit/Source/bindings/core/v8/ScheduledAction.cpp

Project Member

Comment 5 by bugdroid1@chromium.org, Feb 25 2017

Labels: merge-merged-3021
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6385cf88e2c8d0c18c4ee08fca1398a2c4f66c0b

commit 6385cf88e2c8d0c18c4ee08fca1398a2c4f66c0b
Author: Grace Kihumba <gkihumba@google.com>
Date: Sat Feb 25 00:47:38 2017

Change security checks on scheduled actions to DCHECKs.

BUG=693695,  694446 ,  695336 

Review-Url: https://codereview.chromium.org/2709383003
Cr-Commit-Position: refs/heads/master@{#452611}
(cherry picked from commit 9a1bc1be11daef8aa12a72251bb7c9f9ca75cc36)

Review-Url: https://codereview.chromium.org/2717783002 .
Cr-Commit-Position: refs/branch-heads/3021@{#3}
Cr-Branched-From: 24ff81d5bbced05323d0ea9a56b3cac756015c7d-refs/heads/master@{#452347}

[modify] https://crrev.com/6385cf88e2c8d0c18c4ee08fca1398a2c4f66c0b/third_party/WebKit/Source/bindings/core/v8/ScheduledAction.cpp

Sign in to add a comment