New issue
Advanced search Search tips

Issue 694444 link

Starred by 2 users
Status: WontFix
Owner: ----
Closed: Feb 2017
Cc:
haraken@chromium.org
lfg@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Replaceable] tag does not result in correct behaviour for self.origin in js-test

Project Member Reported by andypaicu@chromium.org, Feb 21 2017 
Chrome Version: (copy from chrome://version)
OS: (e.g. Win7, OSX 10.9.5, etc...)

What steps will reproduce the problem?
(1) Run attached test.
(2) Notice it fails because it's not correctly evaling origin in 'shouldBeUndefined'.


Since self.origin was added, this test (and others like it) had to be modified to use a different variable name other than 'origin'. It seems that when evaling 'origin', it picks up self.origin as if it did not have [Replaceable].

Please use labels and text to provide additional information.


For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.
handshake-fail-by-maxlength.html
1.2 KB View Download

Comment 1 by jochen@chromium.org, Feb 22 2017

Cc: haraken@chromium.org
Components: Blink>Bindings
Status: WontFix (was: Untriaged)
I'd say that this is the correct behavior. Replaceable only says that there should be a setter that allows for shadowing the attribute, and just putting "var origin;" in your script doesn't actually assign undefined to origin. It only creates the property if it doesn't exist yet.
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7

commit f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7
Author: andypaicu <andypaicu@chromium.org>
Date: Sat Mar 04 02:00:13 2017

Added support for self.origin in Window and WorkerGlobalScope

Added origin to the interface files
Added firefox tests for frames into the wpt
Created and added tests for workers into the wpt
Intent to ship: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/oPGdc9lqpg8/gSjBah0YCAAJ

BUG= 690195 , 694444 
R=mkwst@chromium.org

Review-Url: https://codereview.chromium.org/2706013002
Cr-Commit-Position: refs/heads/master@{#454747}

[delete] https://crrev.com/f5a29c6561e3820a5e71e03c85eb7597b797bfd7/third_party/WebKit/LayoutTests/external/wpt/html/dom/self-origin.sub-expected.txt
[add] https://crrev.com/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7/third_party/WebKit/LayoutTests/external/wpt/html/webappapis/the-windoworworkerglobalscope-mixin/Worker_Self_Origin.html
[add] https://crrev.com/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7/third_party/WebKit/LayoutTests/external/wpt/html/webappapis/the-windoworworkerglobalscope-mixin/support/WorkerSelfOriginSharedWorker.js
[add] https://crrev.com/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7/third_party/WebKit/LayoutTests/external/wpt/html/webappapis/the-windoworworkerglobalscope-mixin/support/WorkerSelfOriginWorker.js
[modify] https://crrev.com/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-navigated-expected.txt
[modify] https://crrev.com/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced-expected.txt
[modify] https://crrev.com/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-expected.txt
[modify] https://crrev.com/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-navigated-expected.txt
[modify] https://crrev.com/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced-expected.txt
[modify] https://crrev.com/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt
[modify] https://crrev.com/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7/third_party/WebKit/LayoutTests/fast/dom/Window/resources/window-property-collector.js
[modify] https://crrev.com/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7/third_party/WebKit/LayoutTests/http/tests/websocket/handshake-fail-by-maxlength-expected.txt
[modify] https://crrev.com/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7/third_party/WebKit/LayoutTests/http/tests/websocket/handshake-fail-by-maxlength.html
[modify] https://crrev.com/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7/third_party/WebKit/LayoutTests/http/tests/websocket/handshake-fail-by-prepended-null-expected.txt
[modify] https://crrev.com/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7/third_party/WebKit/LayoutTests/http/tests/websocket/handshake-fail-by-prepended-null.html
[modify] https://crrev.com/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7/third_party/WebKit/LayoutTests/http/tests/websocket/iframe-sandbox-expected.txt
[modify] https://crrev.com/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7/third_party/WebKit/LayoutTests/http/tests/websocket/iframe-sandbox.html
[modify] https://crrev.com/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7/third_party/WebKit/LayoutTests/http/tests/websocket/send-onmessage-origin-expected.txt
[modify] https://crrev.com/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7/third_party/WebKit/LayoutTests/http/tests/websocket/send-onmessage-origin.html
[modify] https://crrev.com/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7/third_party/WebKit/LayoutTests/platform/linux/fast/dom/Window/property-access-on-cached-properties-after-frame-navigated-expected.txt
[modify] https://crrev.com/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7/third_party/WebKit/LayoutTests/platform/linux/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced-expected.txt
[modify] https://crrev.com/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7/third_party/WebKit/LayoutTests/platform/linux/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-expected.txt
[modify] https://crrev.com/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7/third_party/WebKit/LayoutTests/platform/linux/fast/dom/Window/property-access-on-cached-window-after-frame-navigated-expected.txt
[modify] https://crrev.com/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7/third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7/third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7/third_party/WebKit/LayoutTests/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp
[modify] https://crrev.com/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7/third_party/WebKit/Source/core/frame/LocalDOMWindow.h
[modify] https://crrev.com/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7/third_party/WebKit/Source/core/frame/Window.idl
[modify] https://crrev.com/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7/third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp
[modify] https://crrev.com/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7/third_party/WebKit/Source/core/workers/WorkerGlobalScope.h
[modify] https://crrev.com/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7/third_party/WebKit/Source/core/workers/WorkerGlobalScope.idl
►

Sign in to add a comment