New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 694441 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 696986
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Incorrect-function-pointer-type in sh::TInfoSinkBase::operator<<

Project Member Reported by ClusterFuzz, Feb 21 2017

Issue description

Project Member

Comment 1 by sheriffbot@chromium.org, Feb 21 2017

Labels: M-58
Project Member

Comment 2 by sheriffbot@chromium.org, Feb 21 2017

Labels: ReleaseBlock-Beta
This issue is a security regression. If you are not able to fix this quickly, please revert the change that introduced it.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 3 by sheriffbot@chromium.org, Feb 21 2017

Labels: Pri-1
Components: Internals>GPU>ANGLE
Owner: kbr@chromium.org
Status: Assigned (was: Untriaged)
kbr@ can you take a look at this or assign to someone who can? Also, do you know why third_party/angle doesn't have an OWNERS file? Thank you.

Comment 5 by kbr@chromium.org, Feb 21 2017

Cc: kbr@chromium.org cwallez@chromium.org jmad...@chromium.org
Owner: geoffl...@chromium.org
Geoff, could you please find someone to take this bug?

Separately, could the ANGLE team please add an OWNERS file at the top level to help with automatic assignment of these bugs? Thanks.

Cc: oetu...@nvidia.com
Labels: -ReleaseBlock-Beta
Very unlikely to be a new regression.  Going to remove the ReleaseBlock tag.
Project Member

Comment 8 by sheriffbot@chromium.org, Mar 1 2017

Labels: ReleaseBlock-Beta
This issue is a security regression. If you are not able to fix this quickly, please revert the change that introduced it.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Owner: cwallez@chromium.org
Status: Started (was: Assigned)
Snatching this as the bot really wants it to be a release blocker.
Cc: erikc...@chromium.org
I am not able to reproduce this with the compile flags mentioned in the Reproducing.md

What's weird is that the UBSAN error is inside std::ostrinstream::operator<<(float), it looks like it is calling free() with a function pointer that is not a void(*)(void*).

+cc erikchen: https://chromium.googlesource.com/chromium/src/+/eff0ecbf12a6757ebb46438100fef60dff531e43 is in range and touches allocator stuff by adding an extra argument. Could it be related to this failure?
Probably a dupe of https://bugs.chromium.org/p/chromium/issues/detail?id=696986, which was recently fixed. Is this error still reproducible?
Mergedinto: 696986
Status: Duplicate (was: Started)
Yep the issue is reproducible on the commit's parent and not with the commit applied. Thanks!
Project Member

Comment 14 by ClusterFuzz, Mar 2 2017

ClusterFuzz has detected this issue as fixed in range 453899:453905.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5557601535524864

Fuzzer: libfuzzer_gpu_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Incorrect-function-pointer-type
Crash Address: 
Crash State:
  sh::TInfoSinkBase::operator<<
  sh::TOutputGLSLBase::writeFloat
  sh::TOutputGLSLBase::writeConstantUnion
  
Sanitizer: undefined (UBSAN)

Recommended Security Severity: Medium

Regressed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_ubsan&range=451608:451624
Fixed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_ubsan&range=453899:453905

Reproducer Testcase: https://cluster-fuzz.appspot.com/download/AMIfv97SLWJVJ_tRnU-d8PL9fHrf1Gl21Ligj1TsNObE2kvdH7jh0brDs0LnWd1VH8Ey0divu128jUNC6vzfjRT_6gr9OZp8yXgooO5Ip9B3rA19pOXzy-i-Csm6BCzGcC16XBdQcHc5fmAN9QGbUUDz2SBSR-dnSRqDEy04YjMtUHRx7f8reNaOwhKWjPji21cZqI7FQZMQwjgMUAQBGIFqQjUyJVLITkfdVO5dWQ8CFYhqGqxCcZCprFE21DF4ewp23Mtmc4oqddSZ94RfEMRHT4ZHyS3RnzoWx7BtPweK6esG2bU2S-lLyhjiKgY73_xubwWpC_ibohDfzoOt87fMf0l9DHl8OyWZ2pX79CpypvOm-nGc5jIxgaGGvsFyv9Zzst2NuGDXvKCNwKlcW0es0D2ZbkDQRQ?testcase_id=5557601535524864


See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 15 by sheriffbot@chromium.org, Jun 8 2017

Labels: -Restrict-View-SecurityTeam allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment