New issue
Advanced search Search tips

Issue 694430 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Relax Request constructor around referrers

Project Member Reported by annevank...@gmail.com, Feb 21 2017

Issue description

See https://github.com/whatwg/fetch/pull/377 for the change to the standard.

http://w3c-test.org/fetch/api/policies/referrer-origin.html has a test, but please read https://github.com/w3c/web-platform-tests/issues/2618 for why the first test fails there (and the second test might too I suppose).
 
Components: Blink>Network>FetchAPI
Status: Available (was: Untriaged)
Heads up I took a stab at this with https://chromium-review.googlesource.com/c/chromium/src/+/719781
Thanks for filing the bug, Anne.

FTR, it was originally landed by https://chromium.googlesource.com/chromium/src/+/6b324faa61bbfbf09ca255a14078992a17af3e59%5E%21/

and, thanks, Dom for working on it.
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c982e50ebb994bafd41212d9c1d6e3dbf1231bb8

commit c982e50ebb994bafd41212d9c1d6e3dbf1231bb8
Author: Dominic Farolino <domfarolino@gmail.com>
Date: Thu Jan 04 10:07:09 2018

Relax request constructor on x-origin referrers

Bug:  694430 

This addresses the WHATWG FETCH specification change outlined by Anne
in the bug, to relax the Request constructor to not throw a TypeError
when initializing a Request object with a cross-origin referrer

R=yhirano@chromium.org

Change-Id: I891d2b29b7c21cbeffd9645b9d1daadba63c2358
Reviewed-on: https://chromium-review.googlesource.com/719781
Commit-Queue: Yoav Weiss <yoav@yoav.ws>
Reviewed-by: Yoav Weiss <yoav@yoav.ws>
Cr-Commit-Position: refs/heads/master@{#526951}
[delete] https://crrev.com/14655855f937778a1f28b203ebeafb88102a86e2/third_party/WebKit/LayoutTests/external/wpt/fetch/api/policies/referrer-origin-expected.txt
[delete] https://crrev.com/14655855f937778a1f28b203ebeafb88102a86e2/third_party/WebKit/LayoutTests/external/wpt/fetch/api/policies/referrer-origin-service-worker.https-expected.txt
[delete] https://crrev.com/14655855f937778a1f28b203ebeafb88102a86e2/third_party/WebKit/LayoutTests/external/wpt/fetch/api/policies/referrer-origin-worker-expected.txt
[delete] https://crrev.com/14655855f937778a1f28b203ebeafb88102a86e2/third_party/WebKit/LayoutTests/external/wpt/fetch/api/request/request-init-001.sub-expected.txt
[modify] https://crrev.com/c982e50ebb994bafd41212d9c1d6e3dbf1231bb8/third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/request.js
[modify] https://crrev.com/c982e50ebb994bafd41212d9c1d6e3dbf1231bb8/third_party/WebKit/Source/core/fetch/Request.cpp

Status: Fixed (was: Available)
Owner: domfarolino@gmail.com

Sign in to add a comment